From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 422F928B4E1; Fri, 8 May 2026 12:15:01 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778242501; cv=none; b=GKOaPBc56kECqdZaAFw9Tqza9xm4XlpkuuL6/CNqyuNIzk8DiVICVJNlyIY3AWYqTDU1LF68PWnRJfCT3dfDbAb3/VctCS+WJLypOgNy9CSUAy1vHFOI+R8kPx4JWvn8Z0/oB9qksLS/vLfEySrzo8h4skXFCmJ9dSeerk4b0Kk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778242501; c=relaxed/simple; bh=LIdeVujzhsWE+LPahyHigIFjeWFf7XsxrsMHo42ItEA=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=erUP5PbsbaMO/uRG87R4KwIXVxw6JZGqmWthlx7DOYS1yHJv0fz2rZ1Pj0nD9N/zm1xOWxlmnGYo6lgiq1r2TMKcyEr+Owaki5gg32IOhfIJ7zVREOEqWHV1s7bqBIPhkmuIYqjj16AIETQZhpmHKUgiYHCVmQQqK88yJ+ZYXoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=M3Kkl6qe; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="M3Kkl6qe" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 8184AC2BCB0; Fri, 8 May 2026 12:14:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778242500; bh=LIdeVujzhsWE+LPahyHigIFjeWFf7XsxrsMHo42ItEA=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=M3Kkl6qez/qYNPjblySb8cckfsrlsnsraPGJkex4XavmY1y3KcegS456TLaWltY1R 4/JZnJ1g/7hxtxxAqQfoI3dnKS48XChcB8T8pcYuyszyvOM5EJ+nVCvVpAxWHrCcOd 02loeHliuJ0mjZg3nXipQDDmMQuJyqtsOxC6ebh9iZTSQVtioBHRscZG3CfWZb7UiJ JsuRJdVeBObNgoLeRWDGqKJHl7wiBV3VsCr8I3VtrSMYPFAU7J8tig5zdxGXGg+oAt b3lYoV4X86B0JtM0RyPzHLZ0kLp1t+Fc+y2R7fx4GlX5kjGeIs00jc31nCXOgwcUkq tGsvDZzo4E/eA== Date: Fri, 8 May 2026 20:14:56 +0800 From: Nathan Chancellor To: Bart Van Assche Cc: Peter Zijlstra , linux-tip-commits@vger.kernel.org, x86@kernel.org, linux-kernel@vger.kernel.org Subject: Re: [tip: locking/core] locking/rtmutex: Annotate API and implementation Message-ID: <20260508121456.GA208829@ax162> References: <20260505022649.870788-1-bvanassche@acm.org> <177797853432.424702.11529123964407349507.tip-bot2@tip-bot2> <20260507084357.GA961911@ax162> <0ffcd368-d4a1-4649-a75f-881b95fd4dbe@acm.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <0ffcd368-d4a1-4649-a75f-881b95fd4dbe@acm.org> On Thu, May 07, 2026 at 12:09:25PM +0200, Bart Van Assche wrote: > On 5/7/26 10:43 AM, Nathan Chancellor wrote: > > On Tue, May 05, 2026 at 10:55:34AM -0000, tip-bot2 for Bart Van Assche wrote: > > > The following commit has been merged into the locking/core branch of tip: > > > > > > Commit-ID: d30a456aa7ce1bab05d9b364eeacad0c9cb10cc2 > > > Gitweb: https://git.kernel.org/tip/d30a456aa7ce1bab05d9b364eeacad0c9cb10cc2 > > > Author: Bart Van Assche > > > AuthorDate: Tue, 05 May 2026 04:26:44 +02:00 > > > Committer: Peter Zijlstra > > > CommitterDate: Tue, 05 May 2026 12:50:49 +02:00 > > > > > > locking/rtmutex: Annotate API and implementation > > > > > > Add lock context annotations to the rtmutex API and implementation and > > > enable lock context analysis. > > > > > > Signed-off-by: Bart Van Assche > > > Signed-off-by: Peter Zijlstra (Intel) > > > Link: https://patch.msgid.link/20260505022649.870788-1-bvanassche@acm.org > > > > This breaks the build for me. > > > > $ make -skj"$(nproc)" ARCH=x86_64 LLVM=1 mrproper defconfig kernel/locking/rtmutex_api.o > > kernel/locking/rtmutex_api.c:93:1: error: expecting rt_mutex 'lock' to be held at the end of function [-Werror,-Wthread-safety-analysis] > > 93 | } > > | ^ > > kernel/locking/rtmutex_api.c:90:14: note: rt_mutex acquired here > > 90 | void __sched rt_mutex_lock(struct rt_mutex *lock) > > | ^ > > 1 error generated. > > > > This is with LLVM 22.1.5, in case it matters. > > Hi Nathan, > > I think this is the same error as what has been reported by the kernel > test robot > (https://lore.kernel.org/all/202605060005.JYWpZXr2-lkp@intel.com/). > I plan to post a new version with a fix for CONFIG_DEBUG_LOCK_ALLOC=n > soon. Thanks, I missed that report in trying to keep up with my inbox on vacation :) In the meantime, perhaps this should be dropped from locking/core since it is on top? Peter? -- Cheers, Nathan