From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 399F13DBD76; Fri, 8 May 2026 12:44:09 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778244250; cv=none; b=TY9JUxF7eWl/vOiCyw+lDQ838Iaq/EQfHx88J4rwGRdaTPvmfqrUNanimuBVKcaQj1my770nCt7GAq3lsryKIilotfhL/KjYv1k/MhH8VrBPcPvZ/KlnOAeLScDp0zxi9U1liLq1ynVLlPvh7U9DzBg0U4LOo3hm7QjMeTMrayg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778244250; c=relaxed/simple; bh=CKBd/NSWaegSrgWu/p2Tb4ewlIZvc9gvEqqf/e1+h9M=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=nN6VU57AnAvSmj73hbzW+swwBBnIYdmEl4vrbElv8fI2YzCYwb/Hu/Zjkh120VJcdknfb2Po16GgtMa422m4pheAQyq/zPZEKTaBcTiu+hubdyZ6XLT+KSB5bqWCHvEQnHKaAhkZ2/dTjQ4ypFqVo7JjsZGvj2TYSw3CAzZpN6I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=ce5jX6wU; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="ce5jX6wU" Received: by smtp.kernel.org (Postfix) with ESMTPSA id A8356C2BCB0; Fri, 8 May 2026 12:44:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778244249; bh=CKBd/NSWaegSrgWu/p2Tb4ewlIZvc9gvEqqf/e1+h9M=; h=From:To:Cc:Subject:Date:From; b=ce5jX6wUy2iov9HblRXdSBhws0z/zjyqh/3iGZ5wTq5Qp+qI3Q2Huf8enrZ/dc8ou GML9JTzUTrLnNgIcuHGbHjSVlsSv4QCzBIcJTtvD1FxWSUQt0eBhZfRiO9TmX/8y/S 4DnxohSMF/IZhwjG7noK9pZkjgPnbWyOQjBF6AKTYrSan+Ymu4YChPrkdWNZGdTkaY NfIPXmV84dszmnfu85Ga+B+0xCnCpimtDjMMP3BgUsDprm1k+AzrPY8cniBqwtc5f1 4ALFhjra39OVKug3BbagGVtrb+DxV/s5SwoHqIN18LIzXaGJOCMfwhT9OwPYX+NnpD kY8EGdasg+irQ== From: Arnd Bergmann To: Bin Du , Nirujogi Pratap , Mauro Carvalho Chehab , Sultan Alsawaf , Svetoslav Stoilov , Sakari Ailus Cc: Arnd Bergmann , Bin Du , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] [v2] media: platform: amd: avoid -Wformat-security warning Date: Fri, 8 May 2026 14:43:49 +0200 Message-Id: <20260508124402.3082615-1-arnd@kernel.org> X-Mailer: git-send-email 2.39.5 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnd Bergmann The newly added kthread_run() call passes a string variable as an sprintf() style format, which gcc warns about when -Wformat-security is enabled: drivers/media/platform/amd/isp4/isp4_subdev.c: In function 'isp4sd_start_resp_proc_threads': include/linux/kthread.h:71:16: error: format not a string literal and no format arguments [-Werror=format-security] 71 | struct task_struct *__k \ | ^~~~~~~~~~~ drivers/media/platform/amd/isp4/isp4_subdev.c:596:38: note: in expansion of macro 'kthread_run' 596 | thread_ctx->thread = kthread_run(isp4sd_fw_resp_thread, | ^~~~~~~~~~~ Use an indirect "%s" format to do this safely, avoiding the warning. Fixes: 4e5e7a7ddb4a ("media: platform: amd: isp4 subdev and firmware loading handling added") Tested-by: Bin Du Signed-off-by: Arnd Bergmann --- v2: avoid overly long line --- drivers/media/platform/amd/isp4/isp4_subdev.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/media/platform/amd/isp4/isp4_subdev.c b/drivers/media/platform/amd/isp4/isp4_subdev.c index 48deea79ce6c..427e9ba910bb 100644 --- a/drivers/media/platform/amd/isp4/isp4_subdev.c +++ b/drivers/media/platform/amd/isp4/isp4_subdev.c @@ -595,6 +595,7 @@ static int isp4sd_start_resp_proc_threads(struct isp4_subdev *isp_subdev) thread_ctx->thread = kthread_run(isp4sd_fw_resp_thread, &isp_subdev->isp_resp_para[i], + "%s", isp4sd_thread_name[i]); if (IS_ERR(thread_ctx->thread)) { dev_err(dev, "create thread [%d] fail\n", i); -- 2.39.5