From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 53186194C96 for ; Fri, 8 May 2026 22:01:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778277699; cv=none; b=gcwH43q5+nib9lIHCpAMMXex9UVf/RQah5SItFlfDtkoRE5cKse56b+zM3/PM5yyNH/2nIhpY5yiNz8+y6WK2EgF1tx5defHtq5/4wGFGPJenN1d01SGX67xlViW7VTg7C4VlVk0Mkat2zpfA4OvmvDYgRgcMNYdGpokmMtYqeQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778277699; c=relaxed/simple; bh=TFFGfaDzh8waYoEt8jLINiE7oLKEHd+S3uUECMlHZc8=; h=Date:From:To:Cc:Subject:Message-Id:In-Reply-To:References: Mime-Version:Content-Type; b=YdaGmd6bpKWxYl2oBcO8okyj0WQZPFzznpV3nEFdRykllSJ4RFmT+G4R7YVYdfWo+OrxiJ0H1tqNJtho+eFT+jDkjAPy6AO6UyCDsqyGaH1PzSUbfWT3w7Ce6Ezv2680dVhBa24049LmV3Mmi4xFjCAozzLU+peqFDaRvvAP3tI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b=d7llvSYs; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux-foundation.org header.i=@linux-foundation.org header.b="d7llvSYs" Received: by smtp.kernel.org (Postfix) with ESMTPSA id C1946C2BCB0; Fri, 8 May 2026 22:01:38 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=linux-foundation.org; s=korg; t=1778277699; bh=TFFGfaDzh8waYoEt8jLINiE7oLKEHd+S3uUECMlHZc8=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=d7llvSYshRamFmij8qRP/sZwuZRxJMwDTmNXH2TOgPdI83O5BMxAg/MHz/F6aRSwU DNeZIqkLczaxFw1c14trqCNdUxq3DthDiDEtT69Hx389iMlb2ylI9FLdYFeBhWjVmX dLY2NGRKARC4Wd9QcE1eis13rFD4688lfKF8Wj1k= Date: Fri, 8 May 2026 15:01:38 -0700 From: Andrew Morton To: Joonwon Kang Cc: dennis@kernel.org, tj@kernel.org, cl@gentwo.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, dodam@google.com Subject: Re: [PATCH v4 1/4] percpu: Fix wrong chunk hints update Message-Id: <20260508150138.3c90c36d08d140fdb7cf55dd@linux-foundation.org> In-Reply-To: <20260506142100.1289509-1-joonwonkang@google.com> References: <20260506142100.1289509-1-joonwonkang@google.com> X-Mailer: Sylpheed 3.8.0beta1 (GTK+ 2.24.33; x86_64-pc-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Wed, 6 May 2026 14:20:56 +0000 Joonwon Kang wrote: > Chunk end offset was set to a block end offset, which could prevent > chunk hints from being updated correctly. It was observed that the chunk > free size gets minus or shorter than the actual free size due to this. > This commit fixes it. AI review: https://sashiko.dev/#/patchset/20260506142100.1289509-1-joonwonkang@google.com The first comment seems valid: CC mm/percpu-stats.o mm/percpu-stats.c: In function 'chunk_map_stats': mm/percpu-stats.c:125:9: error: aggregate value used where an integer was expected 125 | P("contig_bytes", chunk_md->contig_hint * PCPU_MIN_ALLOC_SIZE); | ^