From: Marco Crivellari <marco.crivellari@suse.com>
To: linux-kernel@vger.kernel.org, linux-sound@vger.kernel.org
Cc: Tejun Heo <tj@kernel.org>, Lai Jiangshan <jiangshanlai@gmail.com>,
Frederic Weisbecker <frederic@kernel.org>,
Sebastian Andrzej Siewior <bigeasy@linutronix.de>,
Marco Crivellari <marco.crivellari@suse.com>,
Michal Hocko <mhocko@suse.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>, Jaroslav Kysela <perex@perex.cz>,
Takashi Iwai <tiwai@suse.com>,
David Rhodes <david.rhodes@cirrus.com>,
Richard Fitzgerald <rf@opensource.cirrus.com>,
patches@opensource.cirrus.com
Subject: [RFC PATCH 1/2] ASoC: cs42l43: Move long delayed work on system_dfl_long_wq
Date: Fri, 8 May 2026 17:03:18 +0200 [thread overview]
Message-ID: <20260508150327.351779-2-marco.crivellari@suse.com> (raw)
In-Reply-To: <20260508150327.351779-1-marco.crivellari@suse.com>
Move long delayed work on system_dfl_long_wq
Currently the code enqueue work items using {queue|mod}_delayed_work(),
using system_long_wq. This workqueue should be used when long works are
expected and it is a per-cpu workqueue.
The function(s) end up calling __queue_delayed_work(), which set a global
timer that could fire anywhere, enqueuing the work where the timer fired.
Unbound works could benefit from scheduler task placement, to optimize
performance and power consumption. Long work shouldn't stick to a single
CPU.
Recently, a new unbound workqueue specific for long running work has
been added:
c116737e972e ("workqueue: Add system_dfl_long_wq for long unbound works")
Since the workqueue work doesn't rely on per-cpu variables, there is no
obvious reason that justify the use of a per-cpu workqueue. So change
system_long_wq with system_dfl_long_wq so that the work may benefit from
scheduler task placement.
Cc: David Rhodes <david.rhodes@cirrus.com>
Cc: Richard Fitzgerald <rf@opensource.cirrus.com>
Cc: <patches@opensource.cirrus.com>
Signed-off-by: Marco Crivellari <marco.crivellari@suse.com>
---
sound/soc/codecs/cs42l43-jack.c | 5 +++--
1 file changed, 3 insertions(+), 2 deletions(-)
diff --git a/sound/soc/codecs/cs42l43-jack.c b/sound/soc/codecs/cs42l43-jack.c
index 3e04e6897b14..934666295ee3 100644
--- a/sound/soc/codecs/cs42l43-jack.c
+++ b/sound/soc/codecs/cs42l43-jack.c
@@ -805,7 +805,7 @@ irqreturn_t cs42l43_tip_sense(int irq, void *data)
if (priv->suspend_jack_debounce)
db_delay += priv->tip_fall_db_ms + priv->tip_rise_db_ms;
- queue_delayed_work(system_long_wq, &priv->tip_sense_work,
+ queue_delayed_work(system_dfl_long_wq, &priv->tip_sense_work,
msecs_to_jiffies(db_delay));
return IRQ_HANDLED;
@@ -932,7 +932,8 @@ int cs42l43_jack_put(struct snd_kcontrol *kcontrol, struct snd_ctl_elem_value *u
snd_soc_jack_report(priv->jack_hp, 0, 0xFFFF);
if (!override) {
- queue_delayed_work(system_long_wq, &priv->tip_sense_work, 0);
+ queue_delayed_work(system_dfl_long_wq, &priv->tip_sense_work,
+ 0);
} else {
override--;
--
2.53.0
next prev parent reply other threads:[~2026-05-08 15:03 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-08 15:03 [RFC PATCH 0/2] ASoC: Move system_long_wq to system_dfl_long_wq Marco Crivellari
2026-05-08 15:03 ` Marco Crivellari [this message]
2026-05-08 15:17 ` [RFC PATCH 1/2] ASoC: cs42l43: Move long delayed work on system_dfl_long_wq Charles Keepax
2026-05-08 15:03 ` [RFC PATCH 2/2] ASoC: codecs: rt5640: " Marco Crivellari
2026-05-11 0:52 ` [RFC PATCH 0/2] ASoC: Move system_long_wq to system_dfl_long_wq Mark Brown
2026-05-11 12:08 ` Marco Crivellari
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508150327.351779-2-marco.crivellari@suse.com \
--to=marco.crivellari@suse.com \
--cc=bigeasy@linutronix.de \
--cc=broonie@kernel.org \
--cc=david.rhodes@cirrus.com \
--cc=frederic@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=mhocko@suse.com \
--cc=patches@opensource.cirrus.com \
--cc=perex@perex.cz \
--cc=rf@opensource.cirrus.com \
--cc=tiwai@suse.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox