From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f180.google.com (mail-dy1-f180.google.com [74.125.82.180]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5F44E3FCB20 for ; Fri, 8 May 2026 15:26:35 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.180 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253997; cv=none; b=YmhvbUaalEIS053qH0+ObM/ZraGu1CVqm1Bi5M2iTY1denVAie9D0UdEbkTWDg9yIrvIFGM6lSpvFIKJ1/jpSsyKTuEng0+QjJ1tSYuvucOCDEZX00TR/Dm0Gbol/UO+CN5mkiUxODTlHH/mKrlxfqWIr8SDGf/VAO2KhoanhVM= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778253997; c=relaxed/simple; bh=8Qwf36rId+Ems/1eDwX4FkjrATBDA7Znl2SUcpy1ZKM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=klDrevk1V4YGGtYKXxznn2igEiDFRImuC+8NICY2ofzJ8abxdgGbGsT05eFsRvLjIplZOVny5Z0nhiI/XYd/E1M4FxkDuQl3QufQ+jOPJMViSlY6P7aZeQuLlFbIpa+F8gLn8C6TZzEScrxWxqIutoVHtQXLkQTqCncBQtJNrR0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gQQf0al+; arc=none smtp.client-ip=74.125.82.180 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gQQf0al+" Received: by mail-dy1-f180.google.com with SMTP id 5a478bee46e88-2f0d3e07e30so5527378eec.0 for ; Fri, 08 May 2026 08:26:35 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778253994; x=1778858794; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=R8eLQlhXdKYRqwLg4DykUyxCfZQPw4q7VqcTUbCsSV0=; b=gQQf0al+Ql9V8ivsZYRc9GP4KYBcCsvgTIgyDeuSEae7IsHOKlyQ4IfUc5Euslx4eJ WBSYsD6FzKaQWBfYutn6tqQRKqkYox/Te07X2cODbclAcIEHpixlOvB+Zl/pQR9m0kxV cExVgIaxzU1cqb15oWo5pvV7q5VbiYXn0GwpDg/Du5fcd9wDrMZXwFhrotsoPgg8X4se jJ6IfMRATVuYBUkaq/tp5d/QNeP8ySzZ/ixmLSm+aTvHL43WP5fw1OkB82KuIAuhUDfZ LffHzPkvMZNnx/9WegllhOxvECbIRV4kHXmEsly78Xs3AdlOYnYN0kCW9SGV6eTktOGD 8uBQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778253994; x=1778858794; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=R8eLQlhXdKYRqwLg4DykUyxCfZQPw4q7VqcTUbCsSV0=; b=VkKFJexbBAX3CQUIHZ7wkIDyOYZ0szjEFUl+raT6LQrWDBqO1SoMeX/enNv9o8Ufiw lbcV+jJmKOUGtv0a5Bu+eL/7k+EHjyK41isG+bUU4G0xfgNWMSXvlGFidnAn1NtY15T5 IG5CH5SJpjYGpB652NN5xMnDowlfKmXEQy5PCbbG9hhxDZganDBshs6zY+dAUz7W90mr 43Pykz8uo9gVwB3EeihoWucF15aFFR/JSUADv6q/umCl0gjzCIK1UYa1p9IiZC6R9Zp8 vpfyvJ4PrEhJaa8HCIdlVaSvElpHWxXpJ7H21z700cCVqbVTXU2jPP33v+vVSEHY8JN4 K8lw== X-Forwarded-Encrypted: i=1; AFNElJ9zuKLSwYcu3lX+2+z/JlyKvsaNgzuIDvxTnkYoLSftWBXvX3v6S9EGTifYkYB/CXiXCnektk/Y4jUsbeI=@vger.kernel.org X-Gm-Message-State: AOJu0YzANY5p1wb10A3jlD2N8BBYCDFD0m8f8o7yNBqBAukWJSVLLgVx jv4OTQCXrLFRUiwD5T6gWsuV75dYKHtbCNgyGsE5SyPZj1V21tvb2OeG X-Gm-Gg: Acq92OEczWJa0cot59vBFbmx0w9dKUti1o5VeA5WweAuk8cYEMhrujXldTj7htQXSKL cnfdsfd+j4I41lXEH7+QTr/8NrG98olESksaofaCIObC54MHnuWOBNYfkcN/xkgF41GrDoGszhu tgKjx1D6Zm3qSV2X3uqd/FqX4A2NjNKprrvily36HIPS82rz0J49s2Ypjz/CK86hPsHnjbnM6jv Je7K6roGVUJmFs4AU6xtfD6PtV43GZ8+pQswaHH1105MXDaRxDqSTn927E3d9k+itJsjian0IBD uvqH/afzT8sY0ia4nRnYOECMudNR0XDv7xepTKVCCoIfWpCA5pun9h6orAt5qcQm0f7w3t+z1mE U96Pkn19toQymsliHRSmkpu6VB1STkXXLfSOTGdBYOjE65LrvezaCnhGh0ED1VLjxJgkDF+p3fR fVqrEDn9cx5BWycH1n9m7sx3Qs7hfjP7stTLSr0XtlGgQNh2Y= X-Received: by 2002:a05:7301:1014:b0:2f9:5c29:ffb6 with SMTP id 5a478bee46e88-2f95c2a01a1mr155628eec.13.1778253994365; Fri, 08 May 2026 08:26:34 -0700 (PDT) Received: from arch.localdomain ([2409:8a28:a53:11:5d6e:9aed:ce1b:4ae9]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d43b4sm2535486eec.11.2026.05.08.08.26.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:26:34 -0700 (PDT) From: Jun Yan To: Lee Jones , Pavel Machek , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Bjorn Andersson , Konrad Dybcio , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Vincent Knecht , Grant Feng , Andre Przywara , Baruch Siach , Romain Perier , Alexandre TORGUE , Peter Rosin , Robert Marko Cc: Jun Yan , Pavel Machek , Krzysztof Kozlowski , Linus Walleij , Wei Xu , Paul Barker , linux-leds@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: [PATCH 2/5] leds: is31fl319x: Fix shutdown GPIO initial state and remove redundant startup pulse Date: Fri, 8 May 2026 23:24:19 +0800 Message-ID: <20260508152435.21389-3-jerrysteve1101@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260508152435.21389-1-jerrysteve1101@gmail.com> References: <20260508152435.21389-1-jerrysteve1101@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit 1. Per IS31FL319x datasheet [1], the hardware shutdown pin (SDB) is active-low. Fix incorrect initial GPIO level to properly release the chip from shutdown state. 2. According to datasheet [1] definition: Shutdown mode can either be used as a means of reducing power consumption or generating a flashing display (repeatedly entering and leaving shutdown mode). During shutdown mode all registers retain their data. shutdown mode does NOT perform chip reset.A dedicated software reset is already implemented in driver by writing 0 to reset chip. Remove redundant unnecessary toggling of the shutdown GPIO. [1] https://lumissil.com/assets/pdf/core/IS31FL3193_DS.pdf Fixes: dddb4e38c6ba ("leds: is31fl319x: Add shutdown pin and generate a 5ms low pulse when startup") Signed-off-by: Jun Yan --- drivers/leds/leds-is31fl319x.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/drivers/leds/leds-is31fl319x.c b/drivers/leds/leds-is31fl319x.c index e411cee06dab..c947f844c756 100644 --- a/drivers/leds/leds-is31fl319x.c +++ b/drivers/leds/leds-is31fl319x.c @@ -396,7 +396,7 @@ static int is31fl319x_parse_fw(struct device *dev, struct is31fl319x_chip *is31) int count; int ret; - is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_HIGH); + is31->shutdown_gpio = devm_gpiod_get_optional(dev, "shutdown", GPIOD_OUT_LOW); if (IS_ERR(is31->shutdown_gpio)) return dev_err_probe(dev, PTR_ERR(is31->shutdown_gpio), "Failed to get shutdown gpio\n"); @@ -506,12 +506,6 @@ static int is31fl319x_probe(struct i2c_client *client) if (err) return err; - if (is31->shutdown_gpio) { - gpiod_direction_output(is31->shutdown_gpio, 0); - mdelay(5); - gpiod_direction_output(is31->shutdown_gpio, 1); - } - is31->client = client; is31->regmap = devm_regmap_init_i2c(client, is31->cdef->is31fl319x_regmap_config); if (IS_ERR(is31->regmap)) -- 2.54.0