From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f169.google.com (mail-pl1-f169.google.com [209.85.214.169]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3C3A5406287 for ; Fri, 8 May 2026 15:34:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.169 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254465; cv=none; b=rZTber4fITIWzztyK9l4dABRj3/k0ID+q8Fwxx17hw3RANFLDF/gxMa+Y9AIDmEPIbI0+1TpnjCvNLuSvpGsyl2ApFn44OEYPavLfUEvnbcXzj4YgVrT2L/IWATvGzxCXT+k9ElWAN9NH3yp2E42AjZHybE3xwMin7db44sLkD4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778254465; c=relaxed/simple; bh=X5irLmEg3FC1ByiJtD3Pn+cYS+C0zl1YcFztWaTN51I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=RUiIqbI0A3FdS3rh4sCeQ+YIcVyBtUdz6QfYLGhk5LedAnWxBJNa5JL/QslNwy566ejEJx/wHSZ3OnF5mFcHPqnC+8VO1GZKLSmJDyyONWkthG3/GVyqEVM3WiBzQGbnR7PJVJ7xUg5mJaO4mOsg426qPUYd97GgkvMDoFSFJWM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=hTAfK9qi; arc=none smtp.client-ip=209.85.214.169 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="hTAfK9qi" Received: by mail-pl1-f169.google.com with SMTP id d9443c01a7336-2ba5c126afaso2365615ad.3 for ; Fri, 08 May 2026 08:34:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778254464; x=1778859264; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=cgRGSq5ggnVuTI7qHhDapadJXv16hq/gjrg/fvfy45w=; b=hTAfK9qi7RqC9LMk9nZm4lHpls9XBRnrZSmNzbEjnCEKbCuyTB6Vj2mO93OJJbOPKO 3GqPYhuKYcKdsxiN9zJTStd3ra/bjDFJUhGKsEjhC0gqpOEODZRPPR21jPSpj2Kqdknc yV4SM4C9jGcUo6pyM/hz3d/3i4+b7eAxuICi9XHpVkPaC6UJzEOOykQr52qNOjnVhE2v F7Hqq5KitP/6i3U5ztKnRKKSsm7DrMl02VlUJvZ3apLE7kEjD+xh4jeGZul7X8QPG0Jf SMMhn0GzYn+JWxLr9j3OEazWSdRRJ+tgiA5qSUK4boYUwwjjt4e+HQrfaQ/E2Cf00vy5 rPtg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778254464; x=1778859264; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=cgRGSq5ggnVuTI7qHhDapadJXv16hq/gjrg/fvfy45w=; b=bj4fbYlezdBdzHl+2/xOr+l1ohi/mGnS4gVrOipm/KBOe4wMxPrZsZnZ19KTwmUGET V8joLjxoaq4PleZbzrKUf6gz84EcaekRzPRGkPKeu/62kj1vU7QjuITBeB+art7ZKfOu SH/mej9tn422FNaY65WXrXsfbHOcabRuvV7l0QoD0jBJG/NLGUHkgylFTNt4sHIS68RZ ZYCraeQJGJKa0k1MuZeYH1QSsQ3HD3j34UWmiJU0NnW7lHQsxzOFe7jwT+Jezr/0rR3a u7Lemw19RhaRPt/5xO6ts+9N+35yHxneZAXsoRxkQpEVMSAr1tcrdCjmnVQ6JdAHljWR bLUw== X-Forwarded-Encrypted: i=1; AFNElJ/+ky4LXHfuRd3i6yHXKwtULYMQ9lEGu5ylj7PfGEugOqIUDVXI/D+yTYNvqfGAFfQS68Fj43hGAAjm/v4=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0Q3hG5l/SQYUT9xbiTo4MLzwq8NC0hTnV6CJhlJjc++IQwLPI d7BZytExkrpcwdPJxIfMEto1SJ7JpBRrMVNLRxmJjtDpKJGdYhq0hD5j X-Gm-Gg: Acq92OGqGf42iFybkj6bE3cFxvyBiZjK4bM7o+2u2pZMimqSDA+/bF7fXbPCJUn4qY5 DiOn6kJNHEJqpfdRU7qL3kjPTDBrmOC8YlIW+Ov4Bq07mcCELx2NDYrTeMW+nDJrq2/7Y+2BBFJ JjqT2r5Ef7ZEjFrbZ0+nIIJ0QefqtjnUUSVkCpWYxDUfyJb0mIx1yvy1pph4h4GqO5oeelErwK1 +5dKDhckC+xghWomfelvImLkp5cCjC1fodgyyuB3EB9mhI5bX7yu92LnYg4MnE6cPh74Cg46wwt bSm6DmysTLFKTIDDT8j1rfV8n5ZCkkhsmF7ffC/9cNZYEPRSzneNn2l/Sl2CII4yLRjvEXha2NM JBv0j/vzl41tZwaH43IRPAPWjb3KZgqAC+fSsaH5avF7AzRQQRSlbhHUQWOvpv5UkIHBWlDxhRL ZKvFrRwVmOX8tG1ZRRoW/1EcyimC0= X-Received: by 2002:a17:903:3c2c:b0:2ae:7edc:9234 with SMTP id d9443c01a7336-2ba7ec651f3mr66040085ad.1.1778254463628; Fri, 08 May 2026 08:34:23 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d4094fsm26666365ad.19.2026.05.08.08.34.22 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 08:34:23 -0700 (PDT) From: DaeMyung Kang To: Namjae Jeon Cc: Hyunchul Lee , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/3] ntfs: fix MFT bitmap scan 2^32 boundary check Date: Sat, 9 May 2026 00:34:09 +0900 Message-ID: <20260508153410.2624801-3-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260508153410.2624801-1-charsyam@gmail.com> References: <20260508153410.2624801-1-charsyam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit NTFS MFT record numbers are limited to the 32-bit range, and ntfs_mft_record_layout() rejects mft_no >= 2^32. The free-MFT-record bitmap scan in ntfs_mft_bitmap_find_and_alloc_free_rec_nolock() also guards against this overflow but uses a strict greater than comparison, allowing record number 2^32 itself through this earlier check. Every other 2^32 boundary check in fs/ntfs/mft.c uses '>=', so the strict greater than here is both a real off-by-one and an internal inconsistency. A model with ll == 2^32 confirms the current check accepts the value while the corrected check rejects it. Use '>=' so the boundary matches the layout-time rejection and the surrounding bitmap-scan checks. Fixes: d3ad708fecaa ("ntfs: Initial commit") Signed-off-by: DaeMyung Kang --- fs/ntfs/mft.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fs/ntfs/mft.c b/fs/ntfs/mft.c index 70c1aa76181b..f8f2e481c5dc 100644 --- a/fs/ntfs/mft.c +++ b/fs/ntfs/mft.c @@ -1279,7 +1279,7 @@ static s64 ntfs_mft_bitmap_find_and_alloc_free_rec_nolock(struct ntfs_volume *vo b = ffz((unsigned long)*byte); if (b < 8 && b >= (bit & 7)) { ll = data_pos + (bit & ~7ull) + b; - if (unlikely(ll > (1ll << 32))) { + if (unlikely(ll >= (1ll << 32))) { #if LINUX_VERSION_CODE >= KERNEL_VERSION(6, 6, 0) folio_unlock(folio); kunmap_local(buf); -- 2.34.1