From: Stepan Ionichev <sozdayvek@gmail.com>
To: m32285159@gmail.com
Cc: jic23@kernel.org, dlechner@baylibre.com, nuno.sa@analog.com,
andy@kernel.org, linux-iio@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2] iio: chemical: scd30: reject (response=NULL, size>0) in scd30_i2c_command()
Date: Fri, 8 May 2026 23:16:12 +0500 [thread overview]
Message-ID: <20260508181612.11176-1-sozdayvek@gmail.com> (raw)
In-Reply-To: <DIDF7CF01QK0.38MS3JFMU6RPL@gmail.com>
On Fri, 08 May 2026, Maxwell Doose wrote:
> I guess we're still handling the cases where both response/rsp and
> size are zero here below?
>
> Should add a comment showing that this handles this case but that's
> just my personal nit. Not worth forcing a v3 so
>
> Acked-by: Maxwell Doose <m32285159@gmail.com>
Thanks for the ack and the review!
You're right -- the (NULL, 0) write-command path is still handled
correctly by the existing rsp-NULL branch below; the new check only
rejects the genuinely buggy (NULL, size>0) combination. Happy to add
a short comment making that intent explicit if Jonathan would prefer
a v3, otherwise I'll keep it noted for a future cleanup.
Stepan
next prev parent reply other threads:[~2026-05-08 19:16 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-06 18:15 [PATCH] iio: chemical: scd30: avoid potential NULL deref in scd30_i2c_command() Stepan Ionichev
2026-05-07 15:28 ` [PATCH v2] iio: chemical: scd30: reject (response=NULL, size>0) " Stepan Ionichev
2026-05-08 7:36 ` Andy Shevchenko
2026-05-08 7:29 ` Stepan Ionichev
2026-05-08 16:02 ` Maxwell Doose
2026-05-08 18:16 ` Stepan Ionichev [this message]
2026-05-08 19:50 ` Maxwell Doose
2026-05-11 11:51 ` Jonathan Cameron
2026-05-07 16:18 ` [PATCH] iio: chemical: scd30: avoid potential NULL deref " Jonathan Cameron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260508181612.11176-1-sozdayvek@gmail.com \
--to=sozdayvek@gmail.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=m32285159@gmail.com \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox