The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Andrew Morton <akpm@linux-foundation.org>
To: Jann Horn <jannh@google.com>
Cc: Dmitry Vyukov <dvyukov@google.com>,
	Andrey Konovalov <andreyknvl@gmail.com>,
	Alexander Potapenko <glider@google.com>,
	kasan-dev@googlegroups.com, Marco Elver <elver@google.com>,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH resend] kcov: allow simultaneous KCOV_ENABLE/KCOV_REMOTE_ENABLE
Date: Fri, 8 May 2026 18:23:58 -0700	[thread overview]
Message-ID: <20260508182358.8a7775b2bfe0211c87278484@linux-foundation.org> (raw)
In-Reply-To: <20260505-kcov-simultaneous-remote-v1-1-a670ba7cefd2@google.com>

On Tue, 05 May 2026 11:00:46 +0200 Jann Horn <jannh@google.com> wrote:

> Allow the same userspace thread to simultaneously collect normal coverage
> in syscall context (KCOV_ENABLE) and remote coverage of asynchronous work
> created by the thread (KCOV_REMOTE_ENABLE).
> With this, remote KCOV coverage becomes useful for generic fuzzing and not
> just fuzzing of specific data injection interfaces.
> 
> This requires that the task_struct::kcov_* fields are separated into ones
> that are used by the task that generates coverage, and ones that are used
> by the task that requested remote coverage. To split this up:
> 
>  - Split task_struct::kcov into kcov and kcov_remote. kcov_task_exit() now
>    has to clean up both separately.
>  - Only use task_struct::kcov_mode on the task that generates coverage.
>  - Only reset task_struct::kcov_handle on the task that requested remote
>    coverage.
> 
> After this change, fields used by the task that generates coverage are:
> 
>  - kcov_mode
>  - kcov_size
>  - kcov_area
>  - kcov
>  - kcov_sequence
>  - kcov_softirq
> 
> Fields used by the task that requested remote coverage are:
> 
>  - kcov_remote
>  - kcov_handle

Thanks, I queued this for testing while we await reviewer input.

checkpatch asked:

WARNING: Using vsprintf specifier '%px' potentially exposes the kernel memory layout, if you don't really need the address please consider using '%p'.
#141: FILE: kernel/kcov.c:463:
+		kcov_debug("t = %px, kcov->t = %px\n", t, kcov->t);

and Sashiko found a femtobug:
	https://sashiko.dev/#/patchset/20260505-kcov-simultaneous-remote-v1-1-a670ba7cefd2@google.com


  reply	other threads:[~2026-05-09  1:23 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-05  9:00 [PATCH resend] kcov: allow simultaneous KCOV_ENABLE/KCOV_REMOTE_ENABLE Jann Horn
2026-05-09  1:23 ` Andrew Morton [this message]
2026-05-11 15:03   ` Jann Horn
2026-05-11 21:48     ` Andrew Morton

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260508182358.8a7775b2bfe0211c87278484@linux-foundation.org \
    --to=akpm@linux-foundation.org \
    --cc=andreyknvl@gmail.com \
    --cc=dvyukov@google.com \
    --cc=elver@google.com \
    --cc=glider@google.com \
    --cc=jannh@google.com \
    --cc=kasan-dev@googlegroups.com \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox