From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oi1-f174.google.com (mail-oi1-f174.google.com [209.85.167.174]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D98B33D515 for ; Fri, 8 May 2026 22:55:03 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.174 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778280904; cv=none; b=gcWlTX1ulMLxXcsq6+01Byjetrr2GdpcT0Nb+jCOna+SyI2PfAA4wSt+kS3UxOK0HH3uBZH81jBs74iVlMIrmAPwST3R2A40PEkIKIYLZ+f9DSBusRAjEI3nIg81XJ/hV8WOv8+GOgzIZYWt9xgq+PTV+Lo61k4tgJEKAq3GZo8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778280904; c=relaxed/simple; bh=C4DdioHlKblR2pOalMhqvj/UrE6TkBew9JMitN6z9+o=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=TslmdHr1KEvaLk4RwpPpEXNKYw9KCa/yy42H+bc9DZrlyGSnwDCV0jHAjmIdRwxzNE0J/Dzml5r0CkwkZHqNuTby4mrJS1ahI4gU0XdpBHomzl4AgUhjueTSO3pF37t1xWv6oPRmAQPQVeMA0Lt+mWe3dr6HBKHlSFJ0Ec29nqE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=gAgZFIWR; arc=none smtp.client-ip=209.85.167.174 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="gAgZFIWR" Received: by mail-oi1-f174.google.com with SMTP id 5614622812f47-4824176bbbeso282605b6e.0 for ; Fri, 08 May 2026 15:55:03 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778280902; x=1778885702; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=ysm2TozgbUsrtjJq9sRb2YZ4RYrD6/2s+NSBPl2/roA=; b=gAgZFIWRb0lPxOn4tdk/AUfpLswHVvhIPShVTWjx5ZcVJhiRpd682qxWo0zXlt9zTO 3PtaZ+0A3TjcFvMSBrQrOQEoPOOsGr1N9FWXNn+JX2SySK+yeswA5PgsRy82QIxYxGWn s9jog92vcvDEcYkIBouS8f3eYTHceCzTb+RuoJnyrVfxia8avSr0Lq86esz1KOmkqBKM OB9T1asjzwxfybRAkRr1HidKE9gfz1i4fyDv9lMp1pfbzAcfmcfcDfoSHCtVS5zxbuDM 0d5qUfBgIVeTST5cs5qiZ0qX6p2hOvteewRPMPsikxNxhtMAkBF8GEGaBk3Iy+TdtXcV dyTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778280902; x=1778885702; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=ysm2TozgbUsrtjJq9sRb2YZ4RYrD6/2s+NSBPl2/roA=; b=p65EjSNtiu0/VfFTYGx6Q9CkjWQMw8vFgma56eY0d1T67moD6d/ndUQeWZ5eTwKBDh dqbO1KZ4wsirslyVpLZLjfJPn6IdmR+xONHugnSf/dNjd1F67/1bnxRz9Gc69GwUMI4g a9dmgyBgTr9TcNwk9cP3gsWeK6pJfUHHFVzwiPRV5+YwH9cLvL6hWfaBlg3nubGsQZDH vo6xEYQImDwrs+fIDv7fa9bmm1y9YlRSBmiycpK9biUuQVDOYWMnUmPi/pY5iZkS+pdK EZX/0n/hVjh8MI7JNL+F+WNF4cB0tRISpnGRzLXycC2QVLpH0BdBlYeOxP5C2Gc7k5T/ 6pXg== X-Forwarded-Encrypted: i=1; AFNElJ/P1cmSa0jLq4izxjk73Vf96kFOIdJYFAIIMFXnrnbyLmcoXoFa70Fd63DN9buKuZidPIiJbgbarJG1n5Q=@vger.kernel.org X-Gm-Message-State: AOJu0YwSmgV0raXXzYlQNSFR4r5w9NN+421mFynCevrHVorKE12WM1ss IbVauwG71OsAnR000dmUCTjj+ZA1z14eon9RmvWp8mQy2bHXxfiifdse X-Gm-Gg: AeBDievpnzVDMokKNYPccoqYUOeG2DTd2aWmOICS41bDDhWvs4k+RtvSUeU8n6KQhec g0Fh2GeZDheSKNPPyE+3NmVgtbZyRUX8ibiHuqYvJN3+iaAm8FohjweZzjFa4vzAJVZ2B20rE/V GXcslZhSevVldoe7vBwoQL0sr6hYmFbor0/sI3Nd2ZxWuEl8dgXqvu4sgNSM4EMeuvvADzj5PbI 6qYJsTbNoT6Jkbh1YD6D8Ie91FvDbqJOcK/dq8OeHfO/gBQaIzoKyDdo8CV+7+6dqIV+Ebqw4hP 6L5HfB12MmlcfzezP8VxaCrHpRoyRChzCogrPbq3WxeY7AK4QDY8re7gqJOwkgmd/aUPZfrGSsa 08nKsHrABK2RUqjdWJel2TYPeKghBUyGYW12bFCwK1g4kobRRH6zSkSN6j73JM0UEoU9mrPBT0Q ycojhipFsVUUCJfIXzZ9C60pP9RbU9aAqBxirZkDtCPgGcpJoo1482iXxEjw== X-Received: by 2002:a05:6808:e3c1:b0:479:f526:a148 with SMTP id 5614622812f47-48042496b34mr6549527b6e.25.1778280902291; Fri, 08 May 2026 15:55:02 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 5614622812f47-47c763ffe6csm15629558b6e.6.2026.05.08.15.55.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 08 May 2026 15:55:01 -0700 (PDT) From: Maxwell Doose To: jic23@kernel.org Cc: Tomasz Duszynski , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] iio: chemical: scd30: Cleanup initializations in scd30_float_to_fp() Date: Fri, 8 May 2026 17:55:00 -0500 Message-ID: <20260508225501.86448-1-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The current variable declaration and initializations are barely readable and use comma separations across multiple lines. Refactor the initializations so that mantissa and exp have separate declarations and sign gets initialized later. Signed-off-by: Maxwell Doose --- ps: Hi Jonathan, I noticed a potential divide-by-zero bug on line 241 in scd30_read_raw(), where the value of tmp is dictated by hardware. If the scd30_command_read() call on line 236 assigns 0 to tmp, then when we run: *val2 = 1000000000 / tmp; we'll get a divide-by-zero. Will send a patch for this later. best regards, max drivers/iio/chemical/scd30_core.c | 13 +++++++++---- 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c index a665fcb78806..be8c055be184 100644 --- a/drivers/iio/chemical/scd30_core.c +++ b/drivers/iio/chemical/scd30_core.c @@ -89,10 +89,15 @@ static int scd30_reset(struct scd30_state *state) /* simplified float to fixed point conversion with a scaling factor of 0.01 */ static int scd30_float_to_fp(int float32) { - int fraction, shift, - mantissa = float32 & GENMASK(22, 0), - sign = (float32 & BIT(31)) ? -1 : 1, - exp = (float32 & ~BIT(31)) >> 23; + int fraction, shift, sign; + int mantissa = float32 & GENMASK(22, 0); + int exp = (float32 & ~BIT(31)) >> 23; + + /* Determine sign of received float based on IEEE 754 standard */ + if (float32 & BIT(31)) + sign = -1; + else + sign = 1; /* special case 0 */ if (!exp && !mantissa) -- 2.54.0