The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Dominik Grzegorzek <dominik.grzegorzek@oracle.com>,
	Ben Hutchings <benh@debian.org>
Cc: "torvalds@linux-foundation.org" <torvalds@linux-foundation.org>,
	"lwn@lwn.net" <lwn@lwn.net>,
	"stable@vger.kernel.org" <stable@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"akpm@linux-foundation.org" <akpm@linux-foundation.org>,
	"jslaby@suse.cz" <jslaby@suse.cz>
Subject: Re: Linux 5.15.205
Date: Fri, 8 May 2026 14:41:47 +0200	[thread overview]
Message-ID: <2026050829-gladiator-displease-57af@gregkh> (raw)
In-Reply-To: <1b941a1353791ddd6fd75fb8e68b377367d689ff.camel@oracle.com>

On Fri, May 08, 2026 at 12:05:02PM +0000, Dominik Grzegorzek wrote:
> Hi,
> 
> I may be mistaken, but I think there might be a small typo in this hunk in net/ipv4/ip_output.c:
> 
> skb_shinfo(skb)->tx_flags |= SKBFL_SHARED_FRAG;
> 
> Would this need to be:
> 
> skb_shinfo(skb)->flags |= SKBFL_SHARED_FRAG;
> 
> My understanding is that SKBFL_SHARED_FRAG is a bit in skb_shared_info->flags, and skb_has_shared_frag() checks skb_shinfo(skb)->flags.

Adding Ben who did the 5.10 backport so he can comment on this.

thanks,

greg k-h

  reply	other threads:[~2026-05-08 12:41 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-08 10:50 Linux 5.15.205 Greg Kroah-Hartman
2026-05-08 10:50 ` Greg Kroah-Hartman
2026-05-08 12:05   ` Dominik Grzegorzek
2026-05-08 12:41     ` gregkh [this message]
2026-05-08 13:13       ` Massimiliano Pellizzer
2026-05-08 13:50         ` gregkh
2026-05-08 14:07           ` Massimiliano Pellizzer
2026-05-08 14:21             ` gregkh
2026-05-08 14:30             ` gregkh
2026-05-08 14:38               ` Ben Hutchings
2026-05-08 14:50                 ` gregkh
2026-05-08 19:06                   ` Ron Economos
2026-05-08 19:33                     ` Ben Hutchings
2026-05-08 19:44                       ` Woody Suwalski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2026050829-gladiator-displease-57af@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=akpm@linux-foundation.org \
    --cc=benh@debian.org \
    --cc=dominik.grzegorzek@oracle.com \
    --cc=jslaby@suse.cz \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lwn@lwn.net \
    --cc=stable@vger.kernel.org \
    --cc=torvalds@linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox