From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CC04B2BDC0F; Sat, 9 May 2026 02:08:45 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778292525; cv=none; b=gIU6oYXipZhZRd50tfdlcyxwmHNPYV0a4v3FVdLNTIdKJNn5BGmTgMOOxypxYuzukUFtB01z8YFHm+/b48l/RzXMUMYEfv15U3DjOk1r1B2yNORcPzRucvxuwAZcWRCKkirD8v2eSCjJdZ/utxmRQTzMgUJC8eYIkOgKbm4l6qs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778292525; c=relaxed/simple; bh=KgkbFJ3/6OaGWC01MXEGMQogKNXOnRDZa18BoowgJfI=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=USvc6tRWMIVU7M7L7MWQ8mcYNB/LMAy4O8XIEvPsN6zSBlCpy8FM2f2huLJNjVdyhV9LGYnfTJ8Y6FVUIBSclV7OKGAhZH2fkfGg7SJ40Jiy+44wLwOToHAxnYw6EXOuXeFslNQmIxy6aF1fHoKvNNvCq6fpj6XNcWNRxdXgrdM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YOrmW/Cn; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YOrmW/Cn" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 6216BC2BCB4; Sat, 9 May 2026 02:08:44 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778292525; bh=KgkbFJ3/6OaGWC01MXEGMQogKNXOnRDZa18BoowgJfI=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=YOrmW/CnyYudLMeJxjLw8okgsYiKYNsdyHkdQBj4QCET1pO/I1qhWQGCw3rKWqAQk tLhkYIgSOwOob1ClimwucoeDt6Le40foH/7EFZHzrSvhaWSa4OaU0VXeSMA6gqlW1E yjay8R1UO9wF6AUt/x9ZGGLI9piJQ4yd3evc7/odsufg9FppMOKHR+IkqNVxyMN64N NLydQmWXB3e6dSgn8hpupTPkRDaovflIUTekSqobYkMZS9N13Q3ykL4L1k6mgx6CwN wm/ugeEDA4PFohqqLlUrr3SO9C2eIWV9FAQooiVheyDE5VFGwIfGdq/HkmULdV7z4h y+0sQhOuwS9lw== From: Sasha Levin To: stable@vger.kernel.org, jassisinghbrar@gmail.com Cc: Sasha Levin , sudeep.holla@arm.com, thierry.reding@gmail.com, jonathanh@nvidia.com, linux-kernel@vger.kernel.org, linux-acpi@vger.kernel.org, linux-tegra@vger.kernel.org, joonwonkang@google.com, Douglas Anderson Subject: Re: [PATCH 6.18.y] mailbox: Fix NULL message support in mbox_send_message() Date: Fri, 8 May 2026 22:08:38 -0400 Message-ID: <20260509015927.agent5-0002@kernel.org> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260507062107.2927600-1-joonwonkang@google.com> References: <20260507062107.2927600-1-joonwonkang@google.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit On Thu, May 07, 2026 at 06:21:07AM +0000, Joonwon Kang wrote: > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c > index ff292b9e0be9..7a2baeca2ba4 100644 > --- a/drivers/mailbox/pcc.c > +++ b/drivers/mailbox/pcc.c > @@ -361,7 +361,7 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p) > if (pchan->chan.rx_alloc) > handle = write_response(pchan); > > - if (chan->active_req) { > + if (chan->active_req != MBOX_NO_MSG) { > pcc_header = chan->active_req; > if (pcc_header->flags & PCC_CMD_COMPLETION_NOTIFY) > mbox_chan_txdone(chan, 0); This pcc.c hunk does not apply on 6.18.y: commit 5378bdf6a611 ("mailbox/pcc: support mailbox management of the shared buffer") was reverted upstream by f82c3e62b6b8, and that revert is already queued in 6.18 as 2cafad617431. write_response() and the active_req-driven txdone path no longer exist in pcc_mbox_irq() on 6.18, so this hunk is both syntactically inapplicable and semantically unnecessary. Could you send a v2 omitting the pcc.c hunk? The other three hunks (mailbox.c, tegra-hsp.c, mailbox_controller.h) apply cleanly and I'm happy to queue those for 6.18.y. -- Thanks, Sasha