From: Hungyu Lin <dennylin0707@gmail.com>
To: jic23@kernel.org
Cc: lars@metafoo.de, Michael.Hennerich@analog.com,
dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org,
gregkh@linuxfoundation.org, linux-iio@vger.kernel.org,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org,
Hungyu Lin <dennylin0707@gmail.com>
Subject: [PATCH] iio: adc: ad7816: propagate SPI error codes
Date: Sat, 9 May 2026 02:06:46 +0000 [thread overview]
Message-ID: <20260509020646.82778-1-dennylin0707@gmail.com> (raw)
The driver currently returns -EIO for SPI read/write failures,
which hides the actual error code returned by the SPI subsystem.
Return the original error code instead to allow better diagnostics
and error handling by callers.
Signed-off-by: Hungyu Lin <dennylin0707@gmail.com>
---
drivers/staging/iio/adc/ad7816.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/iio/adc/ad7816.c b/drivers/staging/iio/adc/ad7816.c
index 0e32a2295990..9052203eb4f3 100644
--- a/drivers/staging/iio/adc/ad7816.c
+++ b/drivers/staging/iio/adc/ad7816.c
@@ -222,7 +222,7 @@ static ssize_t ad7816_show_value(struct device *dev,
ret = ad7816_spi_read(chip, &data);
if (ret)
- return -EIO;
+ return ret;
data >>= AD7816_VALUE_OFFSET;
@@ -320,7 +320,7 @@ static inline ssize_t ad7816_set_oti(struct device *dev,
ret = ad7816_spi_write(chip, data);
if (ret)
- return -EIO;
+ return ret;
chip->oti_data[chip->channel_id] = data;
--
2.34.1
next reply other threads:[~2026-05-09 2:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 2:06 Hungyu Lin [this message]
2026-05-09 6:57 ` [PATCH] iio: adc: ad7816: propagate SPI error codes Andy Shevchenko
2026-05-09 7:24 ` Denny Lin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260509020646.82778-1-dennylin0707@gmail.com \
--to=dennylin0707@gmail.com \
--cc=Michael.Hennerich@analog.com \
--cc=andy@kernel.org \
--cc=dlechner@baylibre.com \
--cc=gregkh@linuxfoundation.org \
--cc=jic23@kernel.org \
--cc=lars@metafoo.de \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=nuno.sa@analog.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox