From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f173.google.com (mail-pg1-f173.google.com [209.85.215.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4DEFF231A23 for ; Sat, 9 May 2026 04:12:00 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778299921; cv=none; b=cwCVkRB209+rb38aa2D8zTy0Dh89vNMDoEhyymg+OvvsczWb+DVKRYTYFc49zAY+SW3v8sNninKSQJ5MIsmHG3EvinyRJiy4ocbVwZM/yJbahonQjPJdSPDGVRPvg/fB/P/jqhViJZvriMev/GYPolLp3/rIkFtWSULarfSOog8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778299921; c=relaxed/simple; bh=FY0ctX8o/n7sD3I+Sj/Cwo0crSwit7TvwBjsz5wul0I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZUlM8HSasIrOV1JUhLEIceVGt0eRi/oIShTktqd4jvWJJDJ14V+LmexQY7GghRS+H/TiexSNyVSE4tNZc+d0VeiGLdDh5n4tl1TId7TWjejhL5ClSOAcvB6p/8PPWIKbEc5J1gLvfmud5RGdebM7DZ9YIKNBa4JRBmYPQPocnFw= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZHauc2SR; arc=none smtp.client-ip=209.85.215.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZHauc2SR" Received: by mail-pg1-f173.google.com with SMTP id 41be03b00d2f7-c8016d642b2so1705283a12.0 for ; Fri, 08 May 2026 21:12:00 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778299919; x=1778904719; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Sp+Q7ee1eENxPzf7LGRQoNX+LKiJXsCWlT3X04kYP94=; b=ZHauc2SRdLAAYWyA80OqnZcrVTo+tx/3yR3gTKWHI8Gxf4Ooy8f3MttBEB0y6++0+l tLC0Z9PdMfyek2q8Jcyn51rhuAT/gDdbjFPUUYjQCREpkpoA43w30qjtDcZKtgPkQe/w uTu0q3tfoUsZ3bZNrReKCC6Ep7gHpHoBPGbVFLtdD0sIAy1M6Sw07nC3S+nESCTnmpUu lINGPRkuXLGk4GZncO7OAU17QoKgRChT6SwkLmR18FHCchwimIaD1TuZhbuKf62ncIHW sME0GlU4AKmXSXg2d1MMAW8NhV6EixqkASX5dZATsAjvRxmttcz2piEF8PalbwGHeEf+ WKxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778299919; x=1778904719; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Sp+Q7ee1eENxPzf7LGRQoNX+LKiJXsCWlT3X04kYP94=; b=bpqkUSmREjAKvAUL/nNjpDnsvZn9fSwLv/lxv/Nvx0NMlExBsU70ogHL+HIfb/o3eu Zrew0NKQ4qjWOXH+PKsMmpB/wLZ4/2Bujc98lo0hSwhckzw3EM8wBJAGPDNoI0U6x4qM 4IminYI0RouMpRv+kobtJbmQYoaj4m4IwEZvbjnZJ2Zi273IrDfBVhvNLZZAgT6vsi7i nR0F6Q/JHAnWKLlM53MGUU4qSoVhiR3wnll2HvDlNIawPCOcXauWpeYaINGtrjOs9Sot dKAMOuO6aoewY1E/cF0w9EynEUPLXTlTQdieryyLIKJoExutzLpJz9PBrO+qI6/MoUZ/ cF9w== X-Forwarded-Encrypted: i=1; AFNElJ+eZddkzyzvuvfcwXLarSWrw2TmYmPLzvd9ScfYVIm774EErEDPFo6JQVmshUWrGddymZN3cZCx535zF6M=@vger.kernel.org X-Gm-Message-State: AOJu0Yzp1c1nVRLaPhtjoIZmFdc6Nox5TKlGsY0MRbVl9kvhfjUMdl4E ieStjQrFg3zrP91YjxvOvaaxeLWF0l0IR4sspksW3/qXji6b18YEkGLd X-Gm-Gg: Acq92OF1Ypo8TF5nFBX123vh21iI6JQi3Fpt89xoEoc7pm2S8QHCQiKnW6GEeUb1Tw4 Jr+aqkCPajH2zLNzzfZF9SxY+orujmQzGuwZr4GobEeXZcTTZpJfxCfpEyTSjoupC/dnuCE5DH/ Y9pF+8UB4hWk1x67owZ/yImE1LG6lOc8e3n9USJPulKjQBYiXTiyof7gEKmhHQpYNjUNzMb91Qx 8uZNn/XN+1w2Hk8nXKdPo8TyIQUm+CaQzNQ4PCHWPx+bbMrBzliO7CkZfwUXf1ixPRyxiJ8G2MA tywO9ea1QPXg/qCo88fbX3VmhvE5pNL8H/qw8EICHc8C+ajuo7czFLoQvPnllb4+kXEmLqDZGs0 7cBAylrt48mSBChBUxBHjaTla4VnpCU84Cyr5EiAZKHIdI8xWyPVJU/3ciwm9wUbEWG4oSsqLxf 2abhXQ5W7T9XWoYoFl2/Btd6wfj9y1PenMfUY313uVmzBXrfPu2KAF0JVsq9Vy52oL X-Received: by 2002:a17:903:22ca:b0:2b0:ac1e:9730 with SMTP id d9443c01a7336-2babd4a527fmr87600795ad.14.1778299919456; Fri, 08 May 2026 21:11:59 -0700 (PDT) Received: from localhost.localdomain ([2409:40c1:2143:d26d:e122:a514:932b:de1]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e36c65sm38318875ad.40.2026.05.08.21.11.55 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Fri, 08 May 2026 21:11:58 -0700 (PDT) From: Jill Ravaliya To: akpm@linux-foundation.org Cc: Jill Ravaliya , urezki@gmail.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 1/2] mm/vmalloc: free unused pages when shrinking vrealloc() allocation Date: Sat, 9 May 2026 09:41:43 +0530 Message-ID: <20260509041149.33932-1-jillravaliya@gmail.com> X-Mailer: git-send-email 2.51.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Thank you for the pointer to the AI review and for taking the time to respond. The review identified several real issues I missed: - vunmap_range() called with equal start/end when PAGE_ALIGN(size) == alloced_size (confirmed by syzbot) - No handling for huge page allocations - Missing vm_reset_perms() for VM_FLUSH_RESET_PERMS areas - Lockless modification of vm->nr_pages races with /proc/vmallocinfo readers - vm->size left unmodified after shrink Uladzislau pointed me to Shivam Kalra's v12 series which correctly addresses all of these cases. I am withdrawing my patches in favor of his work and studying his series to understand the full complexity of a correct fix. Jill Ravaliya