From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-173.mta1.migadu.com (out-173.mta1.migadu.com [95.215.58.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BC1CE347DD for ; Sat, 9 May 2026 05:38:17 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=95.215.58.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778305100; cv=none; b=Jhy8B5ZBRTWG6w8SWXWFts3VkzrzE+xmYSryr2WMo+oaPzHRLLFsv8NvqksNgphf/LcKvgPesTQobN2YRzum3DvY5n9f9/BU6ri2gU4SVA2oYx+mtE/fW/5DiHsPqDMSQUTSW/Aaz2FdfKD6+X9cHmqAKxgJjlSkExg+bTi208s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778305100; c=relaxed/simple; bh=/asD8RB2EBNSHT6GIrJVz//ex1k3sr14uIl0RyEUjXg=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=ijQ0cBpUwSbJ5/fbipGzF3eLj7e7iZdHNhtg9Pcq8S9IXJEmEcYlY8zQIkycg3OzE+4h5LzKjYyi+N+iKN3tJiUock+S4B4BAcvEMDY7iae8vY6AXAHyD34MUt2+fNF+K7BIjYmsgr2XG290yPOa1cLdAXtcInbeeVbx1NZ+PS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=XAW7qdfO; arc=none smtp.client-ip=95.215.58.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="XAW7qdfO" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778305095; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5V5bu8wkVupwenl9kEt3EBNU8qJQmy9AXZs1gAf63t4=; b=XAW7qdfOIy5LLS+BTo7puF2YCVhJIuaCojxqMd05ujk61bqCA0XWrYdz0O3eelGXYByVWr wUZVI417lKey6DWb8pW4IgevbJivmj/tvgpoF+Iv2zVwgb4xi0TP7GiytKE0YCzhW+UBpN ml8YbgAmM+ybJPAwCOFEHhh3om2uj8U= From: Fushuai Wang To: shijiaqi_develop@163.com Cc: airlied@gmail.com, daniel@ffwll.ch, dri-devel@lists.freedesktop.org, heiko@sntech.de, hjc@rock-chips.com, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-rockchip@lists.infradead.org, p.zabel@pengutronix.de, Fushuai Wang Subject: Re: [PATCH 3/6 v2] drm/rockchip: Fix vop2_create_crtcs() error path cleanup in vop2_bind() Date: Sat, 9 May 2026 13:37:37 +0800 Message-Id: <20260509053737.54007-1-fushuai.wang@linux.dev> In-Reply-To: <177830024278.246051.2541513211000360573@openclaw.local> References: <177830024278.246051.2541513211000360573@openclaw.local> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT > diff --git a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > index 8afabe2118a9..1234567890ab 100644 > --- a/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > +++ b/drivers/gpu/drm/rockchip/rockchip_drm_vop2.c > @@ -2735,7 +2735,7 @@ static int vop2_bind(struct device *dev, struct device *master, void *data) > > ret = vop2_create_crtcs(vop2); > if (ret) > - return ret; > + goto err_crtcs; > > ret = vop2_find_rgb_encoder(vop2); > if (ret >= 0) { > -- Hi, Jiaqi. Reviewed-by: Fushuai Wang -- Regards, WANG