From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f196.google.com (mail-dy1-f196.google.com [74.125.82.196]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 31FEB384231 for ; Sat, 9 May 2026 08:27:02 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.196 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778315224; cv=none; b=DMGJC45b1ub+r6Hw61dRp8Uxzr402Jt8G+Otnap97SjmHHnLMJc1ZWA19HQIcXKU1b23B8aTNPkRcYDUNZgPc/t6rIvaPODx5Mhe9oB/uqfyTKcpUZ+Os3SE1t7PV58EqXyo1xqmxYvzPRwGDFptnNN3e/gv+SmI3pMRp9A4LLE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778315224; c=relaxed/simple; bh=5D0Jeg8L2jdESb77aS2oqSGnOTtEt/jAvaVQVWtUUcU=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=kOGSZ9J6OU5XuXpQfJSYShUS9bVvtQSGu5jfKt52ggZIkywLVU6I0FudrkoR89wVrWtEgZCNmdrVmQO6ZpZiSrpA/8sPwaW1eAYkYLhVVOy67ZHZZxtGUp4kXwoghxbeCUFNhlkAhCumLNYCTpt69wWY/0R0dVWNTQdzOFsWUjY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mh1PjizL; arc=none smtp.client-ip=74.125.82.196 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mh1PjizL" Received: by mail-dy1-f196.google.com with SMTP id 5a478bee46e88-2b4520f6b32so5040103eec.0 for ; Sat, 09 May 2026 01:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778315221; x=1778920021; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=Hi8OA0S5v0cDkuBo5x3SA05u+r2nlwG9R/S0G51f9EQ=; b=mh1PjizLlHeIb7jQTW9dGTi4pcmdEon7aGWfutoauaqLS9PHRTrfQ9wu65IwT/WNjL 4y5i5V37SY0OFptuNsDzGLy4wBtCYQ35OYByJqj+AsBxeqmqCphq6C1V/ytpEtbZAVVv KkhxBi/+VHvwIbUrhR/56VHNn13b/wm7bPdkgFQYhEJWxR144X5etpsn7W0zeGOAc0MU 1qDBJ4yufmJEVUyrMCexF9rwU+5rJ5NAMWt9Y4/ve0NTNkWENsD7lByvdQSuIIenGDqN Ki749QvRSoJk1q0eQk1JsQkgYVvRuWLpmR7XgxbAYm7L2wDWHzLoslG1Rhvq9HCWBkER BWdg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778315221; x=1778920021; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=Hi8OA0S5v0cDkuBo5x3SA05u+r2nlwG9R/S0G51f9EQ=; b=IsiimZp9/qdbxVYzjpEmkqOPVxAkI+JzmWBkpmKLpM/WIVJhFNKOkjIp2P/WnPRGr/ Su2jtLoF5CtQV5TNXrnxmwQlCxmrCV2R7+HP1rpxr/zXOGKHmYq6e0ZpcXTFPjScjHoQ p5ZNl+OiOWSn5L8s+sIXKZQtPzw+2qP0hSainvjKRKRcl7db6UhMSKfePIgHuRoPqym1 1bMiUW5mHEaXKrqgyHP3bM6x436Z8RpgpgmSaF8VE7vDm39fqdiNATYhRAS9riFVfvMH B3rLcdk6aYSdf+z4hZ6l7wg0KusCR+tsAgq+dqaJj1naYLl3zu8Iejy1XF/CoFPfvpxy B51w== X-Forwarded-Encrypted: i=1; AFNElJ9kOFJ4ExEgBJmA06GViOYmD/VifpJeZZpmg83QanPoOYIRHESl0FFLY0n4BlKSOKuZbIMRp9r8+asF9pk=@vger.kernel.org X-Gm-Message-State: AOJu0Yyj0voqKS4JUwK7ESd0OBaOGCHINt9nTZPehO5q3DoWBIshotaJ HyhR4DnTUVy90lVsmBwBw4G7IQ3Hdgj3bWX1vN9LdLMAiMPxaprJit0kSgPebhiE X-Gm-Gg: Acq92OE0Ugupedb7wRF3UBSltpm5E8r5x3J3KQ1wdbtmZS8XuJClcW3G4D/Qn6SCoRS lEXVXeP7a3qWEhvekPJBsl9QZS9wJODzIO7tzcu+Wdp144Bs9F1zMf3KFnKYi9B8kpQ3/IGJiZv Jbq+v0wqq/pWEWI0eoQmMTLJR1ipiwPsj64PfAQEncykdQJCjTnTmCJzAaJLNFS3UsdRqFm9F+E ICY7xEAS/zZabS3x8kXxFhKp+FyI2QpUB36oepdmX3QKEVPzGlqiCr710h3XjZLApa5qhEfn5IC ERm4DfFRDEiNPjKaUJD6SBmpapuwwBbrvcfedYk4zvwVPDmA9PE0NckhmxOzsfmcDoSKA2DPKEm Y36Xa33gTw/ilOAAMSHyTcTE4kQdWKW92+/acinEQLTyGrh9JzS6pmTYKxrq64VB6CB+JIMtGpM R47Au5NzC5pxziU1qv2vpyRnUX5nANVe9kwFarP0Wb99muxrPdYD9G2f+dB/9ShEz1Pg== X-Received: by 2002:a05:7300:ec01:b0:2e1:e3e6:2909 with SMTP id 5a478bee46e88-2f54dc8dfdcmr7178290eec.9.1778315221164; Sat, 09 May 2026 01:27:01 -0700 (PDT) Received: from localhost.localdomain ([76.32.119.210]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f88847502fsm6522685eec.14.2026.05.09.01.27.00 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 01:27:00 -0700 (PDT) From: Hungyu Lin To: linux-iio@vger.kernel.org, Jonathan Cameron Cc: Lars-Peter Clausen , Michael Hennerich , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , Greg Kroah-Hartman , linux-kernel@vger.kernel.org, linux-staging@lists.linux.dev, Hungyu Lin Subject: [PATCH] staging: iio: addac: adt7316: check SPI write errors in probe Date: Sat, 9 May 2026 08:26:36 +0000 Message-Id: <20260509082636.85114-1-dennylin0707@gmail.com> X-Mailer: git-send-email 2.34.1 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The probe function issues three SPI writes to switch the device from the default I2C protocol to SPI protocol, but ignores their return values. Add error checking and emit a warning if any of these writes fail, to improve error visibility without changing existing behavior. Signed-off-by: Hungyu Lin --- drivers/staging/iio/addac/adt7316-spi.c | 9 ++++++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/staging/iio/addac/adt7316-spi.c b/drivers/staging/iio/addac/adt7316-spi.c index f91325d11394..25b7772bd05f 100644 --- a/drivers/staging/iio/addac/adt7316-spi.c +++ b/drivers/staging/iio/addac/adt7316-spi.c @@ -98,6 +98,7 @@ static int adt7316_spi_probe(struct spi_device *spi_dev) .multi_read = adt7316_spi_multi_read, .multi_write = adt7316_spi_multi_write, }; + int i, ret; /* don't exceed max specified SPI CLK frequency */ if (spi_dev->max_speed_hz > ADT7316_SPI_MAX_FREQ_HZ) { @@ -107,9 +108,11 @@ static int adt7316_spi_probe(struct spi_device *spi_dev) } /* switch from default I2C protocol to SPI protocol */ - adt7316_spi_write(spi_dev, 0, 0); - adt7316_spi_write(spi_dev, 0, 0); - adt7316_spi_write(spi_dev, 0, 0); + for (i = 0; i < 3; i++) { + ret = adt7316_spi_write(spi_dev, 0, 0); + if (ret) + dev_warn(&spi_dev->dev, "SPI init write %d failed: %d\n", i, ret); + } return adt7316_probe(&spi_dev->dev, &bus, spi_dev->modalias); } -- 2.34.1