From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f43.google.com (mail-wm1-f43.google.com [209.85.128.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 58472383C80 for ; Sat, 9 May 2026 09:55:24 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778320525; cv=none; b=oNpqIvVZkMhMo9okQ7DviurvaHRiXyqWTxTR0WDBrT8ggsWxoPF9DK2chFNxZ+9JK1zEzwXxxvLkrf5kJevQ/UTKVXQb1yrAlDqYyKxNHt21LXDy2Z23bI6wqEzmJSCBPu6R997JQjgxtHI7ZMD5ToUSr5cFAB3KFugI488/zNs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778320525; c=relaxed/simple; bh=OsNMWoJsfFGNNzbdTZaiLLvQoneyS4qquVTcja2ipCE=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=Qlo0LIw2xwlmx4Gp/Symn79QP5hDrXmJ/nKNAFJL9tStrFNgkW4dwPSLqNOd2wRruF4KStvdPg0AN7H8C1t4byfaHxlDgFO/gIqWLYd4jVWkIvpyjxR5IWw/fmEOOFsF8SqItejPgw9FKN1ru8tPHydEEXqDORwefokfvNX69yI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=bfqed6i4; arc=none smtp.client-ip=209.85.128.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="bfqed6i4" Received: by mail-wm1-f43.google.com with SMTP id 5b1f17b1804b1-488a9033b2cso26084465e9.2 for ; Sat, 09 May 2026 02:55:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778320523; x=1778925323; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:from:to:cc:subject:date :message-id:reply-to; bh=7DPOjtBC4y6QCDvgAajyqEeMTzsqYkeTN2dHg6bS6Wc=; b=bfqed6i4vIYa0uQq9QkXPZG/X1hv61gxkAIPTxueTV/eAzFU+CAu9yLFHTxGm37owX sNr6eVvc+UD0JnXIT8u9z5N5LWr1jW1GRJLABYeqJLUFmkXopadl4ThZaHPm3OpvCGmk 09Vnzetub3DgDllcLrVDDAf7wPJJkz0HfQdzH/QnyAUUoLpFScYtvCQd4TJ/ICyMxc0h tniL8wP/UbyUwKgaoxu42LB18aIW4+pMz1LC05x8QAhLUCzhtaXalHi3EVZQspTqqgcE aNpOZk1DEqqDWonwmUN1y3Op54rm8DBSag2RzsadjJYvMr46eQJT6BvO4QlmarVK+rVD r0TQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778320523; x=1778925323; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=7DPOjtBC4y6QCDvgAajyqEeMTzsqYkeTN2dHg6bS6Wc=; b=EbhqVAIdMJxnFcc21d24dSAlx6Endmzfpl5+4+sXF0CO6Qk2pxlVixQoifNTRWsXRw EYwP1h/5LowjmEl9X/neZg1zOA08vhk4PeSSV+ZaVfWE+hiDz8BWIjT/4/u0aP8x8uc4 yCVKISjokqPyEFrqxVdbLNQWLM5brOIkE3+fHUqq99i4tMUFUZpoYN0jjwWzSj2lwz3M Ogthr3Sm9AimIk+nM65dpG1Qs8sMo6JHTjrWFMnAGt3DsmoNOZ6GaPzW6s9BQb0Z2rDY hLzxfi1eSPswJY+kc6kskERQ5lpR9fYntutMzN/LcndFCB9PCRXm+L7p+pUjdAZG/6rX JyqQ== X-Forwarded-Encrypted: i=1; AFNElJ9HhBRxwE8M/oAmzx+3G12k7Ve1mePR4WAJ+0oyvvilVoX87lcyRkGFpGsFZCE18Nutkp8sODigYMtLtIA=@vger.kernel.org X-Gm-Message-State: AOJu0Ywr/hwjWvE/kiw/Tf1tH9yEzOx6DRIqwHb2fCGYFI2ecUkn8/f5 ++YYrUOs9iipkH0xPCtr3yEfUVnPFYNigcNe8fcCLu3IBs0dNuxpZ/jQ X-Gm-Gg: Acq92OFHgD4Hbg4ReMaiVh/1TKoFragdKOyOmTCx5+d8MUmZsMx0ooMRcnRVfIo6Wb+ J1htAkQqJE0bebZRI7SoADm0ugPrLHNd9EdrZH8wZrLtQQeWd3wjzF9vPyD8Zm819X1j1tO0LxQ 3tS38vA1JR5lv+df3Xwa+G7cz//12Z1CVqZfes2xOMigGHqQhEvN+NBwzLUXeCIEO7mKWQb+Xwp DL4Bak3I4hsHJE6n1hYfAblV5ko25IyFEPmWd12Khb8t+WMvzBqa102K/nHY+I2eVl/FXBYUkij KDYlT2Da3uy9RRHhX3TcpFOjWq9GSEuS4v+XOdhUcLHsDcxdxrQjcXL55H6z3PC9MRDRHNy4mfN 10VnQDHfKKK2aLsxAIfZUfVt0EkND/r0gyCpb3yRGYMPJXDNU38G+D9g5mqwoWr6ochhWvOy1Gd f6zIVtQiDcnQ3S5Y9BMJCvL6/BGpLEE6qtoZ+fVeLoQOPYyAWMkKdIljpIuii2Hs7GZMUAud0Pe gc= X-Received: by 2002:a05:600c:4fc4:b0:48a:58ae:9938 with SMTP id 5b1f17b1804b1-48e706bd7bdmr27948155e9.19.1778320522459; Sat, 09 May 2026 02:55:22 -0700 (PDT) Received: from pumpkin (82-69-66-36.dsl.in-addr.zen.co.uk. [82.69.66.36]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e702ec599sm35687645e9.11.2026.05.09.02.55.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 02:55:22 -0700 (PDT) Date: Sat, 9 May 2026 10:55:20 +0100 From: David Laight To: Akash Sukhavasi Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Input: analog: replace deprecated simple_strtoul() with kstrtouint() Message-ID: <20260509105520.61f823a5@pumpkin> In-Reply-To: <20260509024048.46132-1-akash.sukhavasi@gmail.com> References: <20260509024048.46132-1-akash.sukhavasi@gmail.com> X-Mailer: Claws Mail 4.1.1 (GTK 3.24.38; arm-unknown-linux-gnueabihf) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit On Fri, 8 May 2026 21:40:48 -0500 Akash Sukhavasi wrote: > The simple_strtoul() function is deprecated because it ignores > trailing garbage characters, which can mask typos in input. > > Replace it with kstrtouint() in analog_parse_options() to enforce > strict input parsing. > > Note that this introduces a minor, intended behavior change: while > the old code would silently parse a malformed string like "12abc" > as 12, the new code will reject it entirely and fall back to the > unconfigured state (0xff). This strict parsing is the preferred > modern behavior for kernel parameters. However that might break existing systems. So I'm not at all sure it should be done. David > > Signed-off-by: Akash Sukhavasi > --- > drivers/input/joystick/analog.c | 8 +++++--- > 1 file changed, 5 insertions(+), 3 deletions(-) > > diff --git a/drivers/input/joystick/analog.c b/drivers/input/joystick/analog.c > index b6f7bce1c..07ad360f8 100644 > --- a/drivers/input/joystick/analog.c > +++ b/drivers/input/joystick/analog.c > @@ -653,7 +653,7 @@ static struct analog_types analog_types[] = { > static void analog_parse_options(void) > { > int i, j; > - char *end; > + unsigned int parsed_val; > > for (i = 0; i < js_nargs; i++) { > > @@ -664,8 +664,10 @@ static void analog_parse_options(void) > } > if (analog_types[j].name) continue; > > - analog_options[i] = simple_strtoul(js[i], &end, 0); > - if (end != js[i]) continue; > + if (kstrtouint(js[i], 0, &parsed_val) == 0) { > + analog_options[i] = parsed_val; > + continue; > + } > > analog_options[i] = 0xff; > if (!strlen(js[i])) continue;