From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7BA5F39891E for ; Sat, 9 May 2026 18:22:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778350927; cv=none; b=d+0kH2/Op24DJ6Frhz2KBE1Er2fw15AD1LR/eN1c5r4+O6OYFatmWBBb1vlDeEAhJ5mr6DTVVqJ80ImFAKXBGZVpswnqAbTI4ZvItpezJBYY6W9uA0hCzUqCSyOMUAblECMiXdUdGSu3YAdcFDwMp9/9Yymwg12CVLotwFdKhwo= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778350927; c=relaxed/simple; bh=hcd1IK3pGlHUmDWH+Rqd5doqTRuaX0rbsTijnuNPBOw=; h=From:To:Cc:Subject:Date:Message-Id:MIME-Version; b=MvGasEXdSqm37bYhiqvv7UttVdCTkz1BMYYPmWywuhs3/IQaoQztva3nhWLqNV6jzZkQiOFB98/u1nHx/DWDqpBGoyXcEngFm7IOTVdryPYgzINOv36X8XgeOFF5rhL/Gm897dR1cxo3WHWiJAu+2SmxnPyHV52f0SzbboDy59k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=AJPeNJ63; arc=none smtp.client-ip=209.85.128.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="AJPeNJ63" Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-48e72b02bf6so682035e9.3 for ; Sat, 09 May 2026 11:22:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778350924; x=1778955724; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=xm4Jqgv9FkjocRmCS06tXViVUiGl5UoWhrVE3LZ463I=; b=AJPeNJ63LglTpU+R+PH2jVjqFJcMkWAgV6vo0mZLL/JcCeUAKTdKv5xGJBCrLZOGE4 78AvX7YthGzXfX4DxShQA2TyALnerlpBwdlUJuaJxsTA+tH7wAcHU93Pca3jjF8dKJVZ FHTv8u5NOLJy/KHQTFxhWxu2mKK9RygTqaLKVsr1BgHdU0+DNtkdI5n5+ICWYoIRb/Qw 1RsfnOoNcZ9kI9ruq1meaoGlwebuhSi8rEN2lsMxZLtvaSKcKbDNhnjC1SmycwMMeC3Q tZa/48WtDufZy4Ea1IDu6/a0XMPayyyNjmCpq+w90cgWKl6ZYGq88Y/TmvCYP0UV0MnI K9rg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778350924; x=1778955724; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=xm4Jqgv9FkjocRmCS06tXViVUiGl5UoWhrVE3LZ463I=; b=qr/GtlK/3Bb+jMTbIcTR78F9NDZOnoR8eSYTn2Lpvlc6f6jOltTs33H+ovRGLhaFLN TxNhiFMJIbdxnlBJQOp+Iz7UvurJ7NzqryryEHUx+u06Ys1s3QtFfXwZKkORGoh+qJvj aLD+IdMVE72VkjXwjWE4F4ukerfQZL9+bLqEMAOr7mF21l0eezYcXnm6gFUZ2P5MghA4 VjRDln2pww7/W4Ilo26hyvm8/ZMr0R4EPzCl2ydUyE44tMsFSlkG7cocTmLEgctpoQAa Wyor+k00o/k0Djvg5wl7+MI7VuH4uV3SMAt62adwVTSjrCovFEVwv+rpnOQaIeNYs2vf 93gA== X-Forwarded-Encrypted: i=1; AFNElJ+MfKi0dG1KlRYfLQcAFovTlQCqPOV8PL0PcDJ+TJ4PH8QyufvdSai5am3DJ2lupMsow8rxLWm+maeEv9E=@vger.kernel.org X-Gm-Message-State: AOJu0Yx9lVAWF7emWBGZmLdigvUCATH8iVY2qQtUbojgh2ayov5AIq8B +CjNmqpR5TZcazZ6PAGJMpe8AU7I4BhqKd/okz0xynbR6GglA5MHJNuG X-Gm-Gg: Acq92OHzpEfsNKlcfIOERonKry9guMwkrszyhLlqrEwIcNpZzSv3EGEAQCR18qjQUIm bjwfO8CY/vPTtBOCY0M1MEP0jNNYv/4CoZ+hqOFgapif6SJQJs6f6NBHT6QYM2D9oeSs4DFmMTh lAD9SkfLLG7gp1HoX3lsu19mAcCQ1JKFTfBbI1w7uzP9mnU+kwtzxAzfsmNsnkFcMXrJ02jMMe2 Ev9V+fFyW7yIdKYL82IZD98Wj3inbfWW0QEVzNuHHbAGapNoSkwdVUbHiNufuPymvkzg6ZrhIB+ fc5vfKwfVOwAkkBMI0zrJtodQq7WHf0AJr2sefy+QKxCSBuW0AqCk5euXP1mKnW4VuGEg8O+Y5u NqzDnhxJLV2V/hsKB+X7SdP3Z5pE7l01HNAFYDez+33QdMVPN05SzdlzLh7/h1z7SBBIf0JSKEs xaXp+xqP6wvWWOlDtYSq6OWCbUgh6SLUIXXw9mE/eX/fQC2o1mQxWfUDmwCOaCzkEOgg== X-Received: by 2002:a05:600c:4ecb:b0:485:3bc7:a224 with SMTP id 5b1f17b1804b1-48e530fc6c6mr118896275e9.6.1778350923677; Sat, 09 May 2026 11:22:03 -0700 (PDT) Received: from localhost.localdomain ([82.215.118.79]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6d8946a5sm45598035e9.0.2026.05.09.11.22.01 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 11:22:03 -0700 (PDT) From: Stepan Ionichev To: gregkh@linuxfoundation.org Cc: hcazarim@yahoo.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, Stepan Ionichev Subject: [PATCH] usb: gadget: goku_udc: avoid NULL deref of dev->driver in INT_USBRESET log Date: Sat, 9 May 2026 16:06:36 +0500 Message-Id: <20260509110636.19762-1-sozdayvek@gmail.com> X-Mailer: git-send-email 2.33.0.windows.2 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit goku_irq() handles a number of bus events under a single ep0 path. It already guards the gadget driver suspend/resume callbacks against a NULL ->driver: if (dev->gadget.speed != USB_SPEED_UNKNOWN && dev->driver && dev->driver->resume) { spin_unlock(&dev->lock); dev->driver->resume(&dev->gadget); ... } but the very next branch unconditionally dereferences dev->driver when an INT_USBRESET arrives: if (stat & INT_USBRESET) { ACK(INT_USBRESET); INFO(dev, "USB reset done, gadget %s\n", dev->driver->driver.name); } If the controller raises INT_USBRESET before any gadget driver has been bound (or after one has been unbound), dev->driver is NULL and the printk dereferences NULL. smatch flags the inconsistency: drivers/usb/gadget/udc/goku_udc.c:1618 goku_irq() error: we previously assumed 'dev->driver' could be null (see line 1607) Fall back to a placeholder when the gadget driver is not bound. No functional change while a gadget driver is bound. Signed-off-by: Stepan Ionichev --- drivers/usb/gadget/udc/goku_udc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/usb/gadget/udc/goku_udc.c b/drivers/usb/gadget/udc/goku_udc.c index db42a5e3e..ac2a984c2 100644 --- a/drivers/usb/gadget/udc/goku_udc.c +++ b/drivers/usb/gadget/udc/goku_udc.c @@ -1616,7 +1616,8 @@ static irqreturn_t goku_irq(int irq, void *_dev) if (stat & INT_USBRESET) { /* hub reset done */ ACK(INT_USBRESET); INFO(dev, "USB reset done, gadget %s\n", - dev->driver->driver.name); + dev->driver ? dev->driver->driver.name : + ""); } // and INT_ERR on some endpoint's crc/bitstuff/... problem } -- 2.43.0