The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Md Shofiqul Islam <shofiqtest@gmail.com>
To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: jic23@kernel.org, mike.looijmans@topic.nl, dlechner@baylibre.com,
	nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com,
	Md Shofiqul Islam <shofiqtest@gmail.com>
Subject: [PATCH v4 0/3] iio: adc: ti-ads1298: Minor driver cleanups
Date: Sat,  9 May 2026 18:19:56 +0300	[thread overview]
Message-ID: <20260509151959.3475-1-shofiqtest@gmail.com> (raw)

This series fixes three minor issues in the TI ADS1298 8-channel
medical ECG ADC driver.

Patch 1 adds missing parentheses around the macro parameter in
ADS1298_REG_CHnSET() to follow kernel macro coding style and prevent
potential operator-precedence issues when the argument is an expression.

Patch 2 corrects an incorrect comment: at the lowest supported data
rate of 250 Hz, one conversion takes 4 ms, not 40 ms. The 50 ms
timeout value itself is correct and is not changed.

Patch 3 removes an unnecessary CONFIG2 write from the init path.
The driver was enabling the internal test signal generator (INT_TEST,
TEST_AMP, TEST_FREQ_FAST), which is inappropriate for normal ECG
operation. CONFIG2 defaults to the correct value after reset (RESERVED
bit only), so the write is removed entirely.

Changes in v4:
  - Add this cover letter (pointed out by Andy Shevchenko)

Changes in v3:
  - No code changes; resent to correct the recipient list

Changes in v2:
  - Patch 3: Rework following Mike Looijmans' feedback: remove the
    CONFIG2 write entirely instead of just stripping the test signal
    bits, since CONFIG2 defaults to the correct reset value
  - Patch 3: Add Suggested-by: Mike Looijmans <mike.looijmans@topic.nl>
  - Patch 3: Rename subject to "Remove unnecessary CONFIG2 write during init"

Signed-off-by: Md Shofiqul Islam <shofiqtest@gmail.com>

Md Shofiqul Islam (3):
  iio: adc: ti-ads1298: Add parentheses around macro parameter
  iio: adc: ti-ads1298: Fix incorrect timeout comment
  iio: adc: ti-ads1298: Remove unnecessary CONFIG2 write during init

 drivers/iio/adc/ti-ads1298.c | 13 ++-----------
 1 file changed, 2 insertions(+), 11 deletions(-)

-- 
2.54.0.windows.1


             reply	other threads:[~2026-05-09 15:20 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-09 15:19 Md Shofiqul Islam [this message]
2026-05-09 15:19 ` [PATCH v4 1/3] iio: adc: ti-ads1298: Add parentheses around macro parameter Md Shofiqul Islam
2026-05-09 11:38   ` Stepan Ionichev
2026-05-11 16:05     ` Jonathan Cameron
2026-05-09 15:19 ` [PATCH v4 2/3] iio: adc: ti-ads1298: Fix incorrect timeout comment Md Shofiqul Islam
2026-05-09 20:27   ` David Lechner
2026-05-10  6:59     ` Andy Shevchenko
2026-05-11  5:20       ` mike.looijmans
2026-05-11 10:14         ` Andy Shevchenko
2026-05-09 15:19 ` [PATCH v4 3/3] iio: adc: ti-ads1298: Remove unnecessary CONFIG2 write during init Md Shofiqul Islam
2026-05-09 20:36   ` David Lechner
2026-05-11 16:06     ` Jonathan Cameron
2026-05-11 17:59       ` mike.looijmans

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260509151959.3475-1-shofiqtest@gmail.com \
    --to=shofiqtest@gmail.com \
    --cc=andriy.shevchenko@intel.com \
    --cc=andy@kernel.org \
    --cc=dlechner@baylibre.com \
    --cc=jic23@kernel.org \
    --cc=linux-iio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mike.looijmans@topic.nl \
    --cc=nuno.sa@analog.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox