From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f46.google.com (mail-lf1-f46.google.com [209.85.167.46]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 009DB2BEFEF for ; Sat, 9 May 2026 15:20:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.46 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340008; cv=none; b=tG87rqnRwd03wqeWauNejgsNc55TQVco/bwBdUn9f2frEldjtSZqfd9trxtppM0biz0q9l2XXy5KN3c7hgYFC2DN2OaSmG2zSEWFOwEQ1wVjUB0FYVDgtUfAi2Vw8H/5l7/5Ekf3ghadmfcSNUE5cUCrDdmUFT3gREorfy/hrq4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340008; c=relaxed/simple; bh=7wwEeddHxhCClQzgwuisu1/1yJfMaAt2aMlXmyRxTYM=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=e2eyDpz0sUzmZ1+9Pc+GU/54DG4k4nLMHhXqmjYzNPPnqsJpSE7AqvFmZ5IAJ+7jWtvDjN4dWvGiFUCMQmH9f7Zo4jsIvywFKBKkwEim6Fg4WSWUgYDrIRxIKgLlxQPQAMyz5E1pVc33GsecmKwzoKI86pqj8WTs04Opixj3+SA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Fyo/wmTs; arc=none smtp.client-ip=209.85.167.46 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Fyo/wmTs" Received: by mail-lf1-f46.google.com with SMTP id 2adb3069b0e04-5a865004748so3957251e87.0 for ; Sat, 09 May 2026 08:20:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778340005; x=1778944805; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=Fyo/wmTslXXmIURYnN1/A8q7jgKHYLaukpB3ruT2nlnpH8XNyq3E6qTvrxs9ExecRa E56k6YJdU5WlsHaGrWzLms+cx/2j5O46HYBvXRnHR750Zjmo7PmbYVWykxdMANBVCVii /NN6BUVpjkzkYrZdLL/NokxV6I+IblwYr/UBahhmRo2ltb5NsVjhJlpD/eRdl8wAO0Pv LgoFjjLIN/ZKVtHtMziBJe+U8Ygi0Y7effNd09dW/WVzqcvGsjm+DhIBYgWgN7JXSrql /i1rGQGZjIjviXfOYfOWFBoKKceY1hw6hv/0H17Ktu8TZBcTFneIGDEahjtX5/MknuKE eFlw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778340005; x=1778944805; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=U4zF8aJYC8sIqGUROlbDSF6MUK4SPWjcto9OGe/HwWY=; b=tIdjYysBoSRgTAEJ8GnMN6SLX+jr83p2cL3OaxGMHN/lQN7KXzBpO2sRxP9WS1Rum4 nba6CDp+Ory0jpGkxE49FjJEQasorCeE8T1z+ZRO5cmYyqnY0ql/jB64DnSsiPbXUGle nmtBf+4TyuYR7P0ZoPMobdHKVj76zqMWxOt2aKzmQC29wicX10ifzXmeHmqonGVKgEIQ Az7XGuhidG9IBQ3K6Xu1KdqhhZZpYonCffuI2uhQgXY2/IybVAzTO8nK7BEUDkCvPfI4 QsaFN07+2QdsJXnu7sZdZsCEjuCYg//wB4D7/TO987gF/l5WBd2DTB3Q8Dt6mz7fXLhy yd+g== X-Forwarded-Encrypted: i=1; AFNElJ/TLzTlo9azgz/JtmMzUBq7eHE5NY2TJG356Vht3nWKCcfsUVA0kcRH7kvRQ7O+uL/GhNT8wXRih4z/NTY=@vger.kernel.org X-Gm-Message-State: AOJu0YwgElCOnSX03pB4UooUuyMAiyH75LBbrL4Anm/3g3IkbRXZHAeW YMXX3E+gY02KhO8KBWwPQd5kHlHiQhH7h1EI5JB5RCtp3rDHAFd7xUiZvtqxz8PX X-Gm-Gg: Acq92OFI43K/YEBOxSFxiMD9S06SMQ5QJEnBo+75DeKfNtwitxdHNOWQq1zCSwPgaBB dFWEO4QWHDluYXsb4dGGHrOODxAAF+3f/z5gL1a/qw+z/9NPoypuE62LtkK5gctJ7hR/NRW8lKV 1G0CR5QO/O7LXnqrXRETwisTQuhD2YfPuEMT5ER3s1KhBI6+HXl5lf2I2v9M2YLZCq6XYwZKktv ThVQUsqznyWH162joGVFvUcPdEVYITewEzP3jd41E8a6PgE97k0O/u5MQAof5UKofChXYhGsWuO Iejc+eFggezJbTCiO59d3qGpqXjSKGBOxSIRtBkkIRtHuQ1mLcmFgnapB3EDTEFqAvxNy6vucu6 Z1jvlKDpmq7ZJPWGcZvTdbso0VcDu7/0Qs9SkOOBkoAdMHFZbEPNszDzogzIsFooWaQJL5TZHt/ tswB1VYrWFoTwz3g8kTuDM3sh/cwgjQ/Q/6wbhPRZ05wl0bt/tINGO3YxEuZOOGb6hsNc9zqW46 4w= X-Received: by 2002:a05:6512:33c5:b0:5a8:9157:ad3b with SMTP id 2adb3069b0e04-5a899b90653mr3650746e87.5.1778340005091; Sat, 09 May 2026 08:20:05 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a95664easm1301975e87.70.2026.05.09.08.20.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 08:20:04 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, mike.looijmans@topic.nl, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com, Md Shofiqul Islam Subject: [PATCH v4 2/3] iio: adc: ti-ads1298: Fix incorrect timeout comment Date: Sat, 9 May 2026 18:19:58 +0300 Message-ID: <20260509151959.3475-3-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260509151959.3475-1-shofiqtest@gmail.com> References: <20260509151959.3475-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit At the lowest supported data rate of 250Hz, one conversion period is 4ms, not 40ms. Fix the comment to correctly reflect the timing. The 50ms timeout value itself is correct as a conservative margin. Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index cf5f954206..186bda3087 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -210,7 +210,7 @@ static int ads1298_read_one(struct ads1298_private *priv, int chan_index) return ret; } - /* Cannot take longer than 40ms (250Hz) */ + /* Cannot take longer than 4ms at the lowest rate (250Hz) */ ret = wait_for_completion_timeout(&priv->completion, msecs_to_jiffies(50)); if (!ret) return -ETIMEDOUT; -- 2.54.0.windows.1