From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-lf1-f52.google.com (mail-lf1-f52.google.com [209.85.167.52]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B552D2D738F for ; Sat, 9 May 2026 15:20:07 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.167.52 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340009; cv=none; b=pAGhoum35nH/YlvwbXY2f8dwvm9f9LQjYtPzq9yZD1AYyyHVufl5yzLa31S9JOtMsl/YKM3/ahIowmg+UVv/8jGhi8UANVIIytG8BYvKzt3SCZSmBgI09QlRFHeFx+XSB/hgU/J1+Vo9cl9uQvmGHWTjwVjvA590A7Mu/L/jc3k= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778340009; c=relaxed/simple; bh=8be50cgUO97dUmyXY8QEaFaIeWcvbyn4FZHCMFnyX9I=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=MQJtIHCGOiIaZQgtHspfbwWd4jk/VTcbtp+i7ONrj0ogE05OT1+MAilpLkKNO9nN1D2wEqHc5HZu71Da2KLE8EbU093tXcnfTkidcxPsUQvMpWtGFA3QIisbU4XEaV/gdl6FZlj+Vyx5UXfWpDiS2SZ0I777u2FBtfjqUSa5KaA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ZURlWW/l; arc=none smtp.client-ip=209.85.167.52 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ZURlWW/l" Received: by mail-lf1-f52.google.com with SMTP id 2adb3069b0e04-5a87782588cso3610820e87.3 for ; Sat, 09 May 2026 08:20:07 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778340006; x=1778944806; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=ZURlWW/lJtg8POJYfBq7LjpIXVzfMdfwB+hbk7WrqXxG/2xAnz63baepHvUq1p3Aed sRJTVJDoJUQNPxsp6rVL2VgKCmGuOP4Ny17WgomCytD/o+9vrGvW1JBqCP0aooePb0aZ Wf17QFFuPiWU2soLxtm0j0pthAdueE9nLJ7dg6fXylgpE/5hj6eg9Hu1bLNV+Ttx/KxV asE+cRjjQdUUKEYkxHy053udQJt+qMab0gwbuCzeeqqZkL4Hvu5MdVnYynVoN7UrBwmN qUxTR7hWjJ7txXV1sTVprRMeMpzRDhB12AUzauw0kOsJSgXvuj81POijeUCAQu6RBduR IH6w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778340006; x=1778944806; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=Iev/RaR7ebPD8/QuDYCOu2PRxG+LdvAV0DZxv0cI94U=; b=lHdjqvrAk39UW7VpiWpSEtqS/az0JzOl+n8AEGefwmeORUHyxaeIOrodx/tW5krAuS S3dKqG2VuG/UXfr5WlU+YdCqS9pt94FBy2xiUMLjiq8HP/8D4LbzE7n9BXSyaXmToKvp Ob/OzlnYV7dUnxUadpzS92YmykxZwWfdi1AFpmdzh3ghU88/O3V6lktGHyrQ1H9y6vye RVcv2PVEE1R4yF8u1CfqMn1wF7tL8crjcqbIf6SrwFY2nFr4cbnCqjRQbzP7jy04O0T9 BZSY/FI8xYgB9kRvw+PfC84uX3GbXqVwNFtS/K2uEQBJSirGmX5K8N+O6pC3Ur7s7tWh C3kg== X-Forwarded-Encrypted: i=1; AFNElJ+L7s9qaUGBX49oBWDSyYli2ASz9Uu2JNWk10rzR0Qsbkl6SyiaJaLqUwVHHP8s1L47PAB0OIyqo3v+OW4=@vger.kernel.org X-Gm-Message-State: AOJu0YwScropLjWTARcFEmG7x0h2/OWulsxn7JvGIBIiTo/JtcxFtDGp DHHLzP3on+RykNNWWptc+s/KyKrrhwVppV9aPyMolbDMSpPvuuGAcKmDLj343VX2 X-Gm-Gg: Acq92OFNE0CZNbqxUeT1lWoLaUkNFcZJRHoF61lMLE1jo8GcovOksXUh9+LzdYez9x3 sTm8QXvYBvRmt5mBWDaiEGU1c2WdJ55DoQcbIDV3niRwmXTfFLf2eUoP+IlYonvb9onMVvrA9u6 KyweJvZsG2HgZdr6lzsDvif7Q/m0mdQkGu2RIJ8pmbHlkrpTxB85xozOL9qohB5gz2OpfxPhLO6 O2xLvyyVTf3hWjQiwfmMbT4AmMHqafzjX6Vt8ZxHT3tfut2DQaKVMxJ1E7b8a4yJ1HCMgXpyb2p H262CRoexr9JokG/bjbJAwtBEzzm7wKjkOAQew2idhsaSXf0uXNOpE7K1qrq5giMCOwrPYub62f LU5oNjzpctteen8SUJqJhiLgU79tTroPVFrvgVJdGncbLqNzAnXjJJtMKZ7PDpFOfPJOBlyymzJ ZTbiAhb5zjoZ9RH2fdVtzMFY0TJ6jbz4JExBPRDImem64Eh4Dwdjfs85/tJKIWgfht X-Received: by 2002:a05:6512:ad3:b0:5a8:9c2f:5712 with SMTP id 2adb3069b0e04-5a8b70926a4mr979997e87.21.1778340005784; Sat, 09 May 2026 08:20:05 -0700 (PDT) Received: from Shofiq (87-92-218-151.rev.dnainternet.fi. [87.92.218.151]) by smtp.gmail.com with ESMTPSA id 2adb3069b0e04-5a8a95664easm1301975e87.70.2026.05.09.08.20.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 08:20:05 -0700 (PDT) From: Md Shofiqul Islam To: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Cc: jic23@kernel.org, mike.looijmans@topic.nl, dlechner@baylibre.com, nuno.sa@analog.com, andy@kernel.org, andriy.shevchenko@intel.com, Md Shofiqul Islam Subject: [PATCH v4 3/3] iio: adc: ti-ads1298: Remove unnecessary CONFIG2 write during init Date: Sat, 9 May 2026 18:19:59 +0300 Message-ID: <20260509151959.3475-4-shofiqtest@gmail.com> X-Mailer: git-send-email 2.54.0.windows.1 In-Reply-To: <20260509151959.3475-1-shofiqtest@gmail.com> References: <20260509151959.3475-1-shofiqtest@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver was enabling the internal test signal (INT_TEST), double amplitude (TEST_AMP), and fast frequency (TEST_FREQ_FAST) bits in CONFIG2 during initialization. These bits activate an internal square wave generator intended for device testing and calibration, not normal ECG operation. CONFIG2 defaults to having only the RESERVED bit set after reset, which is the correct value for normal operation. Remove the write entirely since it would just be writing the reset default value. Suggested-by: Mike Looijmans Signed-off-by: Md Shofiqul Islam --- drivers/iio/adc/ti-ads1298.c | 9 --------- 1 file changed, 9 deletions(-) diff --git a/drivers/iio/adc/ti-ads1298.c b/drivers/iio/adc/ti-ads1298.c index 186bda3087..8957e873e1 100644 --- a/drivers/iio/adc/ti-ads1298.c +++ b/drivers/iio/adc/ti-ads1298.c @@ -615,15 +615,6 @@ static int ads1298_init(struct iio_dev *indio_dev) if (!indio_dev->name) return -ENOMEM; - /* Enable internal test signal, double amplitude, double frequency */ - ret = regmap_write(priv->regmap, ADS1298_REG_CONFIG2, - ADS1298_MASK_CONFIG2_RESERVED | - ADS1298_MASK_CONFIG2_INT_TEST | - ADS1298_MASK_CONFIG2_TEST_AMP | - ADS1298_MASK_CONFIG2_TEST_FREQ_FAST); - if (ret) - return ret; - val = ADS1298_MASK_CONFIG3_RESERVED; /* Must write 1 always */ if (!priv->reg_vref) { /* Enable internal reference */ -- 2.54.0.windows.1