From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B3BE43BFE3A for ; Sat, 9 May 2026 19:35:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778355327; cv=none; b=hEzrRTmisdz/yp9zwEN6VKk8Sby4ZU+45PYwyt9JZ9gJzctxZpDc5/PhXnf6A1vYOIKDi+unABZ5bxilaMkK/jn3m6krvWqvdmP5KoIitkpFyV4qAEKZxZDYvCLeDjKLzE4aSRJEHp6JCyoxD8IXKpPKVt1LMjubKNd4voeDKFY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778355327; c=relaxed/simple; bh=JPvggg2tqDTZBAVcoktY8zK68ktMt325p1inzVbLHxk=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=kgUY9rpsNSTW4tGGszeSVEEnhKBBqCIoZUgMFC/nYkEz8mMASUi7Gyltg/CEWFKFNgqzVGkVO30PYdjBSRF2vFNVXxoKjiUA1Q/mgTsjjA8y9wfIrViO+vb45AIDLEyoEbKRqBMsefpGwIW7hLdkE3StaELmE6cNkGSLNSbO11s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=i2WM+iaI; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=NYFOGIya; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="i2WM+iaI"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="NYFOGIya" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778355324; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=JgaTNNWn/gKwcOXFu2ZjkcVejLP2jhNPD5DFZN/synI=; b=i2WM+iaIoIwKOuJsBabgDHHgAKmct7PRtTU9aM9KT5uRKBeUMAqbL5duf4DcQzimRMKI2a fyugxE9Hks28RWZ1Yw2f1lNPP1/HYs2Dp+PItgqA24oZSsfz3krnPBQGJoD6Zw4n+sWJYc PJZoxCql5sO1wrUcqY7AkW4bkNY5S+s= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-112-nR8Cgp5xOPSQReKLDTyJoQ-1; Sat, 09 May 2026 15:35:23 -0400 X-MC-Unique: nR8Cgp5xOPSQReKLDTyJoQ-1 X-Mimecast-MFC-AGG-ID: nR8Cgp5xOPSQReKLDTyJoQ_1778355322 Received: by mail-wm1-f70.google.com with SMTP id 5b1f17b1804b1-48a589c7879so31739115e9.1 for ; Sat, 09 May 2026 12:35:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778355322; x=1778960122; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=JgaTNNWn/gKwcOXFu2ZjkcVejLP2jhNPD5DFZN/synI=; b=NYFOGIyaE9B84pfTaGP1CRO1dAFjRtk6NB78g+83d5p3OgP+fQAx97rTlyeyGE1Y1C hzj4Kh+43QQa2LLs3XTO6p8LawxCpyPDh17IcWeqWstWwIF6yhSTGbDNPEOFcyKRG+II CfnF5hJj3KDwtTgUW3RkweP8BVlzv5DbYD/ahyCejnxwsfw+m7J/fUti/AV5Rq2MFXXq SHTskxGJGxtS3BvNo6obWBZDoQqsT7bIe8evuOKQj3ow7rkRxcetItaA1dUEhFwaoywj Llux+uyIm1VZwJQWGylVSfxXw4d3tPcYhOSnw/Tezdo1q6+nNkmQkJ9UBey3JRLg/4vK io3Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778355322; x=1778960122; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=JgaTNNWn/gKwcOXFu2ZjkcVejLP2jhNPD5DFZN/synI=; b=eTWl+qaapO/ORLuI2TOpockF/1ndU3vrRZklMcWMxnzFMTH0Y9B9VFLl39EWqJf/7y jIjWiUYitKwT76jIvzSpUJ+xaeFzYfb4I9dZLzSQ/yMoAEekMx2gHWsnB8YF6fb/P8MN 9SGICASavFJdPXlzGdkbXdmHc71qhCkrWEVRAx6KlYSxGrrpuJ96ilSFD+t9L30i2hYK UcDbXqGe8idZ99v9+kz/RAnLQHNef1e8N9RdzQYypGepXtPIT4EFBGTEpWAtKq4n1UmV MZYX772B/FeTwN9m4IbQ6wzoEr0LUA01H09kR/QjN1hVgUUkfupBIMzJFrrb+8hfATUh aCwA== X-Forwarded-Encrypted: i=1; AFNElJ9i7aJ84pqpOr6+guI+0118zM5nnqMau03tLNDartV91Co/f318NIIrkYrzjBzRBq9HFaQ3kDETyXV8t2E=@vger.kernel.org X-Gm-Message-State: AOJu0YxezdgS8iDDu8IG91eH3fl7JuCrsjz05K3PlDir7sULI/v3uJVU C0KzPXaMeMaZsJlIX4pP7+dN1BcV4a92ES7Tj00frldhDf6xjg7XUbnA71/2bads1ltY1vxsCGZ w6OaS0rJOOeDhbTyb6sA6dO7NcAUDuH/2HzgWHi/Eo23Vt+Ug5XxTI3M5cb1j5cwHO4KIF+yirQ == X-Gm-Gg: Acq92OE5+dbG/A7xdKIp5mlXMkQDAiYsP5ddBSUo3XwcIyau4QqrCbuKgwIuWhRmo7Q lvMwtSNs5IfagT+x91c/ydSdUcsWFmdSEAO0cxbVD9RiREoXX9C2RWZugdkSRFZty1dvUAvMC10 7BFxW1ohjN0FKjOqevziOXZJ8ZbOO98TMtC8mVOgmjCXl0SsxUUH3ZLW/LbQIFMc4NQ3Xe6+O6L IRRvDgjamZ4qG/YMCrs04OOEyBMlK3vaRnykawuxjQrW2XXHl0p5xkOgMyaQeF+z3IrwsSfl/+V eEe8T4kDtkFNxvSUp9Nt5jxedHnajjLGFwqqli2tS/KTeR7vUjTVKsDNau0H653NrLE7Cn9KkCp dcTcrzJaXcwvXvaEzyJo0XD4YKO373JK04X1WeWVt X-Received: by 2002:a05:600c:444f:b0:489:32b:ac0b with SMTP id 5b1f17b1804b1-48e5dfd6a6amr184198805e9.6.1778355321785; Sat, 09 May 2026 12:35:21 -0700 (PDT) X-Received: by 2002:a05:600c:444f:b0:489:32b:ac0b with SMTP id 5b1f17b1804b1-48e5dfd6a6amr184198375e9.6.1778355321211; Sat, 09 May 2026 12:35:21 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6d8d6988sm27079425e9.5.2026.05.09.12.35.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 12:35:19 -0700 (PDT) Date: Sat, 9 May 2026 15:35:16 -0400 From: "Michael S. Tsirkin" To: Lorenzo Stoakes Cc: Dev Jain , linux-kernel@vger.kernel.org, Andrew Morton , David Hildenbrand , Zi Yan , Baolin Wang , "Liam R. Howlett" , Nico Pache , Ryan Roberts , Barry Song , Lance Yang , linux-mm@kvack.org Subject: Re: [PATCH v5 09/28] mm: vma_alloc_anon_folio_pmd: pass raw fault address to vma_alloc_folio Message-ID: <20260509153434-mutt-send-email-mst@kernel.org> References: <96a2f5a938bf65315ac95e75b4e7741bae018cdd.1778192416.git.mst@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: On Fri, May 08, 2026 at 02:12:00PM +0100, Lorenzo Stoakes wrote: > -cc incorect email addresses > > On Fri, May 08, 2026 at 09:06:22AM +0530, Dev Jain wrote: > > > > > > On 08/05/26 3:52 am, Michael S. Tsirkin wrote: > > > Now that vma_alloc_folio aligns the address internally, drop the > > > redundant HPAGE_PMD_MASK alignment at the callsite. > > > > > > Signed-off-by: Michael S. Tsirkin > > > --- > > > > Hello Michael, > > > > Could you please send the whole patchset or at least the cover letter > > too, to everyone CCed on at least one patch? I only got two patches > > from the patchset in my inbox so I have no context :) > > Please resend this with the right people cc'd on everything. > > You're using an out of date email address for me and Liam (at the very least), I > mark all mail that ends up at the old address read without touching it, so saw > this by chance only. Donnu, I just used get_maintainer.pl. I will look into it. > It's been a couple of months now (predates this cycle) so I'm getting a little > less patient about it, people do change their email often enough that it's > something you should really be on top of for a non-RFC series especially. > > I co-maintain THP so would prefer to see this in context please. > > Thanks! of course. > > > > > mm/huge_memory.c | 2 +- > > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > > > diff --git a/mm/huge_memory.c b/mm/huge_memory.c > > > index 8e2746ea74ad..f51c0841ce91 100644 > > > --- a/mm/huge_memory.c > > > +++ b/mm/huge_memory.c > > > @@ -1260,7 +1260,7 @@ static struct folio *vma_alloc_anon_folio_pmd(struct vm_area_struct *vma, > > > const int order = HPAGE_PMD_ORDER; > > > struct folio *folio; > > > > > > - folio = vma_alloc_folio(gfp, order, vma, addr & HPAGE_PMD_MASK); > > > + folio = vma_alloc_folio(gfp, order, vma, addr); > > > > > > if (unlikely(!folio)) { > > > count_vm_event(THP_FAULT_FALLBACK); > >