From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 613363BFE3A for ; Sat, 9 May 2026 19:38:15 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.129.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778355496; cv=none; b=CrDgbaB3I18bH4iRoClTibpavYxuhAjOcN+41vkr4SjeAUxqdP71QDdQmpTpkx25rmQLz3Pg6+PasobWrNK286kFBRyzVzlSsViNARE7O2+ZL9SuGVHneKGIeSc0+jXQYFXoQUmsjeW2i6pgSzcGmiuq9M+/HzqS1tuMZe7YS+w= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778355496; c=relaxed/simple; bh=LJ8prTqaJOJKTib6YJYHS9vdeOjI1c4LQ/IGaYQNqtY=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=FExPTaiaq8AJsx+hYVIDBLbkGkKITEBdWIvPiy/2c/BrpHBxPscYa3vN/9uZPoD25CogXJwz77b8ZKa/fRlM/16UH9Etm5Q4n/RLUDRVgIlv4J97kY0JRz1HBGdJmhUoyjSjKlZJ/K0/iphe87SETDNYXn0AGqLl7vBzC7KpSoc= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=M0u61/nd; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=mXgzdtgB; arc=none smtp.client-ip=170.10.129.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="M0u61/nd"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="mXgzdtgB" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778355494; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1ANPZRIsHdOb2XjLaWGPcru90KA3pfrVWtS2xY3q4MU=; b=M0u61/ndpHV6xKpjX76veishfMkvifWXokHZG4am3OczRXVkUYfL+jqLHQovMCvwV/GvIF 1IGQB9z0Hd75EMXC0Y1b3sGTGNjDVZrpJSlTN+K6mKHvbVeahG4DS9o8/Caz6pIH22EDRp gc2Ifrm6HqLLB+XSq/S3SbYFfAgN9Co= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-31-YAHTpRA7OXGLS9Yfnup4eg-1; Sat, 09 May 2026 15:38:10 -0400 X-MC-Unique: YAHTpRA7OXGLS9Yfnup4eg-1 X-Mimecast-MFC-AGG-ID: YAHTpRA7OXGLS9Yfnup4eg_1778355490 Received: by mail-wr1-f69.google.com with SMTP id ffacd0b85a97d-43d7d0947aeso1889232f8f.3 for ; Sat, 09 May 2026 12:38:10 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778355490; x=1778960290; darn=vger.kernel.org; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:from:to:cc:subject:date:message-id:reply-to; bh=1ANPZRIsHdOb2XjLaWGPcru90KA3pfrVWtS2xY3q4MU=; b=mXgzdtgBOga7z50tShzYs/7rN/lCb0HwMI53jZM3JLWbW5zDRvExR6JGr1GAONIzon Ep9VtLE0pmu4YpbKzqkplbgLP+/XpS8QtybXLPeknJJ4KZzpGqQP8tsSdzsbHTaebmtA 8GePYpwdziTypHhrOE9aJE6YZs/uFVqGcbltaPHdmkmdnKGLtyrNdeDXurvSnrDLOEKj pHwHnZP4Tl7mACXRbpKm+mnWoaRLM/3tcv+MmOzAuiA19rW8RsrnyPrT0d9Mv5WNx7Br pVAvhktBg2TmubXo1pZJgT/9s+WXz4DrMQtyKPlQXRQPDpkhnxvdVGUEyNtbiERFljao gumQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778355490; x=1778960290; h=in-reply-to:content-disposition:mime-version:references:message-id :subject:cc:to:from:date:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=1ANPZRIsHdOb2XjLaWGPcru90KA3pfrVWtS2xY3q4MU=; b=LxIQIjAy/VG+CfzQISqCov8ZqMoNSsI/imeoR5LvPSiXqRdglag7fUCB3+iwVlk/WP weLy3agPYLingKc0zKTDQx8qoRbWKtgo79qFheYJzizQwtvgQMZcR/ZPWpzhGgAz/3CI sYHMPvkrr3sEUE8g/tSv7Sr01OfQlpkgpGxwgdvqPl2vvF2ljAO021rTTZp/kbDZFI8S Y6XnFnzJzCTWNYnAUvd7QI06sopQSuo4vnxDts2DP7cuG7Ly2XaEcq6TRWPdaidsgtdX S0nWA8CmyN8SdaXMJvz3B6htAi1tyI2sloVK1CzI0haqQwyDEeRSZ6JS7YLaVqWQ73EG xmEA== X-Forwarded-Encrypted: i=1; AFNElJ/BKSLuFw0Qv5w1l6uzKH4EHpjqZdTQoQ9+/+++6NtqvaX99rQ/LdpvhUvOkXnwxUwWdJXBvzPqrocpSSI=@vger.kernel.org X-Gm-Message-State: AOJu0YxxiDbRyyxZ9I09nChqAYccN53JaZNt+xCYDtFc09VCD1xUOxUN iUP1eOx+XdjrYKWruPcDFYIGvW7YqwJ/mQ/SJ8J66uCCBX81Z8GPSPYkf1MAhb+126JekkBWR+j VKzTK39hvgOcotzQgW4Dbb7Fv+SgobDQw33kyxKGeX/PyMdxmR2zwt8994qY+Tzn4tA== X-Gm-Gg: Acq92OFuSUplwzN/tSghGmB+bB9Qzxy+vgXQzt8TSBzugXP6h4EaHs8NrE2K8zLPt+3 uGrV7LOZbxILW6pkn7eL7J0SAUrDDs9UG0HexYvgVLRIeWCwYbvwc8tb4kL6v1ZHr1skAEh/KYY Zc0Z8XqxprMRzly/jjrf/7vpB2LJV0xCGlrvXMvmYwd0sKIPrPdmp7cfb1vlpcfJMyw23wEj6MD asuwuo2m9VLe8EtmqHgGndTsXNUHxUHfdR5OFYG3JP2URhzRRyNTANn1Y6lMnU46DYJmqJvx5SU L5WnTZf0M5eZ+RBVJsAuziXbJe3XWtuMCZa4Jaeb22FNGQrI8QOcurtMkJ1f9Co9zRJXSFz4i3p C4cTVG7VEmZuk11eYAMbbQukPqxNjRKbOMRbh0Cae X-Received: by 2002:a05:600c:1da8:b0:48e:635a:18d2 with SMTP id 5b1f17b1804b1-48e635a1b95mr165361445e9.2.1778355489629; Sat, 09 May 2026 12:38:09 -0700 (PDT) X-Received: by 2002:a05:600c:1da8:b0:48e:635a:18d2 with SMTP id 5b1f17b1804b1-48e635a1b95mr165360785e9.2.1778355489118; Sat, 09 May 2026 12:38:09 -0700 (PDT) Received: from redhat.com (IGLD-80-230-48-7.inter.net.il. [80.230.48.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6db0fed0sm28105665e9.25.2026.05.09.12.38.05 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 12:38:07 -0700 (PDT) Date: Sat, 9 May 2026 15:38:03 -0400 From: "Michael S. Tsirkin" To: Stefano Garzarella Cc: netdev@vger.kernel.org, Yiqi Sun , linux-kernel@vger.kernel.org, Xuan Zhuo , Stefan Hajnoczi , kvm@vger.kernel.org, Simon Horman , Bobby Eshleman , Jason Wang , Jakub Kicinski , "David S. Miller" , virtualization@lists.linux.dev, Eric Dumazet , Paolo Abeni , Arseniy Krasnov , Eugenio =?iso-8859-1?Q?P=E9rez?= , Bobby Eshleman Subject: Re: [PATCH net 0/2] vsock/virtio: fix vsockmon tap skb construction Message-ID: <20260509153755-mutt-send-email-mst@kernel.org> References: <20260508164411.261440-1-sgarzare@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260508164411.261440-1-sgarzare@redhat.com> On Fri, May 08, 2026 at 06:44:09PM +0200, Stefano Garzarella wrote: > While reviewing the patch posted by Yiqi Sun [1] to fix an issue in > virtio_transport_build_skb(), I discovered another issue related to > the offset and length of the payload to be copied in the new skb. > This was introduced when we did the skb conversion, and fixed by > patch 1. > > Patch 2 fixes the issue found by Yiqi Sun in a different way: using > iov_iter_kvec() to properly initialize all the iov_iter fields and > removing the linear vs non-linear split like we alredy do in > vhost-vsock. > > It could have been a single patch, but since there were two affected > commits, I decided to keep the fixes separate. > > [1] https://lore.kernel.org/netdev/20260430071110.380509-1-sunyiqixm@gmail.com/ Acked-by: Michael S. Tsirkin > Stefano Garzarella (2): > vsock/virtio: fix length and offset in tap skb for split packets > vsock/virtio: fix empty payload in tap skb for non-linear buffers > > net/vmw_vsock/virtio_transport_common.c | 47 +++++++++---------------- > 1 file changed, 16 insertions(+), 31 deletions(-) > > -- > 2.54.0