From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D0BD93BE144 for ; Sat, 9 May 2026 18:02:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778349727; cv=none; b=Bs6yCBnRVnDjRl/5q87iFmMbuuz4UFGZ48fwORoC1OcgtxgM+ymGzg7NqZtOhkCkhLj7Y5daQzXGVUHUeurpV9qodjeFXtoHnrpGvlmLniZmsnzSQoHkw/3PsCgU/GwCxgpF5/avkwO7flb5VqMXH5SVMd9FnXlrBkjf1+apwiA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778349727; c=relaxed/simple; bh=LLn5s73WHoXp4TGPafizid2iADOl9iKXGKdcoAq5KfA=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=Fe6aBxbmrBVye6N+Q7sY/1awKcvcyzvdfZmFF+KFA00PIJEJKfQ6o4eiMePLsZWj4aQ2fw5FUh9SkSvyNbUel4aAQZOq9spPJDj9To1zXHO3gUm8rhuti68Og3XoDwMGBH559IZqLdwjxmYNjBvT4EpLl65vb7G6s2o0leM6vGA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=beVui8ON; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="beVui8ON" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-12c19d23b19so5264874c88.0 for ; Sat, 09 May 2026 11:02:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778349725; x=1778954525; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=uqBQg5bJdyOKC6RiN4S+lODerIuB3MBO5alKMDIkVUs=; b=beVui8ONorjGP2f7hgJMS45qir/pzJ1C4zb8L4s8d265rl5iaIkHtZ+uXm3sIz7QLA MIWcicczDxrJimnLkQArVkk+Lt7yxy26ZOprBX53019wA5XHWI/6Leg/gOo1gsvZ/RYD fU5kxsRdtRsWVTsJeFonGyMK8ER9uYIBasFHQ/m3oeZ55kRDJ12Ji3eKR2FD+uWwG6tK EPTLWofHlHGmdngqN/skjDEJ0eNq4XYiqn2Ez3nhYTo/nOd08FGwQtoxWHeTDuXC1ANz 72Rn++nq45zx/KwyW7ZjRRCJJAgLCe0dq6nteqy9rLFwgyiPiXg03f4QHGkCeW0atSHY Jp4w== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778349725; x=1778954525; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=uqBQg5bJdyOKC6RiN4S+lODerIuB3MBO5alKMDIkVUs=; b=dYnHxvHi6i00k09ZU6F7PomFI1mWJy7Y0ZGNbNnkQodkbwD1QhCldobjo1UIgk6LxG 3h/glT7Ji1NPNmewh+USF/+KOzsSu+LrpgONj7bFTy+CkobrDlB+B2ELBzTgPTbooTwE wia8Vv39GAKzY1+/VXf+ryYKYJkjejShcnSuf7EA/MzkB1jw2gSy2u8KqPX5WHRAwrSV r6JrwrCdqBhd5hwaJ1oQVT7PPBFp0y0UVqm+X6V7KSMoMAFLh5uInR5Jpct/jaG/i05I Oo4k98oWJMJv4fuLgOB+W/4ZV2DXa1FxhqSYTfWssUVbMTGyNwqFcZK1An0gqNEKFngo mERA== X-Forwarded-Encrypted: i=1; AFNElJ+3bvTnZWqV6LhdR4to2Y4OW4wPKBPDpvK+W4nCdgMfB7lJXohInF59a/MJ/aaWjyeo6FeEU5Pcy7yPTDg=@vger.kernel.org X-Gm-Message-State: AOJu0Yxjr9JoojmI8zj95jNOSCt6OrJ26/6RdMZI7UxteH7rYpRXvk+A o7mWmpHIYqhjWbIy2DvWqaekbf4mMt8GhdiplF/p7vyhn8u69NItR9vn X-Gm-Gg: Acq92OHoNz/hvhb9+iom7QqykMqQX/ss/mJ1MJlyeFviP/fLpxiRKPJ8Y6hMyLkGZ1s +tlbrABlgkS5g/USpXCC9FIoLJ/ZVlJAXJ+fTJ3kAn0C2/JPqvZvxfiwEWvjZknVasHcZnlId8s vd7fG8/86LnFNict8qgoTn2TBWtExQ+bTXXp14wQKt+z55/Oh4WhzBtYZShfL+AgcGtWVVLDAPq W9DYpa/JQggwfldDc4BxnTUahw3swcK1U/F2gNFEeMCZobHCixzvzTOTCD4yWU75KjT4PI9VQDQ fKW62ggM3WFe9e5YhztHuzs+BaifrSqHKPXKUpKLFQ7ilahr5PhlFTOi/QTmfVIiCFGxBKS5n6g 0w9XA/4vnRzNeDkEBMvE74LW+OdCLaU3nCEbfa7ROaUvYp5z2DOw+ilSMl2ewm/UVcA1xXFqi3M FZOzjNqMYUVO5z9X5MDwUBlETqCqFrAHc2LZJ7NYj9vtoPwiSX07pwN3TIa1Ac8w== X-Received: by 2002:a05:7022:45a5:b0:12d:ed19:e6c6 with SMTP id a92af1059eb24-1319d14da49mr9351754c88.31.1778349724968; Sat, 09 May 2026 11:02:04 -0700 (PDT) Received: from rawhide.lvn.broadcom.net ([192.19.161.250]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-1327821fd00sm8979500c88.8.2026.05.09.11.02.04 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 11:02:04 -0700 (PDT) From: Shreenidhi Shedi To: gregkh@linuxfoundation.org, acme@kernel.org, linux@treblig.org, mikhail.v.gavrilov@gmail.com Cc: yesshedi@gmail.com, linux-kernel@vger.kernel.org, Arnaldo Carvalho de Melo Subject: [PATCH v1 09/18] perf strlist: Don't write to const memory Date: Sat, 9 May 2026 23:05:50 +0530 Message-ID: <20260509173559.10999-10-yesshedi@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260509173559.10999-1-yesshedi@gmail.com> References: <20260509173559.10999-1-yesshedi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo commit 678ed6b707e4b2db250f255d2f959322896dae65 upstream Do a strdup to the list string and parse from it, free at the end. This is to deal with newer glibcs const-correctness. Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Shreenidhi Shedi --- tools/perf/util/strlist.c | 12 ++++++++---- 1 file changed, 8 insertions(+), 4 deletions(-) diff --git a/tools/perf/util/strlist.c b/tools/perf/util/strlist.c index 8a868cbeffae..98883672fcf4 100644 --- a/tools/perf/util/strlist.c +++ b/tools/perf/util/strlist.c @@ -139,21 +139,25 @@ static int strlist__parse_list_entry(struct strlist *slist, const char *s, return err; } -static int strlist__parse_list(struct strlist *slist, const char *s, const char *subst_dir) +static int strlist__parse_list(struct strlist *slist, const char *list, const char *subst_dir) { - char *sep; + char *sep, *s = strdup(list), *sdup = s; int err; + if (s == NULL) + return -ENOMEM; + while ((sep = strchr(s, ',')) != NULL) { *sep = '\0'; err = strlist__parse_list_entry(slist, s, subst_dir); - *sep = ','; if (err != 0) return err; s = sep + 1; } - return *s ? strlist__parse_list_entry(slist, s, subst_dir) : 0; + err = *s ? strlist__parse_list_entry(slist, s, subst_dir) : 0; + free(sdup); + return err; } struct strlist *strlist__new(const char *list, const struct strlist_config *config) -- 2.54.0