From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f42.google.com (mail-dl1-f42.google.com [74.125.82.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 3CC403BE620 for ; Sat, 9 May 2026 18:02:04 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778349725; cv=none; b=Bi92DWYLQwXz3NUy9nyPly2nFfwtEGMHW2+LE7qN/dSrG+2Apz7XIZ+Yf+QEt+yiyXolWutxviYb6WFy+ojcO80OsMIgUFex9n/uXuq26Q5l28yQ0sUI97tZkcFJ+/DS7J6a7+XUPgZ1VSrIS7cKfhVL7HoZfBe05xN+cekQlHE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778349725; c=relaxed/simple; bh=XQf3/FeoaBmhLuV18cO6IXyBZ3cqa7lrQgUfRN4w1mY=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=ApwmNYXcXMSWrV2V65ke+3bJM3FyUlNNBXt2GeqmMDwfYzLZ2BR6zjDsTh+CL9A4xmD4DZwM8p3wBcCjMqgiHteaxxjvCx8FMZ9ho//XswYzAIaMjghWrkyI4jJVWuRI/ZL1UH4XXwfa/w5VDW3XOAY3p25++cbMEH3zuAPPCZM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=RdcC/EPj; arc=none smtp.client-ip=74.125.82.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="RdcC/EPj" Received: by mail-dl1-f42.google.com with SMTP id a92af1059eb24-12c88e5f4aeso1875739c88.0 for ; Sat, 09 May 2026 11:02:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778349723; x=1778954523; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=FKuYit74Tf289NdrqxvgCkfuNHCHh3wo2jZv3YeRqUI=; b=RdcC/EPj/YE+WNMFQQR/Qw55BITNhVnRZ8ZCmdgAz7RPfS6Idf1DL26a/fCvYWoaWh mq7uOjxPne9CuwNEZGPGywXsHFkXNDlUt7DkMDw+pwS29b3sARxZmvpN0OW4k+ThBbZW bCdBUR2d2/wjVvmoI0JpvEo6+SsFJJZ5bKSCKgb7opM6CFTGz77tRWBQFzS4xFS72mEM y+KybGDoNXs+p2/PhUvgQBhLm5TVaN76ueY4ghYjZ9zZLhDzRzVjQrntRYIF1ChlM9Vf nVCepHfVrnMLX8UgramDAHnQePi6pUjCK7d3U2lKlEZotzNYRC5sgAV1tZuQANqJPIZe Posw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778349723; x=1778954523; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=FKuYit74Tf289NdrqxvgCkfuNHCHh3wo2jZv3YeRqUI=; b=RjOWEVV32Mzb31UC5VVhaB7ObXwh+IhrWWAncNxLoram3GjoPo9/3Jf4fMwj5LIO3D 2WoDjk6nZMfOwGiQecMICMC2T2edBsLjzZIs6mmoAb7Won+0V8Yk+aedpk84LI4sus0B pxrBLLd0hDtej98EQkxKyJLx0bcOuzRzaZLIwfgU9F7s4Lub5KoVKr9Zl+FCUHPPYOod x0s6Ild90b3Ae6313sGQAX+96k872qH03FPKJ4A2r8dce+gXekT/hopDp1wSjEN1sZ0x loVjUfAZF6BxprP4GG/2ebsmJdypxY3axL3ENr9uA2eT/ohhODcONZcDtgDdIXHifGwP iNeg== X-Forwarded-Encrypted: i=1; AFNElJ9d/BOLzyRtKrvSXpoRTy9dCc93VoxH1b/i+Mu2NMpdo/MlEpFLZG8jKeQYkhKUKMvl+RO30VqcSrJB8pk=@vger.kernel.org X-Gm-Message-State: AOJu0YxhFgs5rdA10DwqDE9krEVyWPurztJqs+zEwd3AyVv8tFNb+Kd0 ulITYmai3Q1jW1svU0wHYt9h4+Slny4aHs6CXseTlBImuOE9S8/jFTBi X-Gm-Gg: Acq92OHja/HxYUpBv3qWhp2InT2LgQzd60w4bSoRg1WkK4S53tu60XBjydEOxb5niEr ObkjehvuCSTgn8LTb5LnnES6JBVuSx0TSWA3+xGpUdfUDtpTFfAEHnsyp+48bS18FFjdTK3aDuz +NrUbtUFuV0sY+1EC4rKogwJUWLCw0qIlqHdE+BneFXai0TknfVn+2aQh/fHm1xtDEFeOabsGGz mtGRKQwFHJ8/YzG/xW4zdvwUFRFI+gVtTxgBfygOdsoLB/CaWyWQXdoXPU8UDqROFUwF992eXbJ SRYTuz5QutKF8fcgQvokogRgVHcWuD75QrBMpYAoWE8z+aQXWUtEBMfr4ECmxZrTal//18QUnB/ jMmSbXmmAljA9NZN76kIK8qx3LvobyZAev0CUFvXCi3rc5B4C5tujo1b6ZWmrp4dsbGFOUTnMfh vITyQi0kz9u13OrbVH1a0PMozwGKNLwQXZk8JdTndzURgke6Il24wQXo2UWaTZ0A== X-Received: by 2002:a05:7022:486:b0:12d:de3e:86b2 with SMTP id a92af1059eb24-1323b0af222mr5501793c88.21.1778349723413; Sat, 09 May 2026 11:02:03 -0700 (PDT) Received: from rawhide.lvn.broadcom.net ([192.19.161.250]) by smtp.googlemail.com with ESMTPSA id a92af1059eb24-1327821fd00sm8979500c88.8.2026.05.09.11.02.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 11:02:03 -0700 (PDT) From: Shreenidhi Shedi To: gregkh@linuxfoundation.org, acme@kernel.org, linux@treblig.org, mikhail.v.gavrilov@gmail.com Cc: yesshedi@gmail.com, linux-kernel@vger.kernel.org, Ian Rogers , Arnaldo Carvalho de Melo Subject: [PATCH v1 06/18] perf tools: Use const for variables receiving str{str,r?chr}() returns Date: Sat, 9 May 2026 23:05:47 +0530 Message-ID: <20260509173559.10999-7-yesshedi@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260509173559.10999-1-yesshedi@gmail.com> References: <20260509173559.10999-1-yesshedi@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit From: Arnaldo Carvalho de Melo commit 45718bce7daf39c618188b70a52644bb5a2f968a upstream Newer glibc versions return const char for str{str,chr}() where the haystack/s is const so to avoid warnings like these on fedora 44 change some variables to const: 36 8.17 fedora:44 : FAIL gcc version 15.2.1 20251111 (Red Hat 15.2.1-4) (GCC) libbpf.c: In function 'kallsyms_cb': libbpf.c:8489:13: error: assignment discards 'const' qualifier from pointer target type [-Werror=discarded-qualifiers] 8489 | res = strstr(sym_name, ".llvm."); Reviewed-by: Ian Rogers Link: https://lore.kernel.org/r/20251211221756.96294-4-acme@kernel.org Signed-off-by: Arnaldo Carvalho de Melo Signed-off-by: Shreenidhi Shedi --- tools/perf/jvmti/libjvmti.c | 2 +- tools/perf/util/evlist.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/tools/perf/jvmti/libjvmti.c b/tools/perf/jvmti/libjvmti.c index fcca275e5bf9..d6b04d0fd35a 100644 --- a/tools/perf/jvmti/libjvmti.c +++ b/tools/perf/jvmti/libjvmti.c @@ -142,7 +142,7 @@ copy_class_filename(const char * class_sign, const char * file_name, char * resu */ if (*class_sign == 'L') { int j, i = 0; - char *p = strrchr(class_sign, '/'); + const char *p = strrchr(class_sign, '/'); if (p) { /* drop the 'L' prefix and copy up to the final '/' */ for (i = 0; i < (p - class_sign); i++) diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index 41bbe6f85b0d..391a694ae2af 100644 --- a/tools/perf/util/evlist.c +++ b/tools/perf/util/evlist.c @@ -1885,7 +1885,8 @@ static int evlist__parse_control_fifo(const char *str, int *ctl_fd, int *ctl_fd_ int evlist__parse_control(const char *str, int *ctl_fd, int *ctl_fd_ack, bool *ctl_fd_close) { - char *comma = NULL, *endptr = NULL; + const char *comma = NULL; + char *endptr = NULL; *ctl_fd_close = false; -- 2.54.0