From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from CH4PR04CU002.outbound.protection.outlook.com (mail-northcentralusazon11013064.outbound.protection.outlook.com [40.107.201.64]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1198331355B for ; Sat, 9 May 2026 18:03:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=fail smtp.client-ip=40.107.201.64 ARC-Seal:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778349816; cv=fail; b=U5HCI20rLLR/zT2ChUF0BKMq9bSLHewMsOXDBYImK205kOBuCdN8qtcAc8rfBtwD1owlkZqOx/1Zk1rat1gfWAwD9Scs7Vbb1Wt9YF834Pmgc6WhACGRPtUyIeMZDTxC34net3jvvP8qRZPqqKJeKo+UJSoX+fcNU7fya+o70zk= ARC-Message-Signature:i=2; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778349816; c=relaxed/simple; bh=sccEN1SyvVGmKrY18Dm5TFmcdNEPwmZSI4z8fA5yv7k=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: Content-Type:MIME-Version; b=ROUqjwpS+HoR43v2k5qD6w09q5ymMndJ04DBij9e52vT8s+zKUQFUKLWl8e3jEW3utobd9Cppt+37k88H+DFgHT8lEbGsd6Zt0tkPNkci5v+aagRiatsE2QBE+oWGnlhIG8IbFCQw1fapAdWxUPeOC+oM9qRaAz2QUHQlTYfi9Q= ARC-Authentication-Results:i=2; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com; spf=fail smtp.mailfrom=nvidia.com; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b=T8e+XGR9; arc=fail smtp.client-ip=40.107.201.64 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=nvidia.com Authentication-Results: smtp.subspace.kernel.org; spf=fail smtp.mailfrom=nvidia.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=Nvidia.com header.i=@Nvidia.com header.b="T8e+XGR9" ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=k/Xumvf+mF3PEnFSYWOX2P1DOewHkVN83CC9clqEx7coh/qaQNN1Itf/cxxb+1A9XflRruJF8L9vKIxGeI6rAVnF9xn+qZPndRekkLYO8YbCB56WVzks1qSrMqbIfdN9Nld4bHmsf0Y83CS9AOVdHdQBqAcyMSr1LPMh16qI4+ZTm7ibET6bQ9XFo5rkQeubHdDhKtH7PDYpKFeZE6hMpPhQux+AS/xcmcdzXBlYHVYfIgflF3NAQKysgUxcxpFfKk8NCdEWqJHO+YHIER9Yn5epF2Hgtu1oV9t/XEUVMhcW6P/9xsnJj2dOmPN703BE5BGvFJpYtAgpL6Khk6AvxQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=TJyYYFnMhT/fB3OcR/rIPJ0TPlmtMqiWyCqu1pqsSms=; b=s1XnvFyAjIIfVnwIYTNiBGSFCG07cOhOXaeM/J5oOeIOoqH78J77olL1WgYXup4skvVleKgwtSeJKdv1cA1ES2O1NiRRrcakjX8JiYcmxB7OZa4zEagYJnKvXVviC/wtajs3N1hPOaoxK7mhZF+m7sNOvbuEsWWbwdSu+tk1ORbxviAi91G0m7yHMjbWLUk6S0KCTF+AAuD7m7OI3z+ygjKOADthiHuTAWJxZF4Bj5KYQzHI6ft5zUdgLCeH5lEV7tRX7xDgH72TGW4MP4/PZSgRShimra0ifjN8hxb5zKi67az2aUQPz2n4JTlwDedEKuBspWWryPN1fBDCgaxx4w== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=nvidia.com; dmarc=pass action=none header.from=nvidia.com; dkim=pass header.d=nvidia.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Nvidia.com; s=selector2; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=TJyYYFnMhT/fB3OcR/rIPJ0TPlmtMqiWyCqu1pqsSms=; b=T8e+XGR9+VT/0V60EVQGwIeU18Qqn2ghtNdi7h5zmnZ5h0lJA2TTex9vevUaqSydzTzFrVR/AR21lWnhuCvGDzKkAiPfKgXxUKclcMIDhaBuTyoM+cM/CJkdyvOU4JExqr1anvqGWRBSHMHQvwSU44fBztjW8bwdS+xa8+PQhEt8/bDtuWOy6I10I81oVoPBCcRubHFd6O71isKQZSRmu4KWRBu8lRv3bsF7L3bPwV6y3q5wMmVlxGu/Y9gbXWpByFDmWQRJ82W5BTmYZQxOUapFLx2cJ/1jeL9GYSQSuC7Sm4q6jOjlKF1nPW5QUtIxRhqE5BkDCu2gB2rg/oFNeA== Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=nvidia.com; Received: from LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) by DM4PR12MB6039.namprd12.prod.outlook.com (2603:10b6:8:aa::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.9891.21; Sat, 9 May 2026 18:03:27 +0000 Received: from LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528]) by LV8PR12MB9620.namprd12.prod.outlook.com ([fe80::299d:f5e0:3550:1528%5]) with mapi id 15.20.9891.019; Sat, 9 May 2026 18:03:27 +0000 From: Andrea Righi To: Ingo Molnar , Peter Zijlstra , Juri Lelli , Vincent Guittot Cc: Dietmar Eggemann , Steven Rostedt , Ben Segall , Mel Gorman , Valentin Schneider , K Prateek Nayak , Christian Loehle , Phil Auld , Koba Ko , Felix Abecassis , Balbir Singh , Joel Fernandes , Shrikanth Hegde , linux-kernel@vger.kernel.org Subject: [PATCH 4/5] sched/fair: Reject misfit pulls onto busy SMT siblings on asym-capacity Date: Sat, 9 May 2026 20:01:24 +0200 Message-ID: <20260509180302.1839122-5-arighi@nvidia.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260509180302.1839122-1-arighi@nvidia.com> References: <20260509180302.1839122-1-arighi@nvidia.com> Content-Transfer-Encoding: 8bit Content-Type: text/plain X-ClientProxiedBy: MI1P293CA0030.ITAP293.PROD.OUTLOOK.COM (2603:10a6:290:3::17) To LV8PR12MB9620.namprd12.prod.outlook.com (2603:10b6:408:2a1::19) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: LV8PR12MB9620:EE_|DM4PR12MB6039:EE_ X-MS-Office365-Filtering-Correlation-Id: 4db817e1-5373-4eef-d09c-08deadf54564 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|7416014|376014|22082099003|56012099003|18002099003; X-Microsoft-Antispam-Message-Info: HkZtQfWa98A8+IksPzUh0HzPI2I/au9C0N+tHoiAgH0uUCrt9YGRZeEW3FAj4dnBuzI/C7MKvgDj0ou5tDG3VZF3E0SQBHBqPqfyHzy3qx4tOZy3s9kF+/53aGq/QddRHVlQSwjXwlDXQnuQmIVDmhxC3NPq4qRIDBjH6gdOHWyy09EXzlPfmqDYvJnqoWiQTZ/n0k5lCjoz+sw1aNUFQPLHxBIiI9jSqkwa3A0jIIIdPjypRmWRD3WhtlsaRDhtX5LWF+ZoGurnGazXHpHBG5c4Vsm7W7x6AHSkDXYmGdFoaHVYJnUByyboRr7Q0L9IBz7HGjqEBb0iX1z8HjhBRL/bHX7Ctdvf0O0TOSoJZ+UA+pNpZ7YoJOx7od5Mv52Ten94CVQfxN8y4cAElcwG+ntBZxRJqHmg2j5X5EGpmCJS1Xz8UcoOHMM1NioeE1zYIYfDmJJ7ZLYBIZu8MnI+CcY39oGBDgw0c/sdBsl/asIhX5ry6rsz0POlNKwjTJgTmPZRgy28FiDViZ0DKl+iFT1dqgsZCJ3jamKwneDzzdNy5+fJMboL1K1qOtp01+eM5W09uPB2w3/n6T+Rb/CZeECNlqeffwOgsttaWuXP56lZwPsURSeUF5VlloQs5ufbDIpeJSefMKkfpvTHvsWOUP5UyIHVvG5bJ0zD7vYdog+6jI9y6m80VC/c5zATLPTb X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:LV8PR12MB9620.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230040)(366016)(1800799024)(7416014)(376014)(22082099003)(56012099003)(18002099003);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?us-ascii?Q?28eWiOGcOdpzCrdQPrGReJGdfMZJTsqcWSM6fWQdozi+ZitdT7WzkNysvTt4?= =?us-ascii?Q?R6j3qp00OszfHiKs/k5ILOZ56bwVjrmAY3pWXOgYEfSByHxE7zFbcZ0s2JSG?= =?us-ascii?Q?G4Ez1x/BMz4qVTdM8FrIy0n083goT8usnVkgVbRfc0KrgwRsI5rpZtcUp0Xd?= =?us-ascii?Q?sd083FJJU1ik0LzD5rWUejj4lJw2KpfsYU/Kj1E4LIFYXb5LC0a1sRHnMpxU?= =?us-ascii?Q?8fhOUcbcujUULY/w859dOaTq6oVVYF6SGXrIsA5JVHQSFRZxRnbgb+JuyH9I?= =?us-ascii?Q?PdyCOnv78TNBxgJJXp/ReEkmDwRqvb3uUY6dC2224qgpIRPzFDlAasR4wyVO?= =?us-ascii?Q?qWnYUkmRLRmJACUT/d4MsrtW7b5o6fdCAvs7/ky6e17YUfqu72zQFl6Nyoyo?= =?us-ascii?Q?POI8M07mY1VZK75s7VNwl3h5nH6BwTJbMkV8uF/A7GV1KgkNQ6dqlQ5pUwUe?= =?us-ascii?Q?GGpzALdjhd2PYkAu+QqvAuyaoq66T5W8M+8CZzrtcESZSYhIuk8XfOXTdIAS?= =?us-ascii?Q?H5i2xzs2UnjBQi+bwFGCAPCEMZrSyAeH73gQVB7ldbLsoA9J1Q0GdM76NRqL?= =?us-ascii?Q?bPsuvMnzLXyxOQhgqYir/m0ExWbVU8Bnbjoy1ylZZT6Jyac3I+btvQPJSL9f?= =?us-ascii?Q?iz3Q/SRJjIiWCd/gDrqrnTcStkbo48XzxhO1yIiT44HbWPMxK0tbF5cPeSjP?= =?us-ascii?Q?rjs1o9Rev3hW0mAyQEc5Qc+esArqTGQfFUlQ+q2zggE1k+ZA8Jc3YYxLBOTj?= =?us-ascii?Q?f0pwxZjRwzcDoUIPtf7VFlnkSkMR1aUZRaDO/drn4eGgMaWnsQTp0fP9+Gi/?= =?us-ascii?Q?ZHWTdHZxyGfFs9NaOpvpY6E6aac7CQ/WhW7xg7qgkpih4ypjMntWd08SixZM?= =?us-ascii?Q?PXpx3I9lOx/SvsPyCaKq08rG/ZZraRnUFmpnz5xgsonTz6F5lfkMdYjV/F0B?= =?us-ascii?Q?AnCsdLHjiAm9CrSjWesCaiVdeCNm0Az9BhXOIOg7iDa6vvxDbs/5Pw+k07ki?= =?us-ascii?Q?6QQNOtLKna07H8h5y550ojjqMKaFobEXu44l/p9ROJiwZf8E4J5CpPsO+uB4?= =?us-ascii?Q?6Cskzc1/vO4rc3HiMyklPuu1hqqKpCfg9BoU5mT5RNJstqrehZ/+CONM06Uo?= =?us-ascii?Q?MyYIJYDYZLwxDG9gR8YJAeIKywXDJBcPyqCzUMb+vqNYoMIAGWHejj1xoJfX?= =?us-ascii?Q?K+Hhjg0vndrdag8HnhSOzzjLYdxhu8pCGp1lZzQ9y5DOerWCNuGdTIFx89Iu?= =?us-ascii?Q?RtBv5viS+rZ+yUr4GBofHgFTdbSFBGqRBe1f2LanegRyYlII03D4G9Syyn5h?= =?us-ascii?Q?kwFj6sOS6156DNufQZvspKXIMHMr4lSejrrp52SrvQU32pyLAJo8XJNWLDHG?= =?us-ascii?Q?KC3lu/JFdfZkv8BT1jZ0noQetAUwJCzTqenOcrcAgxeU6FsaUX4814MywNEg?= =?us-ascii?Q?YOXpfBdOF2E/E7IH6LiV/xn+p3MolgVyo8seDVVklA7coOC7DarTtZBJtVja?= =?us-ascii?Q?AJL4hy/z1CEUMKRAXLbMMRtnmC0Z7fT9CoWT9xEz+kA6vdg4IWNotdnneOnu?= =?us-ascii?Q?nemIUl01X7dfcUggRlWIfdFh8IMpfIdlj35YMh+jNsxQvfXwBQmsboHZaXlA?= =?us-ascii?Q?1Vsxwzjf4ndsqeYY7HetNPCEz2KD0rlvYgJGUD8q/lmt4TPLWrRXWHENlhEz?= =?us-ascii?Q?HlchYoePuMqHYZoxCziYFcqoLqXazqa8r3FNCtu1aXEzuTCW?= X-OriginatorOrg: Nvidia.com X-MS-Exchange-CrossTenant-Network-Message-Id: 4db817e1-5373-4eef-d09c-08deadf54564 X-MS-Exchange-CrossTenant-AuthSource: LV8PR12MB9620.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 09 May 2026 18:03:27.7140 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 43083d15-7273-40c1-b7db-39efd9ccc17a X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: w85nZJp2QZQEGsq0LLVzYBDZaCnTk15SPMGkEm7veviuTZ3bwo16heiivG9FZk0tEk6ykgdp1MWqBC/t64IXbQ== X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM4PR12MB6039 When SD_ASYM_CPUCAPACITY load balancing considers pulling a misfit task, capacity_of(dst_cpu) can overstate available compute if the SMT sibling is busy: the core does not deliver its full nominal capacity. If SMT is active and dst_cpu is not on a fully idle core, skip this destination so we do not migrate a misfit expecting a capacity upgrade we cannot actually provide. Cc: Vincent Guittot Cc: Dietmar Eggemann Cc: Christian Loehle Cc: Koba Ko Cc: K Prateek Nayak Reported-by: Felix Abecassis Signed-off-by: Andrea Righi --- kernel/sched/fair.c | 11 ++++++++++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 6f0835c15ee11..2ddba8bd27e59 100644 --- a/kernel/sched/fair.c +++ b/kernel/sched/fair.c @@ -9693,6 +9693,7 @@ struct lb_env { int dst_cpu; struct rq *dst_rq; + bool dst_core_idle; struct cpumask *dst_grpmask; int new_dst_cpu; @@ -10918,10 +10919,16 @@ static bool update_sd_pick_busiest(struct lb_env *env, * We can use max_capacity here as reduction in capacity on some * CPUs in the group should either be possible to resolve * internally or be covered by avg_load imbalance (eventually). + * + * When SMT is active, only pull a misfit to dst_cpu if it is on a + * fully idle core; otherwise the effective capacity of the core is + * reduced and we may not actually provide more capacity than the + * source. */ if ((env->sd->flags & SD_ASYM_CPUCAPACITY) && (sgs->group_type == group_misfit_task) && - (!capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) || + (!env->dst_core_idle || + !capacity_greater(capacity_of(env->dst_cpu), sg->sgc->max_capacity) || sds->local_stat.group_type != group_has_spare)) return false; @@ -11485,6 +11492,8 @@ static inline void update_sd_lb_stats(struct lb_env *env, struct sd_lb_stats *sd unsigned long sum_util = 0; bool sg_overloaded = 0, sg_overutilized = 0; + env->dst_core_idle = !sched_smt_active() || is_core_idle(env->dst_cpu); + do { struct sg_lb_stats *sgs = &tmp_sgs; int local_group; -- 2.54.0