Re: [RFC PATCH 03/19] mm/damon/core: introduce damon_filter

[SeongJae Park <sj@kernel.org>]

On Sun, 26 Apr 2026 13:52:04 -0700 SeongJae Park <sj@kernel.org> wrote:

> Define a data structure for constructing damon_probe's attributes check,
> namely damon_filter.  It is very similar to damos_filter but works only
> for monitoring purposes.  Also embed that into damon_probe, implement
> essential handling of the link, with fundamental helpers.
> 
> Signed-off-by: SeongJae Park <sj@kernel.org>
> ---
>  include/linux/damon.h | 36 ++++++++++++++++++++++++++++++++++++
>  mm/damon/core.c       | 30 ++++++++++++++++++++++++++++++
>  2 files changed, 66 insertions(+)
> 
> diff --git a/include/linux/damon.h b/include/linux/damon.h
> index 65d7ee0a70ac0..3290792eab547 100644
> --- a/include/linux/damon.h
> +++ b/include/linux/damon.h
> @@ -732,12 +732,38 @@ struct damon_intervals_goal {
>  	unsigned long max_sample_us;
>  };
>  
> +/**
> + * enum damon_filter_type - Type of &struct damon_filter
> + *
> + * @DAMON_TEST_TYPE_ANON:	Anonymous pages.
> + */
> +enum damon_filter_type {
> +	DAMON_TEST_TYPE_ANON,

I initially named it damon_filter, renamed to damon_test, and then returned to
damon_filter.  This weird name (DAMON_*TEST*_TYPE_ANON) is showing what I
forgot reverting while the final renaming.  I will rename this to
DAMON_FILTER_TYPE_ANON in the next revision of this patch.


Thanks,
SJ

[...]