From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-oa1-f53.google.com (mail-oa1-f53.google.com [209.85.160.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E3E5B1E520A for ; Sat, 9 May 2026 21:19:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778361566; cv=none; b=nz9rQFurFe1nD3IVbYhUxRTJqTLRxmLwAnbSjEsmBqZNE6K4gbOuE2gHimygwNURoJxEZVGJbQjyzGrUe5ekR6Blgwd8wxnAEehZt1L0mE22dskR/74LYEwC42Do5DqClXJt8CnWYeoVae8k5Ev3Edw77czJpFABT9sWqJKDlW8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778361566; c=relaxed/simple; bh=kyO0Kztq/EWSl7hefaMz35kuy2WDsxmgAX/RqqB/wqY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=FnyC0dXZ7+YH5vVhy7EMeiEv64obl/4BxJs/SOrizj7/CtOB6ph1vPgcz/eLPALuQx4U/S3yKgdaTnmxutBkQX6tGyNe3dthEN7vEqX578WIEcGjqsuyDVsAp9/tULptWfKRVlfb91LPSrYSsXOA5a7MbUUpWSWbBjLZ+hq+/Eg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P0PdAxks; arc=none smtp.client-ip=209.85.160.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P0PdAxks" Received: by mail-oa1-f53.google.com with SMTP id 586e51a60fabf-42321c8b8f5so2521035fac.1 for ; Sat, 09 May 2026 14:19:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778361563; x=1778966363; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=TClOWT8aHdrbSRekQXx5ViituCwMT6kPSJNtcS0Sujk=; b=P0PdAxksXodBhJbF9bfSUdlG0JOYykyyPqNAEOjV8pEJdl8am+TPfTHYa1hX0tg51m ME2HCauhL8sAWvUpj0uc8ubTMTCyV/eY85pea+5nWYDdV3u4eYSnyI4pKwug6Y15mPM6 0wJAP18F51Dho0tZVhk2z6U1wzE02QXrBLauN39LQJI5iRdg/uVt/Xafp03vrJvunjoP 3ihYCFmNf+znaL0dzLx8UONhODq2fr44RZhpO1D0RPexHaINJF5jB+b6kEUCShNWkmns UTTO440K8pONMR//k9YTsmNXw+noAj+G7BEeBzZ++9i5zZqZOYTnLPKnC589+WQ1z54P CZ7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778361563; x=1778966363; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=TClOWT8aHdrbSRekQXx5ViituCwMT6kPSJNtcS0Sujk=; b=bsYzyhO1B8+xxhHTRgaj1xYPF8FYPOjrp+2uj0NAooQb+aSwMOg1sYYdsHf1PEfLMa ENrccJXLkLUnVqLRUbOOpkyvk67flzra8/s2///Hj9aMWsCzdGPYImxS1pMmarw1tk3t t8Im+POK7flNANycO+DOn16aehZmQsgTWxPng0A38zmoJAn4xHsYMNE8H4R5+o9K4ve8 IQ8ZA1WPJzEhwwGCOQ7a1eQE0Pbc+ATX4Uy4ObYgW6p0HKNDnQoUDsDsIPItwehQ2o09 64EoaAoUHr5JhPJDxHnb79tp96WIhALa0Tje4c0X2ULmHik0vwEJhmOgrgNT+0zJTju+ lqxA== X-Forwarded-Encrypted: i=1; AFNElJ/ycu66IKdPGvouIOXowx1xU8nrBTqqfhIqqe0hElUHf739lFUZ4Dv6CenPXRIrpkUmrGt88CP/H0X3p44=@vger.kernel.org X-Gm-Message-State: AOJu0YwMaOna2V+AcUoeTti6wDmE+kVByRCdcJASAqRx94TGbc+XwYhX beeYJyHpq3TyTc/kKFqinN/t307thlIQzB9OX9dPDg+CPgK2WmypXQvS X-Gm-Gg: Acq92OFIwqJM7GTY0H1lJPC8TPUPWQoQxhVmPBwbyBXheQtKhe6xA70M9QYpH0uvwnD 5SzvihacXB8VWTFqpjfl00DJvObmycv8NcNIAt3M5Brv4+IGGfWorDdOo+0i+niEej0mpqz91SQ SWZhth9mJfHWW0yD0hAApoO/b5XIoLc0FXUhtxilJh1Jvbo7OAR5g15EgaGfA459A2/bg2xAeHw oPvBp6LgygVIBRxig5nCwQpu75jdJgLXpQN+CVUV4sjWUngySDXQSiz5gGLGLZ9cKFqWX9oYBVo Cs90sy+/kc673D9rIf2N1xVi4G9AxFh24oKWQqAMJmeV2YDqHJOI8sWl0CQFI3MorcvcdfuaIAF yKXxaSNwQapX6W6wEi0PdfFMhvAykxXwNjSKrxLTwaGMsXmQZ7Gj5nm/jdFx2Qggf89KiEQ3Ndm h6fgOCAqOTyPzhf02CRdDF/OYyvn2eQ4TnRU9YfoP0dVqo2MrPgfbTW4+r+w== X-Received: by 2002:a05:6871:c64f:20b0:435:ba1d:af1 with SMTP id 586e51a60fabf-435ba1d151emr233527fac.12.1778361562918; Sat, 09 May 2026 14:19:22 -0700 (PDT) Received: from linuxescape.lan (23-88-128-2.fttp.usinternet.com. [23.88.128.2]) by smtp.gmail.com with ESMTPSA id 586e51a60fabf-435573e6ec9sm5476581fac.15.2026.05.09.14.19.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 14:19:22 -0700 (PDT) From: Maxwell Doose To: jic23@kernel.org Cc: Tomasz Duszynski , David Lechner , =?UTF-8?q?Nuno=20S=C3=A1?= , Andy Shevchenko , linux-iio@vger.kernel.org (open list:IIO SUBSYSTEM AND DRIVERS), linux-kernel@vger.kernel.org (open list) Subject: [PATCH] iio: chemical: scd30: Prevent potential divide-by-zero error Date: Sat, 9 May 2026 16:19:20 -0500 Message-ID: <20260509211921.84969-1-m32285159@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In scd30_read_raw, the current value of tmp in the IIO_CHAN_INFO_SAMP_FREQ case is unchecked. Add checking to see if the value we got was 0 to prevent a divide-by-zero error. Fixes: 64b3d8b1b0f5 ("iio: chemical: scd30: add core driver") Signed-off-by: Maxwell Doose --- drivers/iio/chemical/scd30_core.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/drivers/iio/chemical/scd30_core.c b/drivers/iio/chemical/scd30_core.c index be8c055be184..3e2bb6f4e42c 100644 --- a/drivers/iio/chemical/scd30_core.c +++ b/drivers/iio/chemical/scd30_core.c @@ -237,6 +237,13 @@ static int scd30_read_raw(struct iio_dev *indio_dev, struct iio_chan_spec const if (ret) return ret; + /* Likely only taken if something really strange happens */ + if (!tmp) { + dev_err(&indio_dev->dev, + "Invalid measurement interval 0 received\n"); + return -EIO; + } + *val = 0; *val2 = 1000000000 / tmp; return IIO_VAL_INT_PLUS_NANO; -- 2.54.0