From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f41.google.com (mail-wm1-f41.google.com [209.85.128.41]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCFCA39C65F for ; Sat, 9 May 2026 21:50:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.41 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778363457; cv=none; b=CBvMFwjjq8GYRV0G4PIssMOckFi36kcHcAf3MnjpgdaFikbDD1BX9VeWPhtljpUaMcyQEexLiEOAg6ZAp8ETYT2V1C428rQcNMIbo0Ay/NGBUhLZpekLS05pTWoIL+9yc9uq4glPFD9blidMyaGKrTUACubJOB0LOwkBiHYMAA8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778363457; c=relaxed/simple; bh=zZ4zRaKGq3lXVJHzulsLNYmFoDhtm/d3hxn8G7IHlb8=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=ZHthmdfiD6017ucEeaMmgvlq8/oFJLxffrB+8OHNlJYIA+ga64HOnYVqXDT/WuSTbUd20aV2At5tavSMqi88I3f3PEukm6nPRYbtL/+JfUCUWsNL3PyMI+UtbDVd9Z4nczWGcuOuYebnE1HT6WS9xQLTLJwyyYo1H7jSQGsjb8k= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=QW32ZTS/; arc=none smtp.client-ip=209.85.128.41 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="QW32ZTS/" Received: by mail-wm1-f41.google.com with SMTP id 5b1f17b1804b1-48e6db3ff7eso5804575e9.0 for ; Sat, 09 May 2026 14:50:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778363451; x=1778968251; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=YvqluUKCfP5Ei1uU539utS8CTMy0nMi+hBfXFQXhHRY=; b=QW32ZTS/DAak+S0VHi54BQZ0fyp71bh2NvPX9fDbN4XLgZMeKd0oJ15sgh4gnKYvA5 vRbDayEUc2PtHZ1+oOvBJpTIoUQ0/LunOlYKvkO+5qexDjyPWx2e7Y5HmlzVR4r+qkTa Bhif+gBjUrUB0nRZtY1rvl2BBztlfsV5Uo4alYftiQqMqUTsqCjEnuX0+dF44y2T968R Gq+DWWnT8phNKHoT0+bb07kCsghjI0wipiRgF2LoqQMtYTksfK0fiuMHDWknn/w9Cgh6 0iySToaUXACAxpFTwHGFIvxfIDDjt6OvB2bp4CpssjcB4xc6pzsHnLJqkPkeum7jtEda ES3g== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778363451; x=1778968251; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=YvqluUKCfP5Ei1uU539utS8CTMy0nMi+hBfXFQXhHRY=; b=kQ8GmjakzQKbbM3oc/RBXqm4m+ZOOJ3XoPcmK5lqNgaRW2cqUlpjCG94IAliMLyI2N UfpIjF+ji5523ZxIvIwY2ig+/5zMW3Ds0ROwrUIUFvjVdug0cSWgCcg23IN1PuKVbpSv Mfag0/fZ+PE1x2PiGNKM5gsj//dtPLpkBFw0zuOAHztsK7f+JRpzjWpaPaibdD13mF00 8D13Cf+aizQLjdZ4ogiXjljwJBs3s5ecoRKuhzq2Y1zN8RIKRtv3vSJS4iDwVE1qDJyl o9PFqdJvQmuHpYMbFEldkFatBN7NODQOpYF/DCo5wco2Ssfo8Jxkl32mqBJ5O7ru5rHV bVtQ== X-Forwarded-Encrypted: i=1; AFNElJ+VHFM78nlxfadN0CAu0IqSy9cwmzVVA/VmfC2C5ATrsoLVkt4JSs4W04gI2H4W0K95IIVS2Nr06lhFhCs=@vger.kernel.org X-Gm-Message-State: AOJu0YyXablD/GEI/GUI8TOpwpkSf8ga6JdGXHTT8Vw0pEQFoU2wU1q2 KDkvvillz8MW5v7i1njnhzh/edSlHfZpdq/bOqZlTb63crQ1r81gCKtV X-Gm-Gg: Acq92OFf2zL97GBv/iT+FAFL1y53NX13IRrNdeVbIG5kUnPU2auFC1HckUKrzJJbT4k 7pWc7L14EQ2lRlxaZ2Fno6bp9tS90gJOQeolY5iexr2OusUuuaWHrHB7wscR8Z+us+1iCnlCB7T WiJkUAQ7emnidsDYeftbYnz9bjG58WwKJVYqtnwkt/4k7l+FfM0Z/3VjjCLUTQaSIMt9lOe2HE8 uRJ/wBczlFrpIZWEUacFdpWQddcl6Gz1rYqvPhcqzppfCqTj8OqO5Fg3k7QphN3QFjIj4Z4k7E+ YgkGSkyWMtRoW/10FoM+TFYvSFTd7fr0zzPuynCMXNF3RMlUSnk8IZWgpWsjaUU25pp7w9mUQLL xOGOrecfUFrdy4+iAIgUdR1lGygjVDCBc6OecqxpjIOgk20oeIh/eDKL/3al3k7qnblc7pkooZS ztJF2b4+2oGDOdZgk8cnvBQwK277HXkNHNaNBU+1y99c63LjdH0v0X9pgcgiDlF7v7JzXxEgf+c 2UxDjrrgYHA8htLSc2P/g== X-Received: by 2002:a05:600c:17d2:b0:485:ae14:8191 with SMTP id 5b1f17b1804b1-48e51e0a8b9mr172833435e9.5.1778363451396; Sat, 09 May 2026 14:50:51 -0700 (PDT) Received: from dohko.chello.ie (188-141-5-72.dynamic.upc.ie. [188.141.5.72]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e702ec426sm71076565e9.10.2026.05.09.14.50.50 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 14:50:51 -0700 (PDT) From: David Carlier To: Andrew Lunn , Heiner Kallweit , Jakub Kicinski , "David S . Miller" , Eric Dumazet , Paolo Abeni , Simon Horman Cc: Maxime Chevallier , Russell King , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org, David Carlier Subject: [PATCH net] net: ethtool: phy: avoid NULL deref when PHY driver is unbound Date: Sat, 9 May 2026 22:50:46 +0100 Message-ID: <20260509215046.107157-1-devnexen@gmail.com> X-Mailer: git-send-email 2.53.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit phydev->drv can become NULL while the phy_device is still attached to its net_device, namely after the PHY driver is unbound via sysfs: echo > /sys/bus/mdio_bus/drivers//unbind phy_remove() clears phydev->drv but doesn't call phy_detach(), so the phy_device stays in the link topology xarray and ethnl_req_get_phydev() still hands it back. ETHTOOL_MSG_PHY_GET then oopses on: rep_data->drvname = kstrdup(phydev->drv->name, GFP_KERNEL); drvname is already treated as optional by phy_reply_size(), phy_fill_reply() and phy_cleanup_data(), so just skip the allocation when there is no driver bound. Fixes: 9dd2ad5e92b9 ("net: ethtool: phy: Convert the PHY_GET command to generic phy dump") Cc: stable@vger.kernel.org # 6.13.x Signed-off-by: David Carlier --- net/ethtool/phy.c | 10 ++++++---- 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/net/ethtool/phy.c b/net/ethtool/phy.c index f76d94d848d6..ddc6eab701ed 100644 --- a/net/ethtool/phy.c +++ b/net/ethtool/phy.c @@ -94,10 +94,12 @@ static int phy_prepare_data(const struct ethnl_req_info *req_info, if (!rep_data->name) return -ENOMEM; - rep_data->drvname = kstrdup(phydev->drv->name, GFP_KERNEL); - if (!rep_data->drvname) { - ret = -ENOMEM; - goto err_free_name; + if (phydev->drv) { + rep_data->drvname = kstrdup(phydev->drv->name, GFP_KERNEL); + if (!rep_data->drvname) { + ret = -ENOMEM; + goto err_free_name; + } } rep_data->upstream_type = pdn->upstream_type; -- 2.53.0