From: Gunnar Kudrjavets <gunnarku@amazon.com>
To: <jarkko@kernel.org>
Cc: <gunnarku@amazon.com>, <jbouron@amazon.com>, <jgg@ziepe.ca>,
<linux-integrity@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<mhijaz@amazon.com>, <noodles@meta.com>, <peterhuewe@gmx.de>
Subject: Re: [PATCH v2] tpm: Fix uninitialized name_size_alg in tpm_buf_append_name()
Date: Sat, 9 May 2026 22:34:29 +0000 [thread overview]
Message-ID: <20260509223500.4390-1-gunnarku@amazon.com> (raw)
In-Reply-To: <af-MeEbJFmab4YQ8@kernel.org>
On Fri, May 09, 2026 at 07:35 PM Jarkko Sakkinen <jarkko@kernel.org> wrote:
> This is great observation but it is not a regression technically.
>
> Thus, this really should just state the issue and don't make it look
> like a bug report based on transcript that does not happen in the wild.
Thank you for the feedback, Jarkko. That's a fair point. Since no
in-tree caller exercises this path today, framing it as a regression
is misleading. I'm happy to rework the commit description to present
it as a proactive hardening fix rather than a bug report, and drop the
Fixes tag accordingly.
> I guess this is better than parameter removal since name caching would
> make sense [1] in future.
Agreed. Keeeping the name parameter functional makes the API ready
for name caching without further changes.
Would you prefer I resend with the adjusted description, or would you
like to suggest specific wording? Happy to go either way.
Gunnar
next prev parent reply other threads:[~2026-05-09 22:35 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-07 20:18 [PATCH] tpm: Fix uninitialized name_size_alg in tpm_buf_append_name() Gunnar Kudrjavets
2026-05-09 19:35 ` Jarkko Sakkinen
2026-05-09 22:34 ` Gunnar Kudrjavets [this message]
2026-05-10 1:42 ` [PATCH v2] " Jarkko Sakkinen
2026-05-10 17:11 ` [PATCH v2] tpm: Initialize name_size_alg for non-NULL name " Gunnar Kudrjavets
2026-05-10 18:26 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260509223500.4390-1-gunnarku@amazon.com \
--to=gunnarku@amazon.com \
--cc=jarkko@kernel.org \
--cc=jbouron@amazon.com \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mhijaz@amazon.com \
--cc=noodles@meta.com \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox