From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f172.google.com (mail-dy1-f172.google.com [74.125.82.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id A2FEB286D56 for ; Sun, 10 May 2026 04:25:52 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778387154; cv=none; b=oanuZrAEAmQC77TKj1cbRfuI0iGi/+VWfQNw+uCYFTyyvq8G/Y+AQxtwueWKtpcQM42ZgwH2aDPvBnKeSqRojOyv/EGWk7PRxOLtzOe/OYk1H47gGp4Sji5vbPmKFDzwm1DswWSUnYUHYoJk+qipgoD/1lIW7mxA7nT/celwXn4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778387154; c=relaxed/simple; bh=6uvm7kxcoZxl4SJop0VuYLP778pizJEeCY5iHUnRujE=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=N9SgD4X/INYVHLVKC4jhq97nROWcSqiyX8zLe7v8/m7vshOFBuXGnxXOqZW1MOR9g0hyHva+OYDaUB6jOdZFdxCoPSTBoz0xY89bCWbLURE2Fr+L+vBDc+4M4RnnqOgPY8OZRpaEz5HFJONNArF+c54v76GSVPQEkMoK8UUR13s= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=dms11K2j; arc=none smtp.client-ip=74.125.82.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="dms11K2j" Received: by mail-dy1-f172.google.com with SMTP id 5a478bee46e88-2f3c623322bso5361409eec.0 for ; Sat, 09 May 2026 21:25:52 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778387152; x=1778991952; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4ki2zpxXcCZiQ654Cm5JOUD1c7/Sq7YjZSIjBtyxJhk=; b=dms11K2jMcDfQbw8xdMgaYe88MJgln/XfhDTd4/L2OnwUbq0H623qiTK1lbl4pRsdN F72mDZcMBXNrIKGy6jTnlIJ8I4PhqZnH4vx0yckkCSbl3Byfd0sl5ia27rADR+0Kgriy ivoLDZDVTMC7DPwJVTkHw2EWgPC0er/Hc50zq1HGYNbCXE59GZwnVgYHF3RK/VJzpEzx JlJoCQWJMUoy6JZHpDHpkGy3FnrWcKAQzOxnxx1Jz0kM+qsoIZA16UwKqamof6DUb1yO CgCitzl/r3ax5m9jlEsX9ao6PTvKkr/tnmJtmvzyc6XiJV6NvGEn+rWgu4EOcm372eJ2 BVDg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778387152; x=1778991952; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4ki2zpxXcCZiQ654Cm5JOUD1c7/Sq7YjZSIjBtyxJhk=; b=FBIKuCfePIx/6UnzOMP41zj+VMDn+BXNX2jjWOiK+57yghKIpwl5tk1aAgI73x3Rn9 whwQ/blJyVNLaWjkM1LPwZfyeKklU8YbylzAeu0zBwCYvhDt6GEfpe/bd5sy7e5mQCjN /Qk+LRzjozdzQjgUAeNZ23LP1XEUbBWWdcr1XygNJHD0LH+E/NOBZep2PPjWkoU09xJB h6MYNpuZfCVIKVL+7qFdygyvKR+ZQjuVHqctoIqm62a95PIhZKyifypbbyF+xLR6fQW9 NQCeEky/Cxco2GWNwWDEeDPSli5nVxF2dlnLmDGobeUP2arSn5Gjafe1gfZXK2TULuPb AUew== X-Forwarded-Encrypted: i=1; AFNElJ8gErRJ/ssdhChcW2ap0Z9ayYuFmMU9/JVUo+fbTNhYnRC9i5OqVd6RX6JL0Ub+5+1pBHsSXQqTk/PdPKA=@vger.kernel.org X-Gm-Message-State: AOJu0Yy0PSNzuMGgFL90nvZpDm/MZPpJ1UT+sdDws5u3znPdzy5W5yUA TFNnt5OURrrS2XAzXZmKiVMmNNp5TSMQdzHMKwxv4DXmYhy5coB9vql1 X-Gm-Gg: Acq92OFse5nce/FTjT7u0XSfk/AWYNRKAUkExt4kQdbZ8nFsfVoptZns02UFQuwTvRM FJ4q9DLDg5LNOUxfw7t/SLojTr4gSN/OaNNnN2Xi6/nn9D/QjfwVnTUCBjsKLc/33Kjgrgvcmlx P8LSEf2Yuifns+CQkU6AGUdD4gVH/ARM9qzHV4HC/MuCyd5WAa0gbwAoXNOzSXQ717wZyu2RVTw Zq94R1HntHo1/02wTWHFzFj8hNdxwHShlTdDca/fnqmWPMAeLYJrUhnoBxWNjFh7F0sWPCc+f1w +pQmqVusq6ik8oEhwIZV364sEG/FHyv7K4vc4PLZ6O6I3fS6cqqVpW4OdnJVLMuw42Fa/yKw2NH RKBpL/Z6fcXPQZgnLDP2jwqYQevWJjrPK3fFFwbh7pII5q07+FPQEfWyaHos6KWoXPNiQdjtWLW faOg6Hyq85L7lbouJdc2e9pVV8yhvY8f2B5xH6CK9AJP8mzV+iuIJEpY+imIZTULPlIvVDq6BM8 BQD X-Received: by 2002:a05:7300:434b:b0:2ce:3aa1:d39b with SMTP id 5a478bee46e88-2f54c97128bmr9262664eec.20.1778387151815; Sat, 09 May 2026 21:25:51 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d3047sm10069960eec.10.2026.05.09.21.25.51 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 21:25:51 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , "Pierre-Loup A . Griffais" , =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , marshall@shzj.cc, hyacinth@shzj.cc, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v12 03/16] platform/x86: lenovo-wmi-other: Balance component bind and unbind Date: Sun, 10 May 2026 04:25:33 +0000 Message-ID: <20260510042546.436874-4-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260510042546.436874-1-derekjohn.clark@gmail.com> References: <20260510042546.436874-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit From: Rong Zhang When lwmi_om_master_bind() fails, the master device's components are left bound, with the aggregate device destroyed due to the failure (found by sashiko.dev [1]). Balance calls to component_bind_all() and component_unbind_all() when an error is propagated to the component framework. No functional change intended. Reviewed-by: Mark Pearson Reviewed-by: Ilpo Järvinen Fixes: edc4b183b794 ("platform/x86: Add Lenovo Other Mode WMI Driver") Cc: stable@vger.kernel.org Link: https://sashiko.dev/#/patchset/20260331181208.421552-1-derekjohn.clark%40gmail.com [1] Signed-off-by: Rong Zhang Signed-off-by: Derek J. Clark --- drivers/platform/x86/lenovo/wmi-other.c | 5 ++++- 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c index be3309d74e03..a6be3463341c 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -1068,8 +1068,11 @@ static int lwmi_om_master_bind(struct device *dev) priv->cd00_list = binder.cd00_list; priv->cd01_list = binder.cd01_list; - if (!priv->cd00_list || !priv->cd01_list) + if (!priv->cd00_list || !priv->cd01_list) { + component_unbind_all(dev, NULL); + return -ENODEV; + } lwmi_om_fan_info_collect_cd00(priv); -- 2.53.0