From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dl1-f43.google.com (mail-dl1-f43.google.com [74.125.82.43]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 86143299937 for ; Sun, 10 May 2026 04:25:54 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.43 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778387156; cv=none; b=dWOg1AG6QniWktDXjHQShOUhnbuSN/Y3T1oGA+hyC/10gBx9ecRDt8jmlsQ9hMBPF051R3KRgmG8nJstEZXu/VICgxTxyYDTA7jldOHVXILUqzn5ALjrj6FQXs2ARlVO/cSBIyWZm3jlSTaTljryBAwo69xjBEezvcgCSFjQQus= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778387156; c=relaxed/simple; bh=Tk/2aJhhC1s684/DYFLDntYmRO/aqAyYK0+/EXewrns=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=GozyGyJPubGilNaf8dA+VFBODERmyRBGgr6UwD37y+yiKufGOkagBeJQ3MlpX1dIGNXMFVA//eNe8kHQnY5AkMlXW7d5GMiIfCY93jeyB3qWaPAOjSxxN0d/S3RIUI6XtlZU3bCxjLbu0m4iewhDb3miXDfEwd0oKz9+oC/zg9Y= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=F4yqSHb5; arc=none smtp.client-ip=74.125.82.43 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="F4yqSHb5" Received: by mail-dl1-f43.google.com with SMTP id a92af1059eb24-1329507c387so4040290c88.1 for ; Sat, 09 May 2026 21:25:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778387154; x=1778991954; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=4+i5mv8Vqi4F1/QxRhQ01iidaQ4oFBJaEVmCvLgpSXI=; b=F4yqSHb5Ndk+NeL4fWDRY4HOAtYUIex+1HQVhZWD0aT29e82OxWT1kZfVPLQlnwygG YqNhjI37mNkXdHWM/tjcQlA3Eppdz5+R5oif22VqjEnDfC64LNQmOVFdnclWJDRShHpO AdAWQQelW2+7qcXDkvs3KifSBpPDJfTL37RI9mfo9wnEY8itVRzmZcMmwipmaE7W622r mCvdG5ZPxtdzXe2r1923NluYeMi6d5DSikkBQ7YyaFjwLKZdRYzqGvlkpNrG2zKap17e xOMfq41S0uwfWhcl5U/0kzXwVhG/wwfoKoBs58uH5ycRIDS6DhgDnFWq/eTVUtHlPYOn 8SRg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778387154; x=1778991954; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=4+i5mv8Vqi4F1/QxRhQ01iidaQ4oFBJaEVmCvLgpSXI=; b=K3sE0TOnnaxkdoioYlwWo2nQOxjOsiytZjdeTCf129iPlRaYGF8TkZpAdsNLV+a5uy HK4VvsRcnQQnNAL2ASjRrWiyRTi9YEkADULC7ijW5jah2Iu7Wu2FQ8TFEIfIy8Sw+eTs WiXyV/K+n91YF2pgUTTXghgjfSG6Vehitp/V/DbB3fk2GALgbxnl60tn2fOZNTw5Ka50 ujRmBYaPogfXNOb9OsE27T6ZEmlBbtS7i/Dvg/6JfUu4UzkJ+BvyfR6IuDEj5FbKsZX6 1ZLIc7uuVtgkIOesjbW8jfamMfSadG+VrQOtidps9KWdtgwxf/pz7IE26QcHKkTUsdzy QSrQ== X-Forwarded-Encrypted: i=1; AFNElJ8ry5sj2N/EidpuD6kkPA+Qn41ZGksJD48knCEZE4bqrFABjZ2JYcf1Q48Y0F0X4SY5vNiEOYpWFeohF/s=@vger.kernel.org X-Gm-Message-State: AOJu0Yw6TYSG8jJnVIUEfXFCV7LassdfU8tpxJSms0EyXqji/zs66E2K z7JypbpLEqBpsSQTviFJtGispXfH2hN1luA3o48GrXWgNPKXj1Z/0GfK X-Gm-Gg: Acq92OHXhyXpvUzWITaSxMeZIHr02TnAomgG/wrCnb2dE3PT1iNR7Ul8youR6KwRfwJ 6zA5xqv0lX3sCHHejaS1KZ9aPvo307l19zUlmrl93q0/WpMex1UiTgFMKFpBwYBPO0pg5B46QY4 ZxWK7+oEUhzbeOcVxI7GcVRIgFT2PdMLkZCsGyzfjf974V1PAiWV8EvxfVBitharPnNVsek1vJ3 6MRG9GdZzU3JzKU6Ndf7uzkupPuK+bJ6CzUbzt6zVUfjU38pwGKJkOFAwojHT4OHnl6JIF8ePi6 LpU6GJBpHPNyuSwnvrpijZpvhhWer4VOnx+hSS8rqxpYhT39vKF8h9JX4qM8GnXOpiD3eJbKeQo 96yOHZiikv2vZ8yp5j1D/fC6cHrJ7kwv+293Hh/olzt6DOX4LQUuOJw2qXV18RoGipTTBSgd1p5 49BwT8PvpFarhZGJ+Ou6Kire/Ig1jGU2Gts6j/s/3byKhh/HFuUWU8scVwufGzlSMGSvtVT442I 8tJuZ6iU0g0v3JmxJN8XUvsbw== X-Received: by 2002:a05:7300:6ca8:b0:2f5:3641:f110 with SMTP id 5a478bee46e88-2f54d790853mr9736990eec.31.1778387153587; Sat, 09 May 2026 21:25:53 -0700 (PDT) Received: from lappy (108-228-232-20.lightspeed.sndgca.sbcglobal.net. [108.228.232.20]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2f8862d3047sm10069960eec.10.2026.05.09.21.25.52 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sat, 09 May 2026 21:25:53 -0700 (PDT) From: "Derek J. Clark" To: =?UTF-8?q?Ilpo=20J=C3=A4rvinen?= , Hans de Goede Cc: Mark Pearson , Armin Wolf , Jonathan Corbet , Rong Zhang , Kurt Borja , "Derek J . Clark" , "Pierre-Loup A . Griffais" , =?UTF-8?q?N=C3=ADcolas=20F=20=2E=20R=20=2E=20A=20=2E=20Prado?= , marshall@shzj.cc, hyacinth@shzj.cc, platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: [PATCH v12 05/16] platform/x86: lenovo-wmi-other: Fix tunable_attr_01 struct members Date: Sun, 10 May 2026 04:25:35 +0000 Message-ID: <20260510042546.436874-6-derekjohn.clark@gmail.com> X-Mailer: git-send-email 2.53.0 In-Reply-To: <20260510042546.436874-1-derekjohn.clark@gmail.com> References: <20260510042546.436874-1-derekjohn.clark@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit In struct tunable_attr_01 the capdata pointer is unused and the size of the id members is u32 when it should be u8. Fix these prior to adding additional members. No functional change intended. Reviewed-by: Mark Pearson Cc: stable@vger.kernel.org Reviewed-by: Rong Zhang Tested-by: Rong Zhang Signed-off-by: Derek J. Clark --- v12: - Drop fixes tag in formatting only patch. --- drivers/platform/x86/lenovo/wmi-other.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/platform/x86/lenovo/wmi-other.c b/drivers/platform/x86/lenovo/wmi-other.c index 1e06b894cfcc..50a03f5fd6ab 100644 --- a/drivers/platform/x86/lenovo/wmi-other.c +++ b/drivers/platform/x86/lenovo/wmi-other.c @@ -546,11 +546,10 @@ static void lwmi_om_fan_info_collect_cd_fan(struct device *dev, struct cd_list * /* ======== fw_attributes (component: lenovo-wmi-capdata 01) ======== */ struct tunable_attr_01 { - struct capdata01 *capdata; struct device *dev; - u32 feature_id; - u32 device_id; - u32 type_id; + u8 feature_id; + u8 device_id; + u8 type_id; }; static struct tunable_attr_01 ppt_pl1_spl = { -- 2.53.0