From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f201.google.com (mail-pl1-f201.google.com [209.85.214.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 075B41AF0BB for ; Sun, 10 May 2026 05:50:41 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778392243; cv=none; b=JxQhcpSgQ0lKYC61JHRzdD1nfKZ3lyg9N14RmWxxcW+KwDluN7vws9DiY1BESM74Fux5bqaNAql734hQ6ENcLCfSaUiYCh1em+U45f0UTTK+Aw9/DBwTdnaplNaecCLEN5Fq3mjehN8I/AZsas5Z39O6NtbUxTrezL2AQkamlrI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778392243; c=relaxed/simple; bh=XL+vINExhFuMQTTP70V6I3aF4N0+NgyPBdsvLAORuQk=; h=Date:In-Reply-To:Mime-Version:References:Message-ID:Subject:From: To:Cc:Content-Type; b=VRyYFDXZlB9AqsK5el4fu7aqY59gjGHFvk+PgwUQiNxlQekgYcWvhSUPxwgMeHavjTvP155z7djRnqmdzihzmUcFxPTGifK2mQ57iSwaGgmEVHxS9bAPFjACV/up3IQKTZOvham4biCrUvwLWMwLApgom2RyxJTwdljJeZCNW7I= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=NfTe331j; arc=none smtp.client-ip=209.85.214.201 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=flex--joonwonkang.bounces.google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="NfTe331j" Received: by mail-pl1-f201.google.com with SMTP id d9443c01a7336-2ba6fe41283so39678265ad.1 for ; Sat, 09 May 2026 22:50:41 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1778392241; x=1778997041; darn=vger.kernel.org; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:from:to:cc:subject:date:message-id:reply-to; bh=kzZRn2JWPQtIOhL+COPBbPzW8EvBz5JnXb+/L/c5we4=; b=NfTe331j3/0S8EF/GYhmVozvEoD65S7lkyOMaowt9XKA+1ZhQzJVINYpmFufZPMjyM I594OLTh3KEi04c/EzPKcoF+NAmU7CNWnGjpgH49AkRIQ3EIOVPZni6IWb06QG4fCm8u 7lyxH0sQAUJro7CywGUEJ7HehUqBOBf+Fvx0QtA+dP3C3DVsR3hKZ/rSMlme+WyAK8mB v5XIZ27WyxgxWf8r4mXHGMqd86gt3xdz+u9HwHD2MQOTGKbzZ9TgrYvTLb9JMEhfiB1f sBHVOkgNLga+Traf3+XNXjUqMiBqUOS5hrNJpw+w/psncb6rXGvM+u8ueilFx0R+K7TV QoTQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778392241; x=1778997041; h=cc:to:from:subject:message-id:references:mime-version:in-reply-to :date:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=kzZRn2JWPQtIOhL+COPBbPzW8EvBz5JnXb+/L/c5we4=; b=WO1Rny3/cJ9cvc0wHuKex0N0WeFpdmfkTIyUUsmhe6wrn8cg2uuv0jzp63z9jSEsix +DBfqitTjtLTOQdEoKf4k5t3nTGjxn2+1Gx3BUrJZ8lI8oYq9Dwx8fFSVcDjjQ0huWbX OdfLDwv+91HPLXHLMqAlQIBwD6ahtACq9xON93/UGo87f66GDaWOFXp8Mc9gjVnqPIoy Z0Xpgwq3PLopyr4WnZT9ihibD/z9JxTimTKyztlZ7MI+PRMu05PllrjrWsUWpHFOdXXl UpDmDa8wtnFxV8T7jY0md94RBARy5WMwr7Vj3/xrFwg0QPSN7hlunIKJ9fhIAk/vu3Is Hvug== X-Forwarded-Encrypted: i=1; AFNElJ/f31hB0yemMdZnGUF2TH6ZaLktLHGFG7nydQOZKRmD+SbuZK1oTPxLWXr7HdUb2XVaAPXyx6omPB0UN5w=@vger.kernel.org X-Gm-Message-State: AOJu0Yycng/4+s20AwdcDfjddpxxqHvEBnKrQEhKfnVoCyuOgYjrvw2B WNsyU05R0d5g9PcVxlyc2AQ89Ei+yPVzAqyl0OxSUcwM2ju2mP327J+dMYPHTPveGcnt/uIdiQF XvCYeQqF0WnavR42Eb72V9OTdTw== X-Received: from pllj9.prod.google.com ([2002:a17:902:7589:b0:2b2:5092:b66e]) (user=joonwonkang job=prod-delivery.src-stubby-dispatcher) by 2002:a17:903:13ce:b0:2bc:7d5d:e2b7 with SMTP id d9443c01a7336-2bc7d5de4ffmr45251655ad.36.1778392241199; Sat, 09 May 2026 22:50:41 -0700 (PDT) Date: Sun, 10 May 2026 05:50:39 +0000 In-Reply-To: <20260509015927.agent5-0002@kernel.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: Mime-Version: 1.0 References: <20260509015927.agent5-0002@kernel.org> X-Mailer: git-send-email 2.54.0.563.g4f69b47b94-goog Message-ID: <20260510055039.793085-1-joonwonkang@google.com> Subject: Re: [PATCH 6.18.y] mailbox: Fix NULL message support in mbox_send_message() From: Joonwon Kang To: sashal@kernel.org Cc: dianders@chromium.org, jassisinghbrar@gmail.com, jonathanh@nvidia.com, joonwonkang@google.com, linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, linux-tegra@vger.kernel.org, stable@vger.kernel.org, sudeep.holla@arm.com, thierry.reding@gmail.com Content-Type: text/plain; charset="UTF-8" > On Thu, May 07, 2026 at 06:21:07AM +0000, Joonwon Kang wrote: > > diff --git a/drivers/mailbox/pcc.c b/drivers/mailbox/pcc.c > > index ff292b9e0be9..7a2baeca2ba4 100644 > > --- a/drivers/mailbox/pcc.c > > +++ b/drivers/mailbox/pcc.c > > @@ -361,7 +361,7 @@ static irqreturn_t pcc_mbox_irq(int irq, void *p) > > if (pchan->chan.rx_alloc) > > handle = write_response(pchan); > > > > - if (chan->active_req) { > > + if (chan->active_req != MBOX_NO_MSG) { > > pcc_header = chan->active_req; > > if (pcc_header->flags & PCC_CMD_COMPLETION_NOTIFY) > > mbox_chan_txdone(chan, 0); > > This pcc.c hunk does not apply on 6.18.y: commit 5378bdf6a611 ("mailbox/pcc: > support mailbox management of the shared buffer") was reverted upstream by > f82c3e62b6b8, and that revert is already queued in 6.18 as 2cafad617431. > write_response() and the active_req-driven txdone path no longer exist in > pcc_mbox_irq() on 6.18, so this hunk is both syntactically inapplicable and > semantically unnecessary. > Indeed. Thanks for letting me know of this. My local environment was quite a bit behind the latest. > Could you send a v2 omitting the pcc.c hunk? The other three hunks > (mailbox.c, tegra-hsp.c, mailbox_controller.h) apply cleanly and I'm > happy to queue those for 6.18.y. Sure, I will send a new version. Thanks, Joonwon Kang