Re: [PATCH] cpufreq: cppc: Add update_limits support for Highest Performance changes

[kernel test robot <lkp@intel.com>]

Hi Xueqin,

kernel test robot noticed the following build errors:

[auto build test ERROR on rafael-pm/linux-next]
[also build test ERROR on rafael-pm/bleeding-edge linus/master v7.1-rc2 next-20260508]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Xueqin-Luo/cpufreq-cppc-Add-update_limits-support-for-Highest-Performance-changes/20260510-093030
base:   https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git linux-next
patch link:    https://lore.kernel.org/r/20260508111932.185886-3-luoxueqin%40kylinos.cn
patch subject: [PATCH] cpufreq: cppc: Add update_limits support for Highest Performance changes
config: riscv-randconfig-002-20260510 (https://download.01.org/0day-ci/archive/20260510/202605101404.fqz0MXIe-lkp@intel.com/config)
compiler: clang version 23.0.0git (https://github.com/llvm/llvm-project 5bac06718f502014fade905512f1d26d578a18f3)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20260510/202605101404.fqz0MXIe-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202605101404.fqz0MXIe-lkp@intel.com/

All error/warnings (new ones prefixed by >>):

>> drivers/cpufreq/cppc_cpufreq.c:857:43: error: incompatible pointer types passing 'u32 *' (aka 'unsigned int *') to parameter of type 'u64 *' (aka 'unsigned long long *') [-Wincompatible-pointer-types]
     857 |         ret = cppc_get_highest_perf(policy->cpu, &highest_perf);
         |                                                  ^~~~~~~~~~~~~
   include/acpi/cppc_acpi.h:157:51: note: passing argument to parameter 'highest_perf' here
     157 | extern int cppc_get_highest_perf(int cpunum, u64 *highest_perf);
         |                                                   ^
>> drivers/cpufreq/cppc_cpufreq.c:882:3: error: call to undeclared function 'cppc_cpufreq_set_autonomous_perf'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
     882 |                 cppc_cpufreq_set_autonomous_perf(policy);
         |                 ^
>> drivers/cpufreq/cppc_cpufreq.c:886:4: warning: format specifies type 'unsigned long long' but the argument has type 'u32' (aka 'unsigned int') [-Wformat]
     884 |         pr_debug("CPU%d: highest_perf updated %llu -> %llu\n",
         |                                               ~~~~
         |                                               %u
     885 |                  policy->cpu,
     886 |                  prev_highest_perf,
         |                  ^~~~~~~~~~~~~~~~~
   include/linux/printk.h:641:38: note: expanded from macro 'pr_debug'
     641 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
         |                                     ~~~     ^~~~~~~~~~~
   include/linux/printk.h:134:18: note: expanded from macro 'no_printk'
     134 |                 _printk(fmt, ##__VA_ARGS__);            \
         |                         ~~~    ^~~~~~~~~~~
   drivers/cpufreq/cppc_cpufreq.c:887:4: warning: format specifies type 'unsigned long long' but the argument has type 'u32' (aka 'unsigned int') [-Wformat]
     884 |         pr_debug("CPU%d: highest_perf updated %llu -> %llu\n",
         |                                                       ~~~~
         |                                                       %u
     885 |                  policy->cpu,
     886 |                  prev_highest_perf,
     887 |                  highest_perf);
         |                  ^~~~~~~~~~~~
   include/linux/printk.h:641:38: note: expanded from macro 'pr_debug'
     641 |         no_printk(KERN_DEBUG pr_fmt(fmt), ##__VA_ARGS__)
         |                                     ~~~     ^~~~~~~~~~~
   include/linux/printk.h:134:18: note: expanded from macro 'no_printk'
     134 |                 _printk(fmt, ##__VA_ARGS__);            \
         |                         ~~~    ^~~~~~~~~~~
   2 warnings and 2 errors generated.


vim +857 drivers/cpufreq/cppc_cpufreq.c

   845	
   846	static void cppc_cpufreq_update_limits(struct cpufreq_policy *policy)
   847	{
   848		struct cppc_cpudata *cpu_data = policy->driver_data;
   849		u32 prev_highest_perf;
   850		u32 highest_perf;
   851		int ret;
   852	
   853		guard(cpufreq_policy_write)(policy);
   854	
   855		prev_highest_perf = cpu_data->perf_caps.highest_perf;
   856	
 > 857		ret = cppc_get_highest_perf(policy->cpu, &highest_perf);
   858		if (ret)
   859			return;
   860	
   861		if (highest_perf == prev_highest_perf)
   862			return;
   863	
   864		cpu_data->perf_caps.highest_perf = highest_perf;
   865		if (cpu_data->perf_caps.nominal_perf > highest_perf)
   866			cpu_data->perf_caps.nominal_perf = highest_perf;
   867	
   868		policy->max = cppc_perf_to_khz(&cpu_data->perf_caps,
   869				policy->boost_enabled ?
   870				highest_perf :
   871				cpu_data->perf_caps.nominal_perf);
   872	
   873		policy->cpuinfo.max_freq = policy->max;
   874	
   875		/*
   876		 * Autonomous selection mode uses MIN/MAX performance as runtime
   877		 * hardware control bounds.
   878		 *
   879		 * Re-program them when highest_perf changes.
   880		 */
   881		if (cpu_data->perf_ctrls.auto_sel)
 > 882			cppc_cpufreq_set_autonomous_perf(policy);
   883	
   884		pr_debug("CPU%d: highest_perf updated %llu -> %llu\n",
   885			 policy->cpu,
 > 886			 prev_highest_perf,
   887			 highest_perf);
   888	}
   889	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki