From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wm1-f50.google.com (mail-wm1-f50.google.com [209.85.128.50]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D1D913FF1 for ; Sun, 10 May 2026 16:30:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.128.50 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778430630; cv=none; b=jZve9OMUnr1a9qkcje5mkmyuURUOJU2M6k7wEO/+ZAADOyXxEt98Dzmqkkq8If82hhpC4D5TA+j1cjHN5TLqZY/XMmG2Yllds/U/nCOojqrW18ekLypk57H/wdMEfZmA8Jetw3N/o7RfS5zO4DPTbV0tQ6NTdR8of0euB3Zl8Bg= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778430630; c=relaxed/simple; bh=lmbCQr58FaBWfDQWGL3s9gx614McebkkHoCivon3Fkk=; h=From:To:Subject:Date:Message-ID:MIME-Version; b=r2A0y3MONweZhcUDFSDMwfj6OBPOTsELS9ozLM9MUWmzHtHbDba80Jcld5RtGMK12PZImtmbS1dm4bB2mmFl9BLeySJFB3iC1y+1Lmt3RSW2RZaLGhWOJCoAQfO31cd/0zVAdOcpcCWsvhUuhWGlBcZmNTmzsfHA47BhrZXwwqI= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=NqSIitp2; arc=none smtp.client-ip=209.85.128.50 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NqSIitp2" Received: by mail-wm1-f50.google.com with SMTP id 5b1f17b1804b1-48984d29fe3so38521175e9.0 for ; Sun, 10 May 2026 09:30:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778430627; x=1779035427; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:from:to:cc:subject:date:message-id:reply-to; bh=He4B1KwYa6va3akEchflA6TfkGWI7BelAApRMUKrFY0=; b=NqSIitp25VqNf1djtm6jcRv8hRrdENvfB4bDKTS32CRT99vKjTw8atoBlk4CXHahOZ 5fffmgtglxIc1hQMXHGFxXz04pUpri4gG17aOUNEmQo+bNFPlyCEDHzs2P9u9RRXX3y5 OqkRyIaLPYd6gyIqLID+d9XhgZbeOIufnDNKxGpGkZhPjz4yqlFNjeHQvhpoV/f381e+ 9vJFWXOmoiQaxEFR7GHUp8de54XSGQQHnzOyNfX2Qx+4q9gPkK+4pW2sfhzzKCrQBbYv 8L0Kg3dA6KHlqeNx1vS0lhv+SaU4rjsL1uekngnhSvYT4Deq/B8gU/siPKTyUR1TE3Vf HIkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778430627; x=1779035427; h=content-transfer-encoding:mime-version:message-id:date:subject:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=He4B1KwYa6va3akEchflA6TfkGWI7BelAApRMUKrFY0=; b=Z4RJneFTyJOOIam/If9HcMuQrw2peysyh2XUnqctVBTgZLWAHuFM4IzqLNG/bMm1cE Gp6ZhE54nB0Y72KnZbNPEHIMq+9It8C8uRcdvkUmwb85et0brog4FHInJYzZnzpKCWGP BSzNmtGLuyct+tyGSsS88pausEv7jfeIWu2ONONO0DzyHMK3VACq56hi//mdIYNARGzR o7E5iSzDK3CKrutmGcJehstAt1c4aPKUK/al2hbFlv0ZKcXgkqHA4I4vLz9hcozdLMnB D3MlF5TEsKasr+7oOkmPUWxgUMUuWvEKW8UHetaRTqLCk63AK4NTBsGmpKLXn5JIg0Ze xCdw== X-Forwarded-Encrypted: i=1; AFNElJ9cegVVFIWQgxsD/b8m6cRgIXYQ9mo16QIogd+4Wdwzq1UBm+YX1USu8DlY8yMIdpkT60JZL+jmktx99WY=@vger.kernel.org X-Gm-Message-State: AOJu0Yzt75QFWIABjXsM0CuzOf3Zy2Uhf+4ivDAA/yJ6k+IKpcOfX7k3 b7DS8mgXVEXjKHIMO8uRjWDhR12v+tTjuDSTqnOUri7uQ9jbne6LRlb+ X-Gm-Gg: Acq92OHy+36nND9OK+uhDeVrzlfL5JBm/HWiSGgFlH90tUogtreOchyO3fZYGUpiGqt FPMYFCqjx019JOrDwj5Dd4nPn6d/U5bkey0uIwZkTgd5VbsFcwKiXtUVdJ2A4KDkS77bsdoHiqc 8nAsJB74O1+69XoxJIGM7NKxWrMiykCeTv9xrSDVkFwNNONiAk/HGQzjI8NhslPtyNfcmEALAs8 be3N6nfvgxj+BzZ1o1LP/D6hzY9S8Hg98Fi0BYGHN8BEKamQEPxLvWOrMI8EqqlTYXJ4KBj/pPA o1v1vThr47vE1LNs6sn8Qj3Lwj5I8tqz6ezthoQ6yZ/sAPP+KaItjb8+RhC7bysu++oBFTLQiiM mGXdIoVkx2q+WyFnvJXX6oenPYnHOWTNtgb7U+fLdTLufV/Rpc1C3m9Q+ezg0h2NsdlT25qa4pn GdGg/EQWpQ6LNW8sEnjCWUGzlQxGJEhaDCzfAwQw02lZDUwa7P24pUYIG4LepR X-Received: by 2002:a05:600c:c11c:b0:48a:52f2:a0f1 with SMTP id 5b1f17b1804b1-48e51f46d48mr238026445e9.18.1778430626919; Sun, 10 May 2026 09:30:26 -0700 (PDT) Received: from osama.. ([2a02:908:1b6:8980:13f8:e1fa:3829:74f9]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6daf911asm67627755e9.5.2026.05.10.09.30.25 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 09:30:26 -0700 (PDT) From: Osama Abdelkader To: bartosz.golaszewski@oss.qualcomm.com, Ulf Hansson , Huacai Chen , Pedro Demarchi Gomes , Jisheng Zhang , Binbin Zhou , Colin Ian King , Osama Abdelkader , linux-mmc@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] mmc: davinci: fix mmc_add_host order in probe Date: Sun, 10 May 2026 18:29:39 +0200 Message-ID: <20260510162941.704940-1-osama.abdelkader@gmail.com> X-Mailer: git-send-email 2.43.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit mmc_add_host() makes the host visible to the MMC core. Register the interrupt handlers and advertise MMC_CAP_SDIO_IRQ before that, so the core cannot start using the host before IRQ handling is set up. Signed-off-by: Osama Abdelkader --- drivers/mmc/host/davinci_mmc.c | 12 +++++------- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/drivers/mmc/host/davinci_mmc.c b/drivers/mmc/host/davinci_mmc.c index 42b0118a45a8..a598febe7332 100644 --- a/drivers/mmc/host/davinci_mmc.c +++ b/drivers/mmc/host/davinci_mmc.c @@ -1294,14 +1294,10 @@ static int davinci_mmcsd_probe(struct platform_device *pdev) goto cpu_freq_fail; } - ret = mmc_add_host(mmc); - if (ret < 0) - goto mmc_add_host_fail; - ret = devm_request_irq(&pdev->dev, irq, mmc_davinci_irq, 0, mmc_hostname(mmc), host); if (ret) - goto request_irq_fail; + goto mmc_add_host_fail; if (host->sdio_irq >= 0) { ret = devm_request_irq(&pdev->dev, host->sdio_irq, @@ -1311,6 +1307,10 @@ static int davinci_mmcsd_probe(struct platform_device *pdev) mmc->caps |= MMC_CAP_SDIO_IRQ; } + ret = mmc_add_host(mmc); + if (ret < 0) + goto mmc_add_host_fail; + rename_region(mem, mmc_hostname(mmc)); if (mmc->caps & MMC_CAP_8_BIT_DATA) @@ -1324,8 +1324,6 @@ static int davinci_mmcsd_probe(struct platform_device *pdev) return 0; -request_irq_fail: - mmc_remove_host(mmc); mmc_add_host_fail: mmc_davinci_cpufreq_deregister(host); cpu_freq_fail: -- 2.43.0