From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f176.google.com (mail-pl1-f176.google.com [209.85.214.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AE7093B47CD for ; Sun, 10 May 2026 17:11:26 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778433087; cv=none; b=lI1ZVA4bAMef7ylgwPr54PItGe/MdCt5E8rbr6D3JStJp11W5jOimwySG6jkuCFF8E7rtOXDkhlJa0HKzv0RA/50Iijq+vORsDY5Tjp5PwlpI9N7e08YkdWjXd5bQPbwQqRVr5FPM9T2sCvb6s6Elyk/u2ih/Ia+T3pU7+R+xDA= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778433087; c=relaxed/simple; bh=J0UVZS/j22fmCq/e+oGynnmq3o9/DGb8VlFN8JoeF0s=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=PlgWadRjl54Cj0lVGHJqwJKTmlzEZR0oSQCtuXT6IqewYXWIhNj0MPsbS/x5qUyH9MAYYnTJNEweEp3giaPJoQrBNLyyr6RZLvGNTP3+kQWSTqvAILNwcOzNayeGR/Spbvoi2lFs3Bl/c3I5tiNfuB+gxJPOhRqfMFm7/ND2koQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=ftYOohDA; arc=none smtp.client-ip=209.85.214.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="ftYOohDA" Received: by mail-pl1-f176.google.com with SMTP id d9443c01a7336-2bc6e4556d8so3170915ad.1 for ; Sun, 10 May 2026 10:11:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778433086; x=1779037886; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=PXD7XPslQy4RCgTc1Odfr77PlnVHB0PjTBKNtAuamEw=; b=ftYOohDAw/PZFAqCPCyetzrHRhI5wRzYacHFrjEolDcczVoYg5w0sPAL78qY5XSXiK 2qivVzZj+aKhQjc6Rd3612iaEq0duds+QQGOvSI94MrFDPRCkVRXvrEncBSK3wisTmQA +fmiM2/FBEMhS62fL0ynPO7+UFVxB+hx3DQXf7k8wETn8hsQYH63Wbz3QB9y1mUs+47i g43MX5eD2eMUkJYAPuOixCiOebioEq2w/tVx8dfH77VGgxpkkdLH2I6WjMfk+IgnZj+J T3f5XsEP3FYCxVPkPnmTc4g/X5+2hRUu98unmeWiWhNO4uQDIJyXa49YeWj3bLht7LMZ XCTw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778433086; x=1779037886; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=PXD7XPslQy4RCgTc1Odfr77PlnVHB0PjTBKNtAuamEw=; b=FGL8xvDZ6UW94fkXdBKJ0Y25qhORldStux1dd0vsLMcUZJ25FnfzRNmRataphXi5Px HT9P723Kd+bIySG0+gqa2IWSYQk36mQHCjfs4JyT+pAPIOfRxMGXvLG/y8SBaL8q1sz2 GtB+T784+DoY5kuC3xsEBmzS2EHYrNRq8vnkGF8n9RvcqsUaY+zeCUpTEWnNzHfEPftT IoRJLEG7/4i30p0g3Q/C5UnkcewOfinc7MEm+U8EnYSPtvD7IKvSy424L6nUkZ805Bgs YSeFPL0fbFJcWvC07x490CcP12lxQWxMHMnCBNk3+K/GPCSVw4rvV+cIIhevLLkhQ2DT Rl5g== X-Forwarded-Encrypted: i=1; AFNElJ9gFWgJFK33UZrlqOoSGKSSHERzWdmIkZgyEqqvAJVntrMyJRYebAron84UMG9x27MYLrcy564r0Ac7pzM=@vger.kernel.org X-Gm-Message-State: AOJu0YzJOm0bUsgxExjeylkUGtfNFaFY4oaFmvZmIBjKFJDRXtu5puxX MPd7Xmn/JpGGpKRnvKjfrV0dagVComOPMhAfhVMsF3do7zaXVJfklHAq X-Gm-Gg: Acq92OGNMzXlfaIuotAg2J3FhBEchIMU+bjbJvhTt1qysj0xttOVOZ1DeyunTKxnkTD aERusr1YxFbn9sd5uM5PqkDp9oy8+mN9hfFJ35PN5t+SlxyW/svNlATejBP9YIgJ/Xm8fUnza3U sGOeFrFoPDQvo9Ug2TIDmThhHqAcGGU7nd7/3mbRkIUWGE2CItuz7N6FI7XPTQTvmVThY4plWOS Cz13C/lNScXWztLYjOIgtGiRleNrBiMl3dcKfaheR2Kgfn3oL5r8Qjq0Y7ILHhD3dSh0oNL4tyT rNtR8OrJB/M/7fgcd55Djxv1FZLmxtlClPIBNknLImR8at99lSmo4z9VbzR5CRW+IfIgWhUfxyI ks/kjcs7+PO3jOqC5JlE9bZDkW2yPd+zIeaiaHyAcO2R5CXkb4PKDMmcA3yLxIUnKZMy8e4eAD9 H3feg44qArl2tZN3L8 X-Received: by 2002:a17:90b:5624:b0:368:1b68:5114 with SMTP id 98e67ed59e1d1-3681b685a6dmr1894215a91.8.1778433085916; Sun, 10 May 2026 10:11:25 -0700 (PDT) Received: from ser8.. ([221.156.231.192]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-367d623fa47sm5120690a91.3.2026.05.10.10.11.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 10:11:25 -0700 (PDT) From: DaeMyung Kang To: Namjae Jeon Cc: Hyunchul Lee , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 2/2] ntfs: do not mark the volume clean from sync_fs Date: Mon, 11 May 2026 02:11:15 +0900 Message-ID: <20260510171115.368494-3-charsyam@gmail.com> X-Mailer: git-send-email 2.43.0 In-Reply-To: <20260510171115.368494-1-charsyam@gmail.com> References: <20260510171115.368494-1-charsyam@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit ntfs_sync_fs() can be called while the filesystem remains mounted read-write, for example by sync(2) or periodic writeback. Clearing VOLUME_IS_DIRTY from that path marks the volume clean before the mount lifetime has ended. If the system crashes after sync_fs() clears the bit but before unmount or remount-read-only, the volume can be left looking clean even though a clean shutdown did not happen. Keep the dirty bit set during sync_fs(); the unmount and remount-read-only paths already clear it when no NTFS errors were seen. Fixes: 6251f0b0de7d ("ntfs: update super block operations") Signed-off-by: DaeMyung Kang --- fs/ntfs/super.c | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/fs/ntfs/super.c b/fs/ntfs/super.c index e8ecc52..024d363 100644 --- a/fs/ntfs/super.c +++ b/fs/ntfs/super.c @@ -1895,7 +1895,6 @@ static void ntfs_shutdown(struct super_block *sb) static int ntfs_sync_fs(struct super_block *sb, int wait) { struct ntfs_volume *vol = NTFS_SB(sb); - int err = 0; if (NVolShutdown(vol)) return -EIO; @@ -1903,15 +1902,10 @@ static int ntfs_sync_fs(struct super_block *sb, int wait) if (!wait) return 0; - /* If there are some dirty buffers in the bdev inode */ - if (ntfs_clear_volume_flags(vol, VOLUME_IS_DIRTY)) { - ntfs_warning(sb, "Failed to clear dirty bit in volume information flags. Run chkdsk."); - err = -EIO; - } sync_inodes_sb(sb); sync_blockdev(sb->s_bdev); blkdev_issue_flush(sb->s_bdev); - return err; + return 0; } /* -- 2.43.0