From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id AA74164 for ; Sun, 10 May 2026 19:15:28 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778440530; cv=none; b=Y73LCO3R31Fjz4mw9c/J0i4xZ40dTHrYZAoLbq0oIfVDzprwvqC3VW60Wtt2rM7nQffZr1Hvw793V0XYM/nzZ3zg7pqxgaIKm/6ahcxLlIvBvGbfF5DOpO24MWvgiqWiV+RCWXRYbLaSDH0MCEzSbAL+hg9bq2GvzBLS9tgH3TI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778440530; c=relaxed/simple; bh=R+tg7wM/ZDcZDwYdUYd0Kg1Kjvw7zlA5Rb0pKrbABkE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=CFep3jppcgOYKu4VygcoE0+y5M7OvFPgPwj6HoZaf4FfcOU6nRCFhT3K8cQNYPtXhdyrGc7TlSvp7q+etD1qeZg1GlfnMS7sCJ6EGlbi3ShGJXqbcPWETQwgcvB30L4Ihdf+Iay6EmGESxuTGuKgZWBv4+5SbqeR3CILbFBx4MQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=QPT5EUVL; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=osH17b/M; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="QPT5EUVL"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="osH17b/M" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778440527; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=L5ghcGO/uZykueCouYPVSIKgvYjawm0B2pG8CDHe00c=; b=QPT5EUVL1cysbiid6H6/dwriAUxexlYHs3Og4cRvF+RGdYe20kAPBluaiagvVFqgBhW3VC FSLhkKnNMaOT7/YcqYdauwXH73TxbVV5CcFz+4hFANjvrschqblqzwGlVDWlM7bQPbDh/t jDngUvQU61CsxL89CicfEk7eUujoZQY= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-422-csu3HpbTPCGhyCiRChTJmw-1; Sun, 10 May 2026 15:15:26 -0400 X-MC-Unique: csu3HpbTPCGhyCiRChTJmw-1 X-Mimecast-MFC-AGG-ID: csu3HpbTPCGhyCiRChTJmw_1778440525 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-48a5952c635so41265385e9.2 for ; Sun, 10 May 2026 12:15:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778440524; x=1779045324; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=L5ghcGO/uZykueCouYPVSIKgvYjawm0B2pG8CDHe00c=; b=osH17b/MTLIphllkCDXYa0v3vhnq3ECRqUIWyn7lL+Zav8HDYhVY83g0dJmZfAQ6T+ QhVsH2MujsQK/jSDxO3t+Ey6e9ztgpMOR0AKJrL20wkr+PT4XlORQMWbAPCMRREwBK/o Pts+utOsjOvMVyuGtjJA1hAhjdCcB0oQIAdjf7LuB+IvXiWgxyfXmXriUHylzB6Ju09N qjbNZJ+EK+UUA1Q9Rzl3IQYjNLWhePInd4MtF+tqFq0Sz4REQww6NjqYSajkud2lLL3r 3zePmwC0n5Z0I5XcnkO2pZLP1kpmlTs079pkBtO83EBbq1zWNlchiTave8tYLXF0Kiua /LcQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778440524; x=1779045324; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=L5ghcGO/uZykueCouYPVSIKgvYjawm0B2pG8CDHe00c=; b=XxwpfHENKbGfkfxVrbOTm9vLTg5ah8XpvD8jqWmDA3ZhM/Tor21G1EYdJ0yFf0xi1H Ma1ItH1Mju7lP5cRKDr8OswfozUqJe6m9iawtIFQ+k0tJDe5K4raEseanEzlIjBDMwQ2 eCzM6AYzcegqnloD0do92X/V7ty8E3LWs1x2cM2zo4zqqbBdFQAEO2Pi1ULIkGwgQvLn u2Jv3yERN7UPr2uC1XzX39hxK+nQLPM7zO+Xn5RrbrqlHWZHQwUwbO9jNlvt5PgNUqP1 xHcpXBVxasCdqUHYS/jsyUXSRKPNkd9BN7A5i6FCBYypiVa8/cTEugWxPu9MQCv1cOfU 0juw== X-Gm-Message-State: AOJu0YzjMGyG9G/6LZ1UQeZX/Q96zfTx7DoHDLEWFZ5N6XoB560pye0V qDCWRM4k3biSdGttx5prJEvLiuXMDMD/vc2P8BRe6o1HxCuAAxjOTASsNuYV4MuwZhnB0QjVAJJ W6+KJRmdfqhcWSeWBT6N+kLJUgYQPKgPsG704HRX34/CzwLxXRbC/VjSsBEaXnJtUGpA/Viiw74 gegCRu6TuCofYD6GGxQpXrMioTe8zMbrzbSSYyU1fV1cdWhCKX X-Gm-Gg: Acq92OHM3Wx/u186aj/ZDximKu7r772TuUnb+OUu8owhxQmspw1H5SSJ6LCYRjA/HiB xs0Z5eOeSjcBTcuk9shz3YV5V96hdLLZXZYswaUt0NOsb4ogLYSeO8rts4Z24A0PArFJUM8r0k7 95vErCtoGXwHZL80B9lAPfGrA1n9WsndtWJBcZG3PemKiSA1PypJideUD5xUVWJgqfNYS7equm9 IzQYtNPRYvDd9zyHneP0860sNlPVVwkRl8/FQ3TMCldeFeoojPPfCBlM0YKp40Wk4ql6K1U2y2Z F/f+s0D8r78v/gdLgrCKaEbUWd6MHPm5FKnX8N0tYDLFfe3rtyYAeiPTrJRIycAk4F0dA+vQqpP YqHDRDe/TzaVADLpw0ndQORf/YuszlE75lj6jlwwfj73UapU= X-Received: by 2002:a05:600c:8907:b0:48a:65ad:1881 with SMTP id 5b1f17b1804b1-48e51f32a46mr277826565e9.13.1778440523985; Sun, 10 May 2026 12:15:23 -0700 (PDT) X-Received: by 2002:a05:600c:8907:b0:48a:65ad:1881 with SMTP id 5b1f17b1804b1-48e51f32a46mr277826135e9.13.1778440523384; Sun, 10 May 2026 12:15:23 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-48e6db0ec25sm48506205e9.24.2026.05.10.12.15.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 12:15:22 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 0/3] drm/bridge: it66121: Fix display output on DVI monitors Date: Sun, 10 May 2026 21:14:46 +0200 Message-ID: <20260510191459.90769-1-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit I wasn't getting any output on a monitor connected to an AM625 BeaglePlay board, and I tasked a Cursor agent based on Claude Opus 4.6 to conduct a root cause analysis. It correctly figured out that it was due to the IT66121 bridge assuming that the sink type was HDMI and sending AVI infoframes, but this can confuse DVI monitors. This patch series fixes the issue, the changes are fairly trivial and I take full responsibility of the contribution. An Assisted-by tag is added to the patches in conformance with the AI Coding Assistants [0] policy. Patch #1 is just a cleanup to avoid doing direct calls to container_of() and use a helper function which is the convention in most drivers. Patch by storing the connector sink type in the bridge state, to determine whether the mode should be HDMI or DVI. The patches were tested both using a DVI monitor and a HDMI-to-DVI adapter and a HDMI monitor, to ensure that there are no regressions for HDMI mode. [0]: https://docs.kernel.org/process/coding-assistants.html Javier Martinez Canillas (3): drm/bridge: it66121: Add bridge_to_it66121_ctx() helper drm/bridge: it66121: Add bridge-private atomic state drm/bridge: it66121: Select HDMI or DVI mode based on sink type drivers/gpu/drm/bridge/ite-it66121.c | 137 +++++++++++++++++++-------- 1 file changed, 100 insertions(+), 37 deletions(-) -- 2.54.0 base-commit: 19d584a634fe999786acfb0ac5289710cc84a5f6 branch: drm-misc-next