From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 77666196C7C for ; Sun, 10 May 2026 19:15:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778440531; cv=none; b=vGQg2SKSsNgO9TxKwl/KRebne6/pUxXeigqDNp+eMLZpYrPqH/IEARIJtfkkCnETaQQBHQk+/d66MYV/uUydStYsvTp/MyjCYBJV1gpHxJMInPoK4COWQAOjZFiu/FjVnymCoYNBtMq8DaxweJ9fbLdBxEHDC6NumnoHev/eei0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778440531; c=relaxed/simple; bh=2bkzo0x7WzdOHtnPaGg7ckVWdQL14juOTqF8dKSNxjs=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=cuzofXQflN7r1rWAXo3VyfAW/uZqZ9Uv6j4C5NqAP7w86MkOe9rRZk/4nghsrL3ntvs1pHDhdnxHB+i1llCNEcGTDTLGmEsy9FK+AeH8XuXTejiGzfFgn6BVCVIzZRyMUDmKSwWQL+bLzuKpgvcL+PmEduMYHbJZHBkLOFserkE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=E73NzPo6; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VHJgNyPF; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="E73NzPo6"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VHJgNyPF" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1778440529; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=WSff1/jlC/KCVsnlxPeLLqVDEAsoLX+CZn5Ceh75Mv0=; b=E73NzPo6n4Yxnu5hYkEKXf2e6Nby17ZhbD2ovk/2/6VC2qRd5IJpGFjYdiSqY0sVYmQOLy JJyuB63dwDnM4fJqr7wOarjlr0tqUrThfT2ywgDps7oSNQP06ROdJUCDzJeSRgWvybBgtT 3uBmOHo1BDsqyHm/aa15w004TYQx1FY= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-458-RL1gXzKmNA-hR6D9UaXNoA-1; Sun, 10 May 2026 15:15:28 -0400 X-MC-Unique: RL1gXzKmNA-hR6D9UaXNoA-1 X-Mimecast-MFC-AGG-ID: RL1gXzKmNA-hR6D9UaXNoA_1778440527 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-4518f777225so2400009f8f.1 for ; Sun, 10 May 2026 12:15:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1778440526; x=1779045326; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=WSff1/jlC/KCVsnlxPeLLqVDEAsoLX+CZn5Ceh75Mv0=; b=VHJgNyPFX3C22WLC++706puB6dcghjUbKIefo7JlyveqlVp6jJXRLjrcTrZSswWPAo j93zfMn0ujytJFg1ImUgSJyBigbFnNoWwOZN9/y937KbNYg+UJaiN++bLiUWrFo5Slew 0y4mpM5zmBj6Em0h3AZ7QbKlyDLHr/QjbawEdTqwI/y2eFo4zOkVuLSOxhQZ6ON/ezGQ qKNDiDemyQgz3A0XnEjSGY+hHjbh9Qqvdr1Hilgi6VLKc80QsqSdo8jBcLdngkn2+RmP j2i3B69OtOT4Z7uGKVtQs69t4iasCMbSQkDg1ePHQbmo7tkGqCJGSxgpf8/8AyI0izd3 C9FQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778440526; x=1779045326; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=WSff1/jlC/KCVsnlxPeLLqVDEAsoLX+CZn5Ceh75Mv0=; b=LmbFAB0AYdTiEJ9jz7NvOd4nOwcaBVH3WIyFFdEVK8zbu36ZTgYbMIybPbgz62TSrm p2mZVkS6QCZdh5ixcLR8NGDRjOWWz73ENXyOX8+3CWQl3mukn9CnQP8uRba73DJ/qXjp 9WC5bTz3QQos4OuXm+wiGIrKVJXSlB3/OV+LiGbJWyAR1KgpILTEHNnWqqlHeAcStqiH VzaCviA+IpKYpggJh6tahDAhSBJgFOtf/vuREcYLfFl+ZFut8bEXbZj1ONRHZYg1FjBE 7xirKB9+g+0dopi3kFdlPr/rRJEuCRNVBb9eHfYy1s4kB3LUDXbjJuRHEGjIgwad0LSW x8lg== X-Gm-Message-State: AOJu0Yx7AKWDC0m3dyUnnuSUefXaidoZbA49FpEExma/8JkH25jhPPdT mWooQb6RFfQtpJlRfYwfKxO/EoQdlWGgVgffvrnuqcxfMsIRc9j5Hca7nIjJFXXIk5afyfoh4vd 9tgFVUa3T5MX023dOF26n7HVJDDhj7YkSylCCUqaXDJvDYWGGRK/mWztmOTEsc2bb7s3Zpvj0g+ cIMAlLSQb8cIQ12P8tR3RbIMA/ZGRzvEkYd/M0iKELnjchPr/b X-Gm-Gg: Acq92OFEllJDtv+WsP0yXoLaFwFeWdD1KcyVNFtbScVTR86VozaXaYOUFS9Hpmm1/D0 xbGD6sHKjynZK924JhjGIRtrZ6y5iIAVYD2qeH0rpRwk2HJvV63XPKIUrXW+Ub2oOy1g5Zl/Gyx uyAjlcduJBfOAHMy8D5v2iaBU6QnzzMqOxguB2sOHQQ+1GgyN+zdLveKjHAhOG24xX+KBrqC0aO R+S1j0UHkGVvQlgm/uWO6cvvHTPKfGGEy51/4YbCBawdcEOZtVuNBDli+1zKtJKzqQC0r6dBCuE 2JTSHHyHym7dfgRzLUjmZ+CmRxhGxm2lmwPHuStj7nJ3HjnjO6jpjE+T+y1m/ZIWW6/XrvcdahM MPXE6yAug+7ro8kK8i7iVKmFAvJLGleTcIfwxrXRef7kQBgo= X-Received: by 2002:a5d:5f53:0:b0:43e:a69b:d810 with SMTP id ffacd0b85a97d-4515d9a0839mr34527754f8f.38.1778440526271; Sun, 10 May 2026 12:15:26 -0700 (PDT) X-Received: by 2002:a5d:5f53:0:b0:43e:a69b:d810 with SMTP id ffacd0b85a97d-4515d9a0839mr34527707f8f.38.1778440525714; Sun, 10 May 2026 12:15:25 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4548e4bbebdsm21919341f8f.5.2026.05.10.12.15.24 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 12:15:24 -0700 (PDT) From: Javier Martinez Canillas To: linux-kernel@vger.kernel.org Cc: Javier Martinez Canillas , Andrzej Hajda , David Airlie , Jernej Skrabec , Jonas Karlman , Laurent Pinchart , Luca Ceresoli , Maarten Lankhorst , Maxime Ripard , Neil Armstrong , Phong LE , Robert Foss , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: [PATCH 1/3] drm/bridge: it66121: Add bridge_to_it66121_ctx() helper Date: Sun, 10 May 2026 21:14:47 +0200 Message-ID: <20260510191459.90769-2-javierm@redhat.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260510191459.90769-1-javierm@redhat.com> References: <20260510191459.90769-1-javierm@redhat.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The driver just calls container_of() to obtain the it66121_ctx from a drm_bridge, but follow the convention of other bridge drivers and add a helper function to wrap this duplicated logic. No functional change. Assisted-by: Cursor:claude-4.6-opus Signed-off-by: Javier Martinez Canillas --- drivers/gpu/drm/bridge/ite-it66121.c | 27 ++++++++++++++++----------- 1 file changed, 16 insertions(+), 11 deletions(-) diff --git a/drivers/gpu/drm/bridge/ite-it66121.c b/drivers/gpu/drm/bridge/ite-it66121.c index 19a027d75b61..038a67a32e39 100644 --- a/drivers/gpu/drm/bridge/ite-it66121.c +++ b/drivers/gpu/drm/bridge/ite-it66121.c @@ -315,6 +315,11 @@ struct it66121_ctx { enum chip_id id; }; +static inline struct it66121_ctx *bridge_to_it66121_ctx(struct drm_bridge *bridge) +{ + return container_of(bridge, struct it66121_ctx, bridge); +} + static const struct regmap_range_cfg it66121_regmap_banks[] = { { .name = "it66121", @@ -589,7 +594,7 @@ static int it66121_bridge_attach(struct drm_bridge *bridge, struct drm_encoder *encoder, enum drm_bridge_attach_flags flags) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); int ret; if (!(flags & DRM_BRIDGE_ATTACH_NO_CONNECTOR)) @@ -700,7 +705,7 @@ static u32 *it66121_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, u32 output_fmt, unsigned int *num_input_fmts) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); u32 *input_fmts; *num_input_fmts = 0; @@ -724,7 +729,7 @@ static u32 *it66121_bridge_atomic_get_input_bus_fmts(struct drm_bridge *bridge, static void it66121_bridge_enable(struct drm_bridge *bridge, struct drm_atomic_commit *state) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); ctx->connector = drm_atomic_get_new_connector_for_encoder(state, bridge->encoder); @@ -734,7 +739,7 @@ static void it66121_bridge_enable(struct drm_bridge *bridge, static void it66121_bridge_disable(struct drm_bridge *bridge, struct drm_atomic_commit *state) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); it66121_set_mute(ctx, true); @@ -746,7 +751,7 @@ static int it66121_bridge_check(struct drm_bridge *bridge, struct drm_crtc_state *crtc_state, struct drm_connector_state *conn_state) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); if (ctx->id == ID_IT6610) { /* The IT6610 only supports these settings */ @@ -765,7 +770,7 @@ void it66121_bridge_mode_set(struct drm_bridge *bridge, const struct drm_display_mode *adjusted_mode) { u8 buf[HDMI_INFOFRAME_SIZE(AVI)]; - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); int ret; mutex_lock(&ctx->lock); @@ -829,7 +834,7 @@ static enum drm_mode_status it66121_bridge_mode_valid(struct drm_bridge *bridge, const struct drm_display_info *info, const struct drm_display_mode *mode) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); unsigned long max_clock; max_clock = (ctx->bus_width == 12) ? 74250 : 148500; @@ -846,7 +851,7 @@ static enum drm_mode_status it66121_bridge_mode_valid(struct drm_bridge *bridge, static enum drm_connector_status it66121_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); return it66121_is_hpd_detect(ctx) ? connector_status_connected : connector_status_disconnected; @@ -854,7 +859,7 @@ it66121_bridge_detect(struct drm_bridge *bridge, struct drm_connector *connector static void it66121_bridge_hpd_enable(struct drm_bridge *bridge) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); int ret; ret = regmap_write_bits(ctx->regmap, IT66121_INT_MASK1_REG, IT66121_INT_MASK1_HPD, 0); @@ -864,7 +869,7 @@ static void it66121_bridge_hpd_enable(struct drm_bridge *bridge) static void it66121_bridge_hpd_disable(struct drm_bridge *bridge) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); int ret; ret = regmap_write_bits(ctx->regmap, IT66121_INT_MASK1_REG, @@ -876,7 +881,7 @@ static void it66121_bridge_hpd_disable(struct drm_bridge *bridge) static const struct drm_edid *it66121_bridge_edid_read(struct drm_bridge *bridge, struct drm_connector *connector) { - struct it66121_ctx *ctx = container_of(bridge, struct it66121_ctx, bridge); + struct it66121_ctx *ctx = bridge_to_it66121_ctx(bridge); const struct drm_edid *drm_edid; int ret; -- 2.54.0