From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pl1-f178.google.com (mail-pl1-f178.google.com [209.85.214.178]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 858462DEA89 for ; Sun, 10 May 2026 19:46:25 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.214.178 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442386; cv=none; b=dvkdCxq7278Nrhce8kEOzdMHe9dot4Oe4e3ey6PdfFE0Zbvz+GALBXeztJmtLUTlh04ZwENFrVdSWnzTAurQzKGZUDg6zGN0Xqf6QRjymeXMpD70CsI41GjJ/WvbnE0Nv8szY9H0ldkm1Uewg+xBfVZZkpCMieRq2M9wOaouyBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442386; c=relaxed/simple; bh=dx7CTCdfgI9/VwOubrKjgKAV7j3wBdm3ATenpfZhl1I=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=JMTxbKGXg7jk9dekQuipkLJMS7dBjpNr06rCYoSiYoiGpGYzEt1J+9Rxw8INYt5uuUvFr9+U181yOXWef/4GMA6/sVRpr/KCnk9/PVLlMTjP0Ds3tGG3yiLbwa+wUXlNpvjuYD82vvN/rR+dcJ+CaA2JK+tRH58zdRbSQO74TzU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=IT1DJnXa; arc=none smtp.client-ip=209.85.214.178 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="IT1DJnXa" Received: by mail-pl1-f178.google.com with SMTP id d9443c01a7336-2bc7b311e77so3519275ad.0 for ; Sun, 10 May 2026 12:46:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778442385; x=1779047185; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=KNV1JSHPdfX4ad5c25kdBdSP0iYBWYMWxSLFq4BW90Y=; b=IT1DJnXa8yWVENT0r3TgfTobsBRhDfyaoex0MMODU4U1hdM0n1urCGKmvJ/tcJgwo+ WRbhgxq0aMnRVewr1qgTgaIEvpgVkdW3nuiePvKwjR7NYShH923VICo0IDgcF2Tym4Ab yw3tBVm271uuFtd6tW3yeZ4q4+/LBXJRK2j/v+m5EQOX3R+ofJSUkq6/icwsjvtnVXf7 OHFaLgMazrqHHCFBFgMNsbPhfOFVOULcKR1LdwtXD4Y15GHWLhgtumO6AY9KxquUItrs VHEwW/V1/caK8LPPmsmCPFmolnnnZLwYMqajfS3wHMeOBxawDo00wMAI/Dx47/flFk66 To6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778442385; x=1779047185; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=KNV1JSHPdfX4ad5c25kdBdSP0iYBWYMWxSLFq4BW90Y=; b=KxUCyT1+XcRpbaOEEjycdop6YnshOeL3ejCuWvBU/eq6FQEpJ4SSBeRSOYwAMuL8Ua 2VGYIwAm9pno7OJAl6ASvii+vDI9utp73JXcwmnqtaMFpJLRvI8xGWkbV0NPK0IaGr6T 0sdmrQ1ztpjd5yUcdkcANBa9T8WSekJAeGnm/riC1GQ4IRH8nLmwv8cY2AQ2cmVaSPic 8cp7C+QQf/klyjJWj+5iJFcUIZ8TwEGbnCrv5/H/8q6jps14ZLx8WoUjD20omz53ef7J x/FQzwfMtLuKAjU+DOSpnMk+vPeNGXdA3MlDMkh3ECuGSI1HG+TDCLSW/yLvirFr9KO7 kZKg== X-Forwarded-Encrypted: i=1; AFNElJ/Knfc/w42znlYCihPxp3fEjlDLg5OGjb7f38sgaKoJf8k03YGy4OpbzsnZI6L5CWzSc4z50zlz0Ox3bIg=@vger.kernel.org X-Gm-Message-State: AOJu0Ywt5ui7ybUBOntPiOyaeTbXrPZrpU3g+jSJcCCSTDPLSvcQ+OKq 8O8zL5xuG17yqMXiINa0Jo9RJc/oQ4/8p1EOsfrj+aFQv3vMshyQnoUR X-Gm-Gg: Acq92OFTj/0TGOoqD51BHHtrZFHea3L5aJUFbcsVj5rmF+006JyFKByBnzek3cgR4tZ WAaBQDoeGmCe/RoJ5BwHV1u3upVisKk+8nMLbOv580V7KWAR6ivU1wn/hog/Rhb+tRNXb7XTR1T eOJYSzFuur+tu7XS/A8vFC988cTUIjyMsSrB1vphQ0YYmaUhdxqZX4n9eLuuPgxp8YAL7rKk7GX tcuAGle4uE39tnllLxO4SXA2UntpcHK/aEVin0SR/186ewbXdgCN2/5VK8eM0ZYmvne43Eafies 4vViJ4U2vhSU+MsqGp1K88yd2krXzt2+1/hTgD1PMdbaemyUHFYDayFLjxRcvF3kvvxLUtFufQN odNl24E0Itel/Y6glHdl5pG9f8NxQwdKLS+/h1Qwc0s6vupLI8d2mEUAvobPkzKlTUDTji3o7Fh tY3PXjNIPvwQ++hnTSoZUxPVZeFCmOGIv92ltBozEjidgvVYxM0BDxk//ICX2AuwU+rC2zBdfDQ hb+r+jyt4HJj52XBqHNESI6orGlITtsGRg= X-Received: by 2002:a17:902:cf0e:b0:2ba:61dd:b41a with SMTP id d9443c01a7336-2babbcf5cc0mr137031195ad.0.1778442384777; Sun, 10 May 2026 12:46:24 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1e358b2sm77026115ad.54.2026.05.10.12.46.23 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 12:46:24 -0700 (PDT) From: Rosen Penev To: linux-ide@vger.kernel.org Cc: Viresh Kumar , Damien Le Moal , Niklas Cassel , linux-kernel@vger.kernel.org (open list) Subject: [PATCH] ata: pata_arasan_cf: simplify ioremap Date: Sun, 10 May 2026 12:46:07 -0700 Message-ID: <20260510194607.9567-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use devm_platform_get_and_ioremap_resource() to combine platform_get_resource, request_mem_region, and ioremap. Signed-off-by: Rosen Penev --- drivers/ata/pata_arasan_cf.c | 20 +++++--------------- 1 file changed, 5 insertions(+), 15 deletions(-) diff --git a/drivers/ata/pata_arasan_cf.c b/drivers/ata/pata_arasan_cf.c index b1e281b64f57..d5cb88ae2b76 100644 --- a/drivers/ata/pata_arasan_cf.c +++ b/drivers/ata/pata_arasan_cf.c @@ -803,16 +803,6 @@ static int arasan_cf_probe(struct platform_device *pdev) irq_handler_t irq_handler = NULL; int ret; - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); - if (!res) - return -EINVAL; - - if (!devm_request_mem_region(&pdev->dev, res->start, resource_size(res), - DRIVER_NAME)) { - dev_warn(&pdev->dev, "Failed to get memory region resource\n"); - return -ENOENT; - } - acdev = devm_kzalloc(&pdev->dev, sizeof(*acdev), GFP_KERNEL); if (!acdev) return -ENOMEM; @@ -836,14 +826,14 @@ static int arasan_cf_probe(struct platform_device *pdev) quirk |= CF_BROKEN_MWDMA | CF_BROKEN_UDMA; } - acdev->pbase = res->start; - acdev->vbase = devm_ioremap(&pdev->dev, res->start, - resource_size(res)); - if (!acdev->vbase) { + acdev->vbase = devm_platform_get_and_ioremap_resource(pdev, 0, &res); + if (IS_ERR(acdev->vbase)) { dev_warn(&pdev->dev, "ioremap fail\n"); - return -ENOMEM; + return PTR_ERR(acdev->vbase); } + acdev->pbase = res->start; + acdev->clk = devm_clk_get(&pdev->dev, NULL); if (IS_ERR(acdev->clk)) { dev_warn(&pdev->dev, "Clock not found\n"); -- 2.54.0