From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f175.google.com (mail-pg1-f175.google.com [209.85.215.175]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id BF85981732 for ; Sun, 10 May 2026 19:47:57 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.175 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442479; cv=none; b=Q2/waWaIdOyEUVEPEdydCDay3ZokIy0Cd+VMWerIF7bCP5LiUVXDLz2xJqimDXvmPjLkPc0qxpu6AGKvlfVPg6wlPkNGvtdCZISkto7AE++wGIwAnoH/TXGsBdx6zfMxREF8IowlHUBM29VODVYDbwq/YzmHaCtpR/KVPRaLahY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442479; c=relaxed/simple; bh=mVoP0YS+geBC6tEgFcXP6JDuBDLadNYdfa5JgraNFOY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=GxudXSlUmuBMt9COYjLNjlhVgpsEqHxWq0QpVfFdO4kjjk72QJzoCQ6hhfExUGrzRe/VaWFxVDoE2W8rtc2fZeyxZ/ZSCv49lvFy3o1a1f/8JFd7Clx5br9BPatWoW0WPy/Zup1BZLB2/QCPXwErT3ukTl8e7ieboyaJZQEUoS4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=T7PhGHKP; arc=none smtp.client-ip=209.85.215.175 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="T7PhGHKP" Received: by mail-pg1-f175.google.com with SMTP id 41be03b00d2f7-c8027e876fcso1358479a12.1 for ; Sun, 10 May 2026 12:47:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778442476; x=1779047276; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=S5ejLPxPJRckja7EQNl6w9Ld6Nr4M5kbRIX7BGycq5E=; b=T7PhGHKPzrykCImJVi5JnhJgU4dSVH/yAgwvTuvGD7rK8HFlygL8kUS/4X+LDkT3J1 QFzC5N0SqjkUf9jHFyu84z/rcvQfUd5T7cNn+vO3j419OvnQhHtiTJmnNaYcj5tQXebc iWbKOxhwDIsyBK4uhPII2RGtganeg42lgeeU3Inznlp0a2pLAG5Kp2z2XyqFVniBRpTP 2G91NQt/fCqYt1cC6BCwYQaKJpTseQZtXCwwAGR6OgSc6mXtVHjUWzKSzXrFQ4ZcDJRm mhtAgAJidEnwLnHUq4mvYUSVNO3teUQ4aNfWbSNJ1/XGtXimNTsZ43DYMjj8wdoaCbD4 HiYA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778442476; x=1779047276; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=S5ejLPxPJRckja7EQNl6w9Ld6Nr4M5kbRIX7BGycq5E=; b=oJT9Jez10XscZf91TZHm0lD+FAwEf/F+ydGRNjqarIbMTaAix96XPHFJakPAzLyENE wdVWDoyvhd0lpuN5G81Gy8rOajXOpK905poISGk92UJwaJLXuLErKxxL7XeLhWgtKgdw cQF6Iv8wGROnsVDj2NL2IHSaH+ht6+Fb5kn1raO1NxVARDm+NNtnKUnEPBaGUwcL2eN6 asquksZgu7Y8+/FXzmxC3aa8Xngq5I7+OoHK+lLDvwLPEIoDOK5iT5Nud9VYhhezVnBw u8Wra7KblRBG289XQGG+Lqu007JCt5uCyoQnb45uTPaKeueK2QwkIMFLw3POMeblkcsd NALw== X-Gm-Message-State: AOJu0YxDgmmqGPH55HfNkv/9xA3iLuR/D6AdtsJcGmEYxg65W5VqAY2n 1oxAWPDFLZtAdFxWaRj/8eWeM8gdD5PZBzkbfcKA4kFuh/PX6iQ8IbXwwzdfuQ== X-Gm-Gg: Acq92OFCTHSipYTOPEGWqnC/Fw147yxMMHh9I/jK+ZqM7ftFYDXiJ0T7IJlWG5IpiXj JuP0EGCM2dM9ZfjMrEmWHe/wtBEBZO+on7lfWDuI2hEmnr9nZrojyrlEG160aonZvAKQJ7f4132 lbIg3KuxtvculYzWqs0dJvTYh4T03XtLdt/2cs/G1N5AhZ6YWaUsMikgSul3LdxKWvJjko7Trrh O9h9EPyvlh6oe7SlVZT4VHZuKb6sGdLwmsmvhZKdYWFBpg7vfsqf/NYVce9v6Uu+sZ/gJWXolyk z9BWnVOeJu0MXT8ZIztd2dfMgqDro8jALaYBU8nqmYGa2xY3qakhfJUVPGz9qFdFwk4BipP0EDB vpbT9865ciFaoYDkZ+sMyF/Ttd7NHUs5lYumLjKxbM4AJHEebcfeA8moL3ERyYKljHvy8e+e10+ iFWijeU33B7MdfTU/GSEH7OsyZzpM1gTfG5QBARKpxtXaK07/ZFGBDk3d9iGnJ8fWuQwldi5T8C 16gdLoq7h5ImaPrVYLJDn91fUdOlLoJ73k= X-Received: by 2002:a17:903:32d1:b0:2bc:7d09:dcef with SMTP id d9443c01a7336-2bc7d09ecc3mr72175385ad.29.1778442476379; Sun, 10 May 2026 12:47:56 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1d271d1sm81566585ad.11.2026.05.10.12.47.55 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 12:47:55 -0700 (PDT) From: Rosen Penev To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner Subject: [PATCH] irqchip/tb10x: simplify ioremap Date: Sun, 10 May 2026 12:47:38 -0700 Message-ID: <20260510194738.9810-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Use of_io_request_and_map() to combine, resource aquisition, region request, and ioremap into one. No longer need to call release_mem_region. Just iounmap. Signed-off-by: Rosen Penev --- drivers/irqchip/irq-tb10x.c | 22 +++------------------- 1 file changed, 3 insertions(+), 19 deletions(-) diff --git a/drivers/irqchip/irq-tb10x.c b/drivers/irqchip/irq-tb10x.c index cdeaa13f1681..846663ac94a3 100644 --- a/drivers/irqchip/irq-tb10x.c +++ b/drivers/irqchip/irq-tb10x.c @@ -90,28 +90,14 @@ static int __init of_tb10x_init_irq(struct device_node *ictl, struct device_node *parent) { int i, ret, nrirqs = of_irq_count(ictl); - struct resource mem; struct irq_chip_generic *gc; struct irq_domain *domain; void __iomem *reg_base; - if (of_address_to_resource(ictl, 0, &mem)) { - pr_err("%pOFn: No registers declared in DeviceTree.\n", - ictl); - return -EINVAL; - } - - if (!request_mem_region(mem.start, resource_size(&mem), - ictl->full_name)) { - pr_err("%pOFn: Request mem region failed.\n", ictl); - return -EBUSY; - } - - reg_base = ioremap(mem.start, resource_size(&mem)); - if (!reg_base) { - ret = -EBUSY; + reg_base = of_io_request_and_map(ictl, 0, ictl->full_name); + if (IS_ERR(reg_base)) { pr_err("%pOFn: ioremap failed.\n", ictl); - goto ioremap_fail; + return PTR_ERR(reg_base); } domain = irq_domain_create_linear(of_fwnode_handle(ictl), AB_IRQCTL_MAXIRQ, @@ -169,8 +155,6 @@ static int __init of_tb10x_init_irq(struct device_node *ictl, irq_domain_remove(domain); irq_domain_create_fail: iounmap(reg_base); -ioremap_fail: - release_mem_region(mem.start, resource_size(&mem)); return ret; } IRQCHIP_DECLARE(tb10x_intc, "abilis,tb10x-ictl", of_tb10x_init_irq); -- 2.54.0