From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pg1-f181.google.com (mail-pg1-f181.google.com [209.85.215.181]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6E45C322A2E for ; Sun, 10 May 2026 19:51:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.215.181 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442666; cv=none; b=sc9FvIRnxSVzqghncA5MEUumjslsZjHifTIxdsTZVPK0ePnHahsJM1zJLEDkqcKaIYhpzxUoclfQJ+ucK3/5vyy+EckxAnTyz1ucOLxye0lrRbpL8grI0uUH403gNp0T9XCuguKRfoMBjGp733PfIbdE9If7dYRLpN+dC7cuiwE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778442666; c=relaxed/simple; bh=qy67ampRMVZqwRmzsjjdQbT6QLi6VuaEBZYT1/MTvEs=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=tCoGi30wdH3nDkbb0pIX6ABtGmRXcXmtg3fbeRt70KGoYTzb59ZIM/U+fh3bZsfD6rWfH5Nl6WFNUc1iXaVIG77fgu403rFy0NcaOQa1Dhtk00xz6TszyzMxJJNLEKhHULbPG5WwDmWZPIFdu+UWmWMv/gkkZfNzifuMsB+b9A0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=Zd5erBg1; arc=none smtp.client-ip=209.85.215.181 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="Zd5erBg1" Received: by mail-pg1-f181.google.com with SMTP id 41be03b00d2f7-c80148ae949so1500619a12.2 for ; Sun, 10 May 2026 12:51:05 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778442664; x=1779047464; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=8iI1RsUJy3jPss5H1NJck2z9ijXsiYtxqAXvRNgtOYk=; b=Zd5erBg1TqKfTX3bOrBfUQKYogeAiNbGFWez4iq2BWCV8t5PbmcA3tGuEpgmwVNsxR Y0vsCxXtk1eY9apx7Pc0UNC8cw3pAvjWfbOE/jlEYA8fuoGAHlFuZHSkZdElksHnRzSp kVn3cgc0DTa4E4rnqUqToevO3iGmWCfiXFib/NiiZd2EWIDtfXlJ50burok+3i2vjBPy K7swXR1/gN9nuYNcjURDSOH8nQlGUIqoyf6PDiXLvo8SSSIOv6DYeG3vh/Mno0au9QVa 4P70VGHBy2ZEFi8dtVdHI1blXGVnF6AGjpiDSjTc4vxuAMGWnvN9pEiuZ3TdXKBCSHsJ 2j+A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778442664; x=1779047464; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=8iI1RsUJy3jPss5H1NJck2z9ijXsiYtxqAXvRNgtOYk=; b=BHVCSK9qqqfSWXF9plvlT/N70AMAGuRonmfIePmg55kj9vae0nRh78vbkJr0p3Oo5e /tL7U7+Cpm4NDkVMULIij2j34ENwJhTcICeAHhvq/42mgJHESVdwzg32lb8r7/PZ321x H+YrbNUJ9Du27wX74gmAkuOMQ89lT5+/orvaN00U9O4k7/cUarR+dGLyXoAVbGwXNyfA BRVOwnAzbHcDp+d0pVgXPbbwLgytPtq1XLxjFHkPbAKKEWaAbk0bvgzderv8rZF2+4rK lIZ8VdEuVSFkRYbycq6RIyyrt9MUzZQH2aLnvV79Xn9agwVSe6lL6aG7ILFDYOakRyyK aXbA== X-Gm-Message-State: AOJu0YwlCmPHXbORjaIu6G5U+vD0z20Q0d59U48yLa6aikux7POkjiZz ISjmz16n0Z7WTirKY9UkeEc0nZA2BWP4HC/aNSZWGq1pAoSOCPm6RixuXU5DVQ== X-Gm-Gg: Acq92OH16P6jjwo/9xI8Vh8gi6e000DHi4+ucO5/PAXHZWGt5gFvIMo6ZCXsZx1Xwt1 dUZGDEdZU1ku7Q/XYU0deHHtuW6xrLQtnwAe4xyGp3Rv01RxZdSpW6lJvgHiZZ1k1h/z/Mp2lDr 5kZOa+IcRU3GfJYtbRUfdryIaj/L4eeMKkAtt0G9P7/XZGDy+JlzCT8WaIWbYaPyaPhhW3U6ejN iVMwrwIrQGfpua0efqDO7IcXtzb1nxkSRw6/4+jT/DqOZbYeuX/HWAkgCZ6iRIzgdAtLTeBxb+D XMR95CJ62vS3gzaXZsvjShWBQAGeKxfuRAnA85FMNzTVqvl8fYm4y7MtuX7QE7T6uMYueI4FYLo KWKQvN5M09v9RgfZKcDItHJuVqNbp4XPbdhM4kzjDd7Xpcs219V7Ry3gFNPA/D4i2vEsv6/H/G1 gAfQwL5nXSPPJcK53cIoPMkQaiYQ9Ghd52mp9bQG62R5HRnUwNhZ1/CzbsY2Pe6K+2B1cTmVIZl /zgBX/TZeVhkyEF7IVlZrixAuqEuUNa8Yg= X-Received: by 2002:a17:903:1a68:b0:2bc:7486:21cf with SMTP id d9443c01a7336-2bc748623e7mr86956865ad.36.1778442664283; Sun, 10 May 2026 12:51:04 -0700 (PDT) Received: from ryzen ([2601:644:8000:5b5d:7285:c2ff:fe45:8a32]) by smtp.gmail.com with ESMTPSA id d9443c01a7336-2baf1eafa62sm84439455ad.74.2026.05.10.12.51.03 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 12:51:03 -0700 (PDT) From: Rosen Penev To: linux-kernel@vger.kernel.org Cc: Thomas Gleixner , Andrew Lunn , Gregory Clement , Sebastian Hesselbarth , Nathan Chancellor , Nick Desaulniers , Bill Wendling , Justin Stitt , linux-arm-kernel@lists.infradead.org (moderated list:ARM/Marvell Kirkwood and Armada 370, 375, 38x,...), llvm@lists.linux.dev (open list:CLANG/LLVM BUILD SUPPORT:Keyword:\b(?i:clang|llvm)\b) Subject: [PATCH] irqchip/mvebu: Allow EBU irqchips to be compile-tested Date: Sun, 10 May 2026 12:50:47 -0700 Message-ID: <20260510195047.10143-1-rosenp@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit The Marvell EBU interrupt controller Kconfig symbols are hidden and selected only by platform code. This prevents build coverage for the drivers on other architectures even though the code only needs OF and MMIO support. Add COMPILE_TEST prompts and the required dependencies for the GICP, ICU, ODMI, PIC and SEI irqchips. While touching PIC for this coverage, use GENMASK() and BIT() for its masks so that 32-bit platforms can compile this safely without running into issues. Tested: make LLVM=1 ARCH=s390 drivers/irqchip/ Assisted-by: Codex:GPT-5.5 Signed-off-by: Rosen Penev --- drivers/irqchip/Kconfig | 31 ++++++++++++++++++++++++++----- drivers/irqchip/irq-mvebu-pic.c | 8 ++++---- 2 files changed, 30 insertions(+), 9 deletions(-) diff --git a/drivers/irqchip/Kconfig b/drivers/irqchip/Kconfig index e7d559472790..cf3aea96866b 100644 --- a/drivers/irqchip/Kconfig +++ b/drivers/irqchip/Kconfig @@ -451,22 +451,43 @@ config MSCC_OCELOT_IRQ select GENERIC_IRQ_CHIP config MVEBU_GICP + bool "Marvell EBU GICP interrupt controller" if COMPILE_TEST + depends on OF + depends on HAS_IOMEM select IRQ_MSI_LIB - bool + help + Support the Marvell EBU GICP interrupt controller. config MVEBU_ICU - bool + bool "Marvell EBU ICU interrupt controller" if COMPILE_TEST + depends on OF + depends on HAS_IOMEM + select GENERIC_MSI_IRQ + help + Support the Marvell EBU ICU interrupt controller. config MVEBU_ODMI - bool + bool "Marvell EBU ODMI interrupt controller" if COMPILE_TEST + depends on OF + depends on HAS_IOMEM select IRQ_MSI_LIB select GENERIC_MSI_IRQ + help + Support the Marvell EBU ODMI interrupt controller. config MVEBU_PIC - bool + bool "Marvell EBU PIC interrupt controller" if COMPILE_TEST + depends on OF + depends on HAS_IOMEM + help + Support the Marvell EBU PIC interrupt controller. config MVEBU_SEI - bool + bool "Marvell EBU SEI interrupt controller" if COMPILE_TEST + depends on OF + depends on HAS_IOMEM + help + Support the Marvell EBU SEI interrupt controller. config LS_EXTIRQ bool "Freescale Layerscape external IRQ support" if COMPILE_TEST diff --git a/drivers/irqchip/irq-mvebu-pic.c b/drivers/irqchip/irq-mvebu-pic.c index 10b85128183a..95090d8efc06 100644 --- a/drivers/irqchip/irq-mvebu-pic.c +++ b/drivers/irqchip/irq-mvebu-pic.c @@ -24,7 +24,7 @@ #define PIC_MASK 0x4 #define PIC_MAX_IRQS 32 -#define PIC_MAX_IRQ_MASK ((1UL << PIC_MAX_IRQS) - 1) +#define PIC_MAX_IRQ_MASK GENMASK(PIC_MAX_IRQS - 1, 0) struct mvebu_pic { void __iomem *base; @@ -44,7 +44,7 @@ static void mvebu_pic_eoi_irq(struct irq_data *d) { struct mvebu_pic *pic = irq_data_get_irq_chip_data(d); - writel(1 << d->hwirq, pic->base + PIC_CAUSE); + writel(BIT(d->hwirq), pic->base + PIC_CAUSE); } static void mvebu_pic_mask_irq(struct irq_data *d) @@ -53,7 +53,7 @@ static void mvebu_pic_mask_irq(struct irq_data *d) u32 reg; reg = readl(pic->base + PIC_MASK); - reg |= (1 << d->hwirq); + reg |= BIT(d->hwirq); writel(reg, pic->base + PIC_MASK); } @@ -63,7 +63,7 @@ static void mvebu_pic_unmask_irq(struct irq_data *d) u32 reg; reg = readl(pic->base + PIC_MASK); - reg &= ~(1 << d->hwirq); + reg &= ~BIT(d->hwirq); writel(reg, pic->base + PIC_MASK); } -- 2.54.0