From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pj1-f42.google.com (mail-pj1-f42.google.com [209.85.216.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B5B1232A3FE for ; Sun, 10 May 2026 20:00:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.216.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778443260; cv=none; b=ucTQCYe5sGNFCbyTMIkU0bgWPD8Ydsm5bDAuYt4mL4OEveKzucswcQYfzAuU8vfuIIlABanLmpAYSlOJJZzjRwb+9jBKpjh0F+hcz1S9sILLWjbq5OkVyoIJLjAqxshPjWgKo/lbggQrEGBsPUn9bQFO7n+Cl0/FsbDzEag4nQE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778443260; c=relaxed/simple; bh=wjikRYzv8dC+NuTIUMWxUhRPG+/ZfBWsJiygitSNBvE=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=RFxTj7lagjFxnMmTsRK06XRlF2SxrT9O8LeEBvwMRLS16Zn1zA5mC8iJu2Fug+NRw46+7F17dtffE6dWNtsn8kQv4q3MLyp/Zy7Ebv9prWJWrIM8HjZJNAa25NP9h0viifxvNcvaBQdTqc8BxWeVQqluDfvCg6hXhZ+JaFTNPsE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=P1qgETt1; arc=none smtp.client-ip=209.85.216.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="P1qgETt1" Received: by mail-pj1-f42.google.com with SMTP id 98e67ed59e1d1-366be8040a9so882429a91.3 for ; Sun, 10 May 2026 13:00:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778443259; x=1779048059; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=R29xRWOosbdM9TadRiN8P+ttpGm4BOCiuJb6z0yqxGA=; b=P1qgETt17KKBIKetVUXcw/wXf59JTYhsOYgqC9eGdXr8P4aVaoEzxhiWeV+imSfy6u 6Wci31FqPT9KKm/BWTtfoFOV1Fz0nuUHbT8jcwpBEwAU8VLmXyohXSYbAqfgQVw7dCYb J8dxYchAs9hcG3Lo2zC77vxCu41kRiXM9GaY53JE98+XotQuMg78I2PxAaCRnVI47P62 SKt0JX03Wk0oRWgFApLdruXDko7LM8Dh2TbT7pnRNnmFiTitX3KLL3JhyRBK8okQaRsr nd4dHHjh2Se62oQpmCCcBNqCyCYA3FTi/xYSaKXhXVuLkSbs9hNhiRbSiqnuPU8tlQcU ztyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778443259; x=1779048059; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=R29xRWOosbdM9TadRiN8P+ttpGm4BOCiuJb6z0yqxGA=; b=QN1PModlnAXCiMf5Y5QaT2cTQIqlImgpZEgOGJ4bOIbL0epr6eU1Qkxs8uBiBGVGrG M9yktqR/aDDgyCJ0OoK+cQzcSJp88VNcGxp+O3L3UtJHPbUX3yoRRRP8DbIdc192AV/Z ApGi74IxdhPWBHLlUPhMURh2pXppRgloEU7Rq/pCq9OO0iXKWkTPxf5BZeO5T5f3Q5ZO B5WX9RT5QLSGyUZwtOQngmM4kW+/i3RlDdwOHnzLiy1667PTFwdI7VHqeXzudzsLSLE9 +oOuTrIxzbkuBK3IThwpk3r1Pu2WJxleGTcUUewzVC9ERAwIequkG3Mm25dc+8VgJ+NL jbYQ== X-Forwarded-Encrypted: i=1; AFNElJ8WYpHNp6PqAVLWE2XJITmWnxsplRm92pbUrr3/ECwNlQsD1DqRGA8SxsB8Fjv1gBlXJEN131HpDLc3n24=@vger.kernel.org X-Gm-Message-State: AOJu0Yy87NeI9Vxhl8xl39JXYiK0TAQyP3trIsI7JvzH6WfXDvVo4ufi OCMDBIhi9zv2CdQ9YYWNad54L9EKk6ibdTR5aSdR58ZGy0FXMwN7sWDf X-Gm-Gg: Acq92OHWK+69ny42NuosB7y0iFn57jfaTzWV2jmBVBHEATdOSlj0yDxizjKlb+JXssB hdfNqeUW/RzfPJPxzec5zjvHT4Pj1DmoML1irSJf7WooObGYUISj1fqbPwZXb10jzRX76ML+yB3 4ygkTmVoUqzLBNIwDJ87RJZzN+I9/pezsRvd64r9fP1mVV6On3s4TG//EwSIRVQH9CRJRjWl2ni X9SzA53qRuIpkFtIy2QhJDpy+PY2hbBA2IwChEUIPeNOPO78PGf2U8NBkA4BtI/0KxD7yeLxYMC AfEvh5QnxqhI8e3BhfUdgvzKQhMKcul4hYHfIeNjgj5berBYqtsoncP+mDhcjI0EMTWo/yuMln0 zMmUaxgQZ47RKQZnCiorYmp8pTTIK2P2t2uRyqQ5Tk8MYpkBQX5+EYeylymCp/30CIXICKV+B17 SxMadQyewAUeTyjYNTE8guflfCglilOwUZ10coMzjGvIDRIXu1wLIfaDcYi2W3SUaeZZdaYfD2d ax7qvM4BDaXybVW X-Received: by 2002:a17:90b:5683:b0:359:87a8:e65c with SMTP id 98e67ed59e1d1-365ac080573mr22668476a91.17.1778443258494; Sun, 10 May 2026 13:00:58 -0700 (PDT) Received: from localhost.localdomain ([2409:40f2:38:d6b4:286e:7088:fd10:80a0]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-367d6262349sm5259124a91.6.2026.05.10.13.00.54 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 10 May 2026 13:00:58 -0700 (PDT) From: Kartik Nair To: tomeu@tomeuvizoso.net, ogabbay@kernel.org Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Kartik Nair Subject: [PATCH] accel/rocket: fix ignored return value in rocket_ioctl_submit Date: Mon, 11 May 2026 01:30:47 +0530 Message-ID: <20260510200047.6117-1-contact.kartikn@gmail.com> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit rocket_ioctl_submit() calls rocket_ioctl_submit_job() in a loop but ignores its return value. If any job submission fails, the error is silently dropped and the function returns 0 (success) to userspace, leaving subsequent jobs potentially in an inconsistent state. Fix this by propagating the error and breaking out of the loop on the first failure. Signed-off-by: Kartik Nair --- drivers/accel/rocket/rocket_job.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/drivers/accel/rocket/rocket_job.c b/drivers/accel/rocket/rocket_job.c index ac51bff39..abac26853 100644 --- a/drivers/accel/rocket/rocket_job.c +++ b/drivers/accel/rocket/rocket_job.c @@ -626,8 +626,11 @@ int rocket_ioctl_submit(struct drm_device *dev, void *data, struct drm_file *fil } - for (i = 0; i < args->job_count; i++) - rocket_ioctl_submit_job(dev, file, &jobs[i]); + for (i = 0; i < args->job_count; i++) { + ret = rocket_ioctl_submit_job(dev, file, &jobs[i]); + if (ret) + goto exit; + } exit: kvfree(jobs); -- 2.50.0