From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f176.google.com (mail-pf1-f176.google.com [209.85.210.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id B729630648C for ; Sun, 10 May 2026 20:24:48 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.176 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778444689; cv=none; b=WNMog8kZnNUjeR4PnzlQK4w+3E7q5tYUP+PRhDBFRq7hsXfJgAJdIquKJ6RyMUVc/I2Pc+YlIzgjgQD3bLmjlvRTzrjU6/a4OzF+iW7hafnMO0RBn+2V8HBqPFx2toeyP98iLuq1LfrATESDcA1mD2yfYC+ZdlF+GMUTE5Vmx+Y= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778444689; c=relaxed/simple; bh=7LxAgAe9FAQ/KXXxhJ/6cfjklYMy3iMv32YBM66xjRY=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version; b=OFpqK/5uoDTEFGcU103onYMnwuJK+zvzhTmiO/O0H5MQ4RPmUppjWGG2jc4FOCjtuz0bmIGU89Xa8EwRp3p0RF5x2vOte+Am7vA7ekdl0/cVlvEtsqsJlyaJYR/zZRn3XRPGiHFuYmKslrk1v8NVFh56QZ4Z2Hgh5k2VCEpgqpE= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=U4c8saF+; arc=none smtp.client-ip=209.85.210.176 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="U4c8saF+" Received: by mail-pf1-f176.google.com with SMTP id d2e1a72fcca58-839dc688d6cso1426979b3a.2 for ; Sun, 10 May 2026 13:24:48 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778444688; x=1779049488; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=cs7RR8UfZiloMc+0grbX4/5pEgc7tdI4TgsBvtMnf1s=; b=U4c8saF+uJIMKpb+HBj3t0WwSgb/2V+uHb0znP9U5RyIHyL3eOgz4335L9KuGj1OrS h+DYgGD14jQMpsPOklnzXwgFCsBfLjU5cMx4YwzbHnDOgbMIb+s1SJ1vILSqEH2HUVN+ WJKzDEIo5BGbGRk4Q7C0gB3BsCjTMZJ7L9o+hh2H1/Cto6XSwv2+gbutifEw9ZdRIUdB 7wFqUXmBpXUopMf9zbnTqvM3lqZywgPkr/q1Wyc95YwaKYfY/LGTQ4VuOHNqaW4wBaFx 1gzO2RDJOvgPeMXLHFvjeY5TatdHaArs5F4PoEpu2f16xzSLeUbrbo+iitGjbNXPNdj4 n3cQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778444688; x=1779049488; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=cs7RR8UfZiloMc+0grbX4/5pEgc7tdI4TgsBvtMnf1s=; b=CY2e4+3rQDNCC/X+lJ/51wdPG+2vSEx2Mz2g+a/FPteoTvb10yJxuT4jvfsOCEETFD vH7zPyDqhgxj7JJynbjvoqHts38UMoEh65jtPDMhu9Hr0SwRHcED0b2XNRmOC5yzrf5O 6gJFp3JEJhAEl5UpgtJjay9bloZ8aHzBAjznzVtJZTbQimpYK1oK928atgPiqq5NEjEy joys7MuuQWvbAtt/PPrsx3KwOc2EnxFkcVqX1JT/7YqUP60uibspnPTPYD/OaBx7Rd4e LkAqrAyvvB+UCmddLv2dC128wFbazCN+bmulcfKKv8q5sqN6mMeel1pfPNIbnkN4+dQJ 0hPQ== X-Forwarded-Encrypted: i=1; AFNElJ89HmMbroxbV7EyGjNrkoFx7jxbif4SJaOLToZPicVl9967FwiHaNGQlPvTmJiTg2JcXGNPgG1hkL43j94=@vger.kernel.org X-Gm-Message-State: AOJu0YyQBrkjsDs/3Br+SYqJyAXBsbbFGRrcn2/Qg9zu0sTw75/59yCT +Rvt2LgBiB5E0rYG4sMlUP0H0qx25IofHBjswB7z1eM1T70UqQWZC+1x X-Gm-Gg: Acq92OEhETiHh/flL1sBZQW+C8MTl5sG7OEp/+Dbyi3pj6QS52ScOK6ut5EJaC8HGLK YiW0HaXs90dCYb/UZc8iVsjX+J6Dwbjc/74/EfH6h6QQ/SNdCYX3uGjl4PXWCXfHQkyS26Yb0DJ cUXZCc7KxTuyMNGtPOEg/7ih7qQI6Gv6/M2Z7IZjZoJHYPY56c5tzBn9z17d0ZA8dEZk3P1ADME arPcXi3J2VCkQjJvLAWHrMuuVXPKfYuMnGMSThnDRiA/cr2fUGceIAGcsHruvIorcIHjhju5Imc 0eJJYnucFdW6p/RNe8x9c+vabeNjlz1wbesKAbbDz58u0nfBZgXjfg9FuxDyTHVXZ0oRxQRqbdz EfzBHOAOzMzQS0QlihnRQFTlF+LTASSq+kidnWflKMpQrKYYkXt3GnToNTCi2U6K6I7mAhNxNjw 3MTAcyEcjfKODLa4Pr/vPOhl78/3R+N/AN3TxkbNP0246PVQBLQWcJ8xT62Rx1UqkNaBU= X-Received: by 2002:a05:6a00:3e21:b0:838:af72:fb2a with SMTP id d2e1a72fcca58-83a5b0db426mr20339848b3a.4.1778444688053; Sun, 10 May 2026 13:24:48 -0700 (PDT) Received: from localhost.localdomain ([2409:40f2:38:d6b4:286e:7088:fd10:80a0]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-839681a9e33sm19908156b3a.50.2026.05.10.13.24.44 (version=TLS1_3 cipher=TLS_CHACHA20_POLY1305_SHA256 bits=256/256); Sun, 10 May 2026 13:24:47 -0700 (PDT) From: Kartik Nair To: johannes@sipsolutions.net Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org, Kartik Nair , syzbot+02a1a03b8622d3c7d1c9@syzkaller.appspotmail.com Subject: [PATCH] wifi: cfg80211: validate chandef before calling cfg80211_set_monitor_channel Date: Mon, 11 May 2026 01:54:37 +0530 Message-ID: <20260510202437.7857-1-contact.kartikn@gmail.com> X-Mailer: git-send-email 2.50.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit cfg80211_wext_siwfreq() constructs a channel definition for monitor mode but passes it to cfg80211_set_monitor_channel() without first validating it with cfg80211_chandef_valid(). This causes a WARN_ON in cfg80211_chandef_dfs_required() when it receives an invalid chandef. Add the missing cfg80211_chandef_valid() check before calling cfg80211_set_monitor_channel() to return -EINVAL early on invalid channel definitions, consistent with how other callers handle this. Reported-by: syzbot+02a1a03b8622d3c7d1c9@syzkaller.appspotmail.com Signed-off-by: Kartik Nair --- net/wireless/wext-compat.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/net/wireless/wext-compat.c b/net/wireless/wext-compat.c index 22d9d9bae..63d145b52 100644 --- a/net/wireless/wext-compat.c +++ b/net/wireless/wext-compat.c @@ -789,6 +789,8 @@ static int cfg80211_wext_siwfreq(struct net_device *dev, chandef.chan = ieee80211_get_channel(&rdev->wiphy, freq); if (!chandef.chan) return -EINVAL; + if (!cfg80211_chandef_valid(&chandef)) + return -EINVAL; return cfg80211_set_monitor_channel(rdev, dev, &chandef); case NL80211_IFTYPE_MESH_POINT: freq = cfg80211_wext_freq(wextfreq); -- 2.50.0