From: Tomasz Unger <tomasz.unger@yahoo.pl>
To: Hans de Goede <hansg@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Sakari Ailus <sakari.ailus@linux.intel.com>,
Andy Shevchenko <andy@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: linux-media@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-staging@lists.linux.dev,
Andy Shevchenko <andriy.shevchenko@intel.com>,
Tomasz Unger <tomasz.unger@yahoo.pl>
Subject: [PATCH v2] staging: media: atomisp: remove stale "Generated code" comments
Date: Mon, 11 May 2026 18:55:31 +0200 [thread overview]
Message-ID: <20260511-atomisp-remove-generated-comment-v2-1-6ebc1b2d988f@yahoo.pl> (raw)
In-Reply-To: 20260511-atomisp-remove-generated-comment-v2-1-6ebc1b2d988f.ref@yahoo.pl
Remove the "Generated code: do not edit or commmit." comments from
five files. As suggested by Andy Shevchenko, this code is coupled
with legacy firmware and will never be re-generated, so the comment
is misleading and should be dropped entirely rather than having its
typo fixed.
Suggested-by: Andy Shevchenko <andriy.shevchenko@intel.com>
Signed-off-by: Tomasz Unger <tomasz.unger@yahoo.pl>
---
drivers/staging/media/atomisp/pci/ia_css_isp_configs.c | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_params.c | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_params.h | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_states.c | 1 -
drivers/staging/media/atomisp/pci/ia_css_isp_states.h | 1 -
5 files changed, 5 deletions(-)
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
index 38c9c62366d6..96a8e58cfcee 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_configs.c
@@ -4,7 +4,6 @@
* Copyright (c) 2015, Intel Corporation.
*/
-/* Generated code: do not edit or commmit. */
#define IA_CSS_INCLUDE_CONFIGURATIONS
#include "ia_css_pipeline.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
index 1cd3322b0da0..96af15f62060 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.c
@@ -48,7 +48,6 @@
#include "isp/kernels/eed1_8/ia_css_eed1_8.host.h"
#include "isp/kernels/bnlm/ia_css_bnlm.host.h"
#include "isp/kernels/conversion/conversion_1.0/ia_css_conversion.host.h"
-/* Generated code: do not edit or commmit. */
#include "ia_css_pipeline.h"
#include "ia_css_isp_params.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
index a542f8979905..8c9468c5849f 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_params.h
@@ -4,7 +4,6 @@
* Copyright (c) 2015, Intel Corporation.
*/
-/* Generated code: do not edit or commmit. */
#ifndef _IA_CSS_ISP_PARAM_H
#define _IA_CSS_ISP_PARAM_H
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
index af1765040464..1ea71477e774 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_states.c
@@ -3,7 +3,6 @@
* Support for Intel Camera Imaging ISP subsystem.
* Copyright (c) 2015, Intel Corporation.
*/
-/* Generated code: do not edit or commmit. */
#include "ia_css_pipeline.h"
#include "ia_css_isp_states.h"
diff --git a/drivers/staging/media/atomisp/pci/ia_css_isp_states.h b/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
index d637ea1d13f6..5bd1d4ae1fe4 100644
--- a/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
+++ b/drivers/staging/media/atomisp/pci/ia_css_isp_states.h
@@ -15,7 +15,6 @@
#include "isp/kernels/ynr/ynr_1.0/ia_css_ynr.host.h"
#include "isp/kernels/dpc2/ia_css_dpc2.host.h"
#include "isp/kernels/eed1_8/ia_css_eed1_8.host.h"
-/* Generated code: do not edit or commmit. */
#ifndef _IA_CSS_ISP_STATE_H
#define _IA_CSS_ISP_STATE_H
---
base-commit: ea09c82fbc53aad867541cd2f0bde96c6b228ba0
change-id: 20260511-atomisp-remove-generated-comment-ae5966c5ec7f
Best regards,
--
Tomasz Unger <tomasz.unger@yahoo.pl>
next parent reply other threads:[~2026-05-11 16:55 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20260511-atomisp-remove-generated-comment-v2-1-6ebc1b2d988f.ref@yahoo.pl>
2026-05-11 16:55 ` Tomasz Unger [this message]
2026-05-11 18:23 ` [PATCH v2] staging: media: atomisp: remove stale "Generated code" comments Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260511-atomisp-remove-generated-comment-v2-1-6ebc1b2d988f@yahoo.pl \
--to=tomasz.unger@yahoo.pl \
--cc=andriy.shevchenko@intel.com \
--cc=andy@kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hansg@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=mchehab@kernel.org \
--cc=sakari.ailus@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox