From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id DCA2D372B23; Mon, 11 May 2026 11:26:19 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778498779; cv=none; b=MsvTl/0ycz0hmSm45oHEthK6agBTjAMPomeSRc4GkyqH5POGoeHeBFiYrY3yQ5AfMCF8dL8UZzKB6yrrjZ2BCF5/99nfdtCIlqcvVqbdjYoMInJGK+++GxKqGhmwtzPt/dfeFGcJ6nwlThd2cx1RnrAG29PSoecd6wJlDONBupE= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778498779; c=relaxed/simple; bh=yQRlHBBS5xhN2Pjbuu1tQgwbWuw2+qUIgOa52Ao6Ch0=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=bpg0s9qweTNZv44PZCW7zvehsSra1ncuxM5oURgO9MdqdMHhpNBk218MhWUAm/5EJVIws2ORrB3J5U+kvHhPNd66jQBWuhMjoZp4GcJJBkGX4giQ6TCTAjdaF87L8agFUVn4i8lFlW6S3qrlVVeIVWDJ87G5+qqvrkyezSptSh0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=YVC/Ufzu; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="YVC/Ufzu" Received: by smtp.kernel.org (Postfix) with ESMTPS id A95CEC2BD01; Mon, 11 May 2026 11:26:19 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1778498779; bh=yQRlHBBS5xhN2Pjbuu1tQgwbWuw2+qUIgOa52Ao6Ch0=; h=From:Date:Subject:References:In-Reply-To:To:Cc:Reply-To:From; b=YVC/UfzuntIrZuqYxrux92AUyw9jPpXu/Fco5PLoZtgDIPzlRdauY7XSyaiirlJDL ildHbA9PzYo+7scRbTG+uGpEX115biGr2spVmfdp8vTEIPnS0UNlOYbe5fnesXVJ/q nrP0j7TPhAxmrtSYjz1vwD89R0qWr1WSLFvn0L4RnOriol9+stXR0Fkf/jz/EphZBP kbPV4DJmHKfyt0tj3pkrB14lLgGWG/axmlHbP5/AUT83yaKW6Sg+mT8lmoV5e0R6Uu Eexhoq32MraBUiadd8RmvqGHD54QBLeXwlPvYbjTGTTDNWjbTilU8T6CK1ALrNcNiL WroAWW5dvr1Vw== Received: from aws-us-west-2-korg-lkml-1.web.codeaurora.org (localhost.localdomain [127.0.0.1]) by smtp.lore.kernel.org (Postfix) with ESMTP id A09E0CD4845; Mon, 11 May 2026 11:26:19 +0000 (UTC) From: Joshua Crofts via B4 Relay Date: Mon, 11 May 2026 13:26:14 +0200 Subject: [PATCH v7 5/8] iio: magnetometer: ak8975: unify messages with help of dev_err_probe() Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit Message-Id: <20260511-magnetometer-fixes-post-pickup-v7-5-9d910faa28b6@gmail.com> References: <20260511-magnetometer-fixes-post-pickup-v7-0-9d910faa28b6@gmail.com> In-Reply-To: <20260511-magnetometer-fixes-post-pickup-v7-0-9d910faa28b6@gmail.com> To: Jonathan Cameron , David Lechner , =?utf-8?q?Nuno_S=C3=A1?= , Andy Shevchenko Cc: linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org, Joshua Crofts , Andy Shevchenko X-Mailer: b4 0.14.2 X-Developer-Signature: v=1; a=ed25519-sha256; t=1778498777; l=2489; i=joshua.crofts1@gmail.com; s=20260422; h=from:subject:message-id; bh=Z/54TpFJCPFYq21Icav+9C0RoiajzMWR1WO6QMN1t3U=; b=Ej34ZzIDxj3COcfEXGiT8oT4U0AkL8Er4H76Jqnvzq0rqqvfcdS/RmhrbhuJmJYH9m6PJ+wtw JArK6WiCYoqDt8bdBmexKCIbqGpj1+rIprK5a5PEsbvpXH9668mKmVz X-Developer-Key: i=joshua.crofts1@gmail.com; a=ed25519; pk=Xd+UVoRPiiI0K3LHQ2XIcXmO0jvVuFTv9eTx3lgBphI= X-Endpoint-Received: by B4 Relay for joshua.crofts1@gmail.com/20260422 with auth_id=746 X-Original-From: Joshua Crofts Reply-To: joshua.crofts1@gmail.com From: Andy Shevchenko Unify error messages that might appear during probe phase by switching to use dev_err_probe(). Signed-off-by: Andy Shevchenko Reviewed-by: Nuno Sá Signed-off-by: Joshua Crofts --- drivers/iio/magnetometer/ak8975.c | 30 ++++++++++-------------------- 1 file changed, 10 insertions(+), 20 deletions(-) diff --git a/drivers/iio/magnetometer/ak8975.c b/drivers/iio/magnetometer/ak8975.c index 43259ad4990e2a7a40a0fa60a6ee040c42426b70..2f1442e71607873e869351c379a40dae713a1c84 100644 --- a/drivers/iio/magnetometer/ak8975.c +++ b/drivers/iio/magnetometer/ak8975.c @@ -495,10 +495,8 @@ static int ak8975_who_i_am(const struct ak8975_data *data, AK09912_REG_WIA1, sizeof(wia_val), wia_val); - if (ret < 0) { - dev_err(&client->dev, "Error reading WIA\n"); - return ret; - } + if (ret < 0) + return dev_err_probe(&client->dev, ret, "Error reading WIA\n"); if (wia_val[0] != AK8975_DEVICE_ID) return -ENODEV; @@ -996,18 +994,14 @@ static int ak8975_probe(struct i2c_client *client) return ret; ret = ak8975_who_i_am(data, data->def->type); - if (ret) { - dev_err(&client->dev, "Unexpected device\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "Unexpected device\n"); dev_dbg(&client->dev, "Asahi compass chip %s\n", name); /* Perform some basic start-of-day setup of the device. */ ret = ak8975_setup(data); - if (ret) { - dev_err(&client->dev, "%s initialization fails\n", name); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "%s initialization fails\n", name); ret = devm_mutex_init(dev, &data->lock); if (ret) @@ -1022,20 +1016,16 @@ static int ak8975_probe(struct i2c_client *client) ret = devm_iio_triggered_buffer_setup(dev, indio_dev, NULL, ak8975_handle_trigger, NULL); - if (ret) { - dev_err(&client->dev, "triggered buffer setup failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "triggered buffer setup failed\n"); ret = devm_pm_runtime_enable(dev); if (ret) return ret; ret = devm_iio_device_register(dev, indio_dev); - if (ret) { - dev_err(&client->dev, "device register failed\n"); - return ret; - } + if (ret) + return dev_err_probe(dev, ret, "device register failed\n"); /* * The device comes online in 500us, so add two orders of magnitude -- 2.47.3