From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alone <yogeshdangal66@gmail.com>
Cc: Sudip Mukherjee <sudipm.mukherjee@gmail.com>,
Teddy Wang <teddy.wang@siliconmotion.com>,
linux-fbdev@vger.kernel.org, linux-staging@lists.linux.dev,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] staging: sm750fb: Add const to g_fbmode array
Date: Mon, 11 May 2026 09:57:07 +0200 [thread overview]
Message-ID: <2026051100-mankind-disown-5cf3@gregkh> (raw)
In-Reply-To: <20260509164057.71722-1-yogeshdangal66@gmail.com>
On Sat, May 09, 2026 at 10:25:57PM +0545, Alone wrote:
> From: Chhabilal Dangal <yogeshdangal66@gmail.com>
>
> Add const qualifier to g_fbmode array since the array
> itself is not modified after initialization.
>
> Signed-off-by: Chhabilal Dangal <yogeshdangal66@gmail.com>
> ---
> drivers/staging/sm750fb/sm750.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/sm750fb/sm750.c b/drivers/staging/sm750fb/sm750.c
> index 9f3e3d37e..19c3da654 100644
> --- a/drivers/staging/sm750fb/sm750.c
> +++ b/drivers/staging/sm750fb/sm750.c
> @@ -33,7 +33,7 @@
> static int g_hwcursor = 1;
> static int g_noaccel;
> static int g_nomtrr;
> -static const char *g_fbmode[] = {NULL, NULL};
> +static const char * const g_fbmode[] = {NULL, NULL};
> static const char *g_def_fbmode = "1024x768-32@60";
> static char *g_settings;
> static int g_dualview;
> --
> 2.54.0
>
>
Please always test-build your patches :(
next prev parent reply other threads:[~2026-05-11 7:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-09 16:40 [PATCH] staging: sm750fb: Add const to g_fbmode array Alone
2026-05-11 7:57 ` Greg Kroah-Hartman [this message]
[not found] ` <CAF9nfaDEys+8bcnFRVWWoAvyrvPgXmENbASABG+4dBjMinaP5A@mail.gmail.com>
2026-05-11 10:23 ` Greg Kroah-Hartman
2026-05-11 15:37 ` kernel test robot
-- strict thread matches above, loose matches on Subject: below --
2026-05-11 10:52 Chhabilal Dangal
2026-05-06 3:56 [PATCH] staging: sm750fb: add " Chaitanya Sabnis
2026-05-06 6:27 ` Ahmet Sezgin Duran
2026-05-06 7:14 ` Chaitanya Sabnis
2026-05-06 10:36 ` Ahmet Sezgin Duran
2026-05-06 10:44 ` Chaitanya Sabnis
2026-05-11 20:42 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2026051100-mankind-disown-5cf3@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=linux-fbdev@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=sudipm.mukherjee@gmail.com \
--cc=teddy.wang@siliconmotion.com \
--cc=yogeshdangal66@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox