From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-m1973181.qiye.163.com (mail-m1973181.qiye.163.com [220.197.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4813C21CC51 for ; Mon, 11 May 2026 03:45:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=220.197.31.81 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778471158; cv=none; b=uEVjqP6xWWRQ3i5f6MwiQx5llZX8wXlwSeWiQplGFnqCRfsWnMgYOp13Xphj3hvG8FZTAc9v6VyoHy3qTm12nAoE/MiU39s7syZiko1Idz14iIdO4eftDGNHzCREXEV1vEVjt6r8hHMdlUmfqYZwClErn+sCrbMfeceey4KUFF8= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778471158; c=relaxed/simple; bh=M9A/IRsc7Glqk+nYOtVyC2vpXobY9x7PEU32XyxwDnw=; h=From:To:Cc:Subject:Date:Message-Id:In-Reply-To:References: MIME-Version; b=D6ChyYglbEyfECsUXn7dHBVRRUS0VIFJebxmBZED/Z04ID+HRcRxekTAGwQN8KK3dYFNci+i3pjDtBhIYmRzSY1RGInYE5EFu7a8GF+oLQWCsi5qQORLfWoVyO4pObfjw11f5ACRUplfNbG5XzT33zE+S7SoDov0n8oyVzfp8KM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn; spf=pass smtp.mailfrom=easystack.cn; arc=none smtp.client-ip=220.197.31.81 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=easystack.cn Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=easystack.cn Received: from localhost.localdomain (unknown [218.94.118.90]) by smtp.qiye.163.com (Hmail) with ESMTP id 19f361878; Mon, 11 May 2026 11:30:29 +0800 (GMT+08:00) From: Zhen Ni To: akpm@linux-foundation.org, vbabka@kernel.org Cc: surenb@google.com, mhocko@suse.com, jackmanb@google.com, hannes@cmpxchg.org, ziy@nvidia.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Zhen Ni Subject: [PATCH v6 2/3] mm/page_owner: add NUMA node filter with nodelist support Date: Mon, 11 May 2026 11:30:16 +0800 Message-Id: <20260511033017.747781-3-zhen.ni@easystack.cn> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20260511033017.747781-1-zhen.ni@easystack.cn> References: <20260511033017.747781-1-zhen.ni@easystack.cn> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-HM-Tid: 0a9e1516158f0229kunm0464dab52dcf0b X-HM-MType: 1 X-HM-Spam-Status: e1kfGhgUHx5ZQUpXWQgPGg8OCBgUHx5ZQUlOS1dZFg8aDwILHllBWSg2Ly tZV1koWUFJQjdXWRgWCB1ZQUpXWS1ZQUlXWQ8JGhUIEh9ZQVlCGh1OVk8fGEJCSklKTh1KSFYVFA kWGhdVGRETFhoSFyQUDg9ZV1kYEgtZQVlJSkNVQk9VSkpDVUJLWVdZFhoPEhUdFFlBWU9LSFVKS0 lPT09IVUpLS1VKQktLWQY+ Add NUMA node filtering functionality to page_owner to allow filtering pages by specific NUMA node(s). This is useful for NUMA-aware memory allocation analysis and debugging. The filter supports flexible nodelist input formats: - Single node: echo "0" > nid - Multiple nodes: echo "0,2,3" > nid - Node range: echo "0-3" > nid - Mixed format: echo "0,2-4,7" > nid - Clear filter: echo > nid (empty string) The implementation uses nodemask_t for efficient multi-node filtering and nodelist_parse() for flexible input parsing. Empty input clears the filter. Note: Access to nid_mask uses plain load/store without locking because nodemask_t is too large (128 bytes) for READ_ONCE/WRITE_ONCE. This is safe for debug use: low-frequency changes and torn reads would only cause temporary inconsistency in debug output. Signed-off-by: Zhen Ni --- Changes in v6: - Add node validity check using nodes_subset to reject invalid node numbers that don't exist in the system - Move bool filter_by_nid declaration to top of block - Use kmalloc_objs instead of kmalloc - Remove 100 bytes overhead Changes in v5: - Optimize nodes_empty() check in page iteration loop - Add __data_racy qualifier to nid_mask field Changes in v4: - Remove "-1" support, use empty string to clear filter - Use strncpy_from_user() instead of copy_from_user() - Add concurrency safety documentation for nid_mask access - Rename fops to page_owner_nid_filter_fops for consistency Changes in v3: - Remove READ_ONCE/WRITE_ONCE for nodemask_t (fixes compilation errors) * nodemask_t is a large structure (128 bytes) that triggers compile-time asserts * Direct assignment is safe for this use case - Add comment explaining input length calculation formula * 6 bytes = ",NNNNN" (comma + 5-digit node number) - Simplify "-1" check using kstrtoint() instead of dual strcmp() - Move nodemask_t mask read outside PFN iteration loop for performance * Avoids 128-byte structure copy on each iteration Changes in v2: - Use nodemask_t instead of int to support multiple nodes - Implement nodelist_parse() to support flexible input formats * Single node: "0", "2" * Multiple nodes: "0,2,3" * Ranges: "0-3" * Mixed: "0,2-4,7" - Use %*pbl format for output (e.g., "0-2", "0,2-4,7") - Use dynamic memory allocation (kmalloc) to handle variable-length input - Follow cpuset's max_write_len pattern: (100 + 6 * MAX_NUMNODES) v5: https://lore.kernel.org/linux-mm/20260507064643.179187-3-zhen.ni@easystack.cn/ v4: https://lore.kernel.org/linux-mm/20260430163247.13628-3-zhen.ni@easystack.cn/ v3: https://lore.kernel.org/linux-mm/20260428071112.1420380-4-zhen.ni@easystack.cn/ v2: https://lore.kernel.org/linux-mm/20260419155540.376847-4-zhen.ni@easystack.cn/ v1: https://lore.kernel.org/linux-mm/20260417154638.22370-4-zhen.ni@easystack.cn/ --- mm/page_owner.c | 92 +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 92 insertions(+) diff --git a/mm/page_owner.c b/mm/page_owner.c index 27a412c52d41..8a38005539ff 100644 --- a/mm/page_owner.c +++ b/mm/page_owner.c @@ -67,10 +67,16 @@ static const char * const page_owner_print_mode_strings[] = { struct page_owner_filter { enum page_owner_print_mode print_mode; + /* + * Lockless access: nodemask_t exceeds READ_ONCE/WRITE_ONCE size limit. + * Torn reads acceptable for debug interface with infrequent writes. + */ + nodemask_t __data_racy nid_mask; }; static struct page_owner_filter owner_filter = { .print_mode = PAGE_OWNER_PRINT_FULL_STACK, + .nid_mask = NODE_MASK_NONE, }; static bool page_owner_enabled __initdata; @@ -687,6 +693,8 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) struct page_ext *page_ext; struct page_owner *page_owner; depot_stack_handle_t handle; + nodemask_t mask; + bool filter_by_nid; if (!static_branch_unlikely(&page_owner_inited)) return -EINVAL; @@ -700,6 +708,9 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) while (!pfn_valid(pfn) && (pfn & (MAX_ORDER_NR_PAGES - 1)) != 0) pfn++; + mask = owner_filter.nid_mask; + filter_by_nid = !nodes_empty(mask); + /* Find an allocated page */ for (; pfn < max_pfn; pfn++) { /* @@ -732,6 +743,14 @@ read_page_owner(struct file *file, char __user *buf, size_t count, loff_t *ppos) if (unlikely(!page_ext)) continue; + /* NUMA node filter using bitmask */ + if (filter_by_nid) { + int nid = page_to_nid(page); + + if (!node_isset(nid, mask)) + goto ext_put_continue; + } + /* * Some pages could be missed by concurrent allocation or free, * because we don't hold the zone lock. @@ -1043,6 +1062,77 @@ static const struct file_operations page_owner_print_mode_fops = { .llseek = default_llseek, }; +static ssize_t nid_filter_write(struct file *file, + const char __user *buf, + size_t count, loff_t *ppos) +{ + char *kbuf; + nodemask_t mask; + int ret; + + /* + * Limit input size to handle worst-case nodelist (all nodes). + * Worst case per node: ",NNNNN" (comma + 5-digit node number) = 6 bytes. + */ + if (count > (6 * MAX_NUMNODES)) + return -EINVAL; + + kbuf = kmalloc_objs(*kbuf, count + 1); + if (!kbuf) + return -ENOMEM; + + if (strncpy_from_user(kbuf, buf, count) < 0) { + ret = -EFAULT; + goto out_free; + } + kbuf[count] = '\0'; + + /* Support nodelist format like "0", "0,2", "0-3", or empty to clear */ + if (nodelist_parse(kbuf, mask)) { + ret = -EINVAL; + goto out_free; + } + + /* Validate that all specified nodes actually exist in the system */ + if (!nodes_subset(mask, node_states[N_MEMORY])) { + ret = -EINVAL; + goto out_free; + } + + owner_filter.nid_mask = mask; + ret = count; + +out_free: + kfree(kbuf); + return ret; +} + +static int nid_filter_show(struct seq_file *m, void *v) +{ + nodemask_t mask = owner_filter.nid_mask; + + if (nodes_empty(mask)) + seq_puts(m, "\n"); + else + seq_printf(m, "%*pbl\n", nodemask_pr_args(&mask)); + + return 0; +} + +static int nid_filter_open(struct inode *inode, struct file *file) +{ + return single_open(file, nid_filter_show, NULL); +} + +static const struct file_operations page_owner_nid_filter_fops = { + .owner = THIS_MODULE, + .open = nid_filter_open, + .read = seq_read, + .llseek = seq_lseek, + .write = nid_filter_write, + .release = single_release, +}; + static int __init pageowner_init(void) { @@ -1058,6 +1148,8 @@ static int __init pageowner_init(void) filter_dir = debugfs_create_dir("page_owner_filter", NULL); debugfs_create_file("print_mode", 0600, filter_dir, NULL, &page_owner_print_mode_fops); + debugfs_create_file("nid", 0600, filter_dir, NULL, + &page_owner_nid_filter_fops); dir = debugfs_create_dir("page_owner_stacks", NULL); debugfs_create_file("show_stacks", 0400, dir, -- 2.20.1