From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f42.google.com (mail-wr1-f42.google.com [209.85.221.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2E8F91CD2C for ; Mon, 11 May 2026 04:41:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778474500; cv=none; b=mPl8mrJ3Ujk3UUIFwDe1NVDxVAV3uVRe2DOWCA4lqsvXlDy6aLnYm3WA+6ll3MYiXAApkmN8nmy5CtfypaOR9s3n+ZYD4JPTmc0uOjfEOuOwqInArZUyJL5th/oGAivona69eUn6+/5hDHu6kTuvJlkVV8B8HHTuQayj96Vi12s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778474500; c=relaxed/simple; bh=03nknNNixmoJGQZIQfb5UNGRC7a8plfvBlyB1zfqcnM=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-Type; b=sxI3GgdOGDB2pPuF9CyNzeFhqO0Hz93Sao+M4kwgIOptbYCVdgUUXm60eLsd0T5S5/soL3ObNztYtJkGaAlrcLytpADJRc8gCuH44J0v3Nh5ZmwJppakGhLq9tCH/ozHr6aplINt6mm9PqwP4Ga//hSMKBTFtOlG7Llpnjf04FM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=llrKfxPz; arc=none smtp.client-ip=209.85.221.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="llrKfxPz" Received: by mail-wr1-f42.google.com with SMTP id ffacd0b85a97d-43fe62837baso1873409f8f.3 for ; Sun, 10 May 2026 21:41:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778474497; x=1779079297; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:from:to:cc:subject:date:message-id:reply-to; bh=VDlyASvaraeGyhobDhKssBlnhZl7u+7R/qogLVb4gQI=; b=llrKfxPzmv/zVNTX3hTJHhUeSNkVEa5SIZYArFKKB8xSwTBWETa0D323A6DQql19L7 F9ARA2Qe5LtOMRbaG2fR3HwEiXqXoFXVRLmXXgwYXqalTnVfu66+Z41aerwP1XNecMhE Sltdd8fv5a0qynDoruJM7wR9m1thcMiq8vk6+zpY9CflBGcOy8VGWoNkrwxxnhbR37Fl z18vvkq7cD/6p1xwICFPpvW6Sc4T1T2XH5EXAOgbuMzpK3XkPaR9FojuF50pcKUx3R6J m5V96kq4zO6TUlo1jnYJy0r9yEeWsNlE/AbLkfLU/lKYn6sTAj72OxFZ0mPHTDNgaXAu XtVg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778474497; x=1779079297; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=VDlyASvaraeGyhobDhKssBlnhZl7u+7R/qogLVb4gQI=; b=jPsZOPIWezbd0NJHHOVoAlx4qLlK3gCt9TeXzrK7DhtVkW+yJa3QffaV1ckXtj3oxp DNS2SCQUADGOPpMEUeVsn8GgIhBskiWOBnmny9vs5eJc6obh62+Lg8IaAf8Fcz4LGcPy vub9pn16XMIO+cnVMcg0ZTjNKKopKX5cJGxWa1DtdWRezPqkzDh4TEkP4mbbkPnerqM6 YHGfDX9x8rBegekGRlQ2lfxc+D4XBZF8vHVbKlFnpAoAai9Q9NyOJ8NN0OLOMdsVb1/2 RyKrwVAtQLgH6xB3sB6UpfoF/Bfnz9+NaVITvLvhHQ4UOoyNvsTwS1l5AOBf6/H12YNz MO8Q== X-Forwarded-Encrypted: i=1; AFNElJ8DzYwOqZ/vO87MyfOk5NJbVsTbslpuRta480C9D3KmdP2HkzLT+ofcURjtB6loMSNqaGT1yRtsC/tGWsM=@vger.kernel.org X-Gm-Message-State: AOJu0YwbR976+76uBEYg2omIZk8b19NT/f8zU0BTt5oHG7MIfZ4rOz+f Ui5bbWmOckY++P614uBFUeDrGNWDblIvKBhxwrpgXGslqzcgQGN9M64L X-Gm-Gg: Acq92OGDQumslk7BO6whtNnwOe58c6QE9bJ39YK2YkhaugcSuXtZ/u6okeMOjqq5MNU 7izWEA1qCfcLJDqRt2JruOkFVqF+SpwhSdi9RUBWYdmYDfMiQy5ByTAT4YkOE31gy3Fv/1tpDbC RAR0/hanqZGi8TkG7qa467s0xfYSXmAw/tMgaYuEl+a85Py4qy/Enhm+HeS0bncTBsM0GUePldY zuGys7NtF+yogTFGDnHcWoHsde/tW3PC6YfJub3PPjM880jZFj6PutJRF11KYMUKLEhkFM1pnZ3 4fuhZDgKqFcEsGQ7octk0RmB0rImzQzH32vwaIVaaU4pTbetTvY6Mc0XAWbOULwNX0hhCs2ffJj piKQGwkKQLBzqrqGjyTaOQ7sVtRJmrFCA3Ya72Ii1Pwz/yAwn4fkXNDs0PgHBOmzthy1iiX2UKS GIOmDBEjo68hYtr3rXx3HAR5bSMjrBXVqF8kZFAj+jcKSHPud+PoGl6rF/V7B1obS/uEaslztqn xwPLQfZ0LDhki9FYpuPokJs8Vs9WlIpyjSK3AU9mOoVPldw+UB+XdRwYUzArNlQ7tmONI+Z77FF RZRO/1Fu X-Received: by 2002:a05:6000:184b:b0:43b:962b:5314 with SMTP id ffacd0b85a97d-4515bbdd5a2mr35302753f8f.19.1778474497354; Sun, 10 May 2026 21:41:37 -0700 (PDT) Received: from dynamic-pd01.res.v6.highway.a1.net ([2001:871:25e:8576:c50a:9875:702a:ab71]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-45491304505sm22836366f8f.22.2026.05.10.21.41.35 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Sun, 10 May 2026 21:41:35 -0700 (PDT) From: =?UTF-8?q?Michael=20Steinm=C3=B6tzger?= To: gregkh@linuxfoundation.org Cc: linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org, nikolayof23@gmail.com, =?UTF-8?q?Michael=20Steinm=C3=B6tzger?= Subject: [PATCH v2] staging: rtl8723bs: fix type issue in DYNAMIC_BB_DYNAMIC_TXPWR Date: Mon, 11 May 2026 06:40:29 +0200 Message-ID: <20260511044029.14839-1-m.steinmoetzger@gmail.com> X-Mailer: git-send-email 2.54.0 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Add explicit cast to fix -Werror=overflow warning for BIT(2) usage in DYNAMIC_BB_DYNAMIC_TXPWR Suggested-by: Nikolay Kulikov Signed-off-by: Michael Steinmötzger --- Changes in v2: - remove BIT2 macro in osdep_service.h - migrate DYNAMIC_BB_DYNAMIC_TXPWR macro in rtw_mlme_ext.h to BIT(2) - cast usage of DYNAMIC_BB_DYNAMIC_TXPWR to u32 in rtw_wlan_util.c v1: https://lore.kernel.org/linux-staging/20260509032202.146240-1-m.steinmoetzger@gmail.com drivers/staging/rtl8723bs/core/rtw_wlan_util.c | 4 ++-- drivers/staging/rtl8723bs/include/osdep_service.h | 1 - drivers/staging/rtl8723bs/include/rtw_mlme_ext.h | 2 +- 3 files changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c index d837738b9f40..943e199ede82 100644 --- a/drivers/staging/rtl8723bs/core/rtw_wlan_util.c +++ b/drivers/staging/rtl8723bs/core/rtw_wlan_util.c @@ -1476,13 +1476,13 @@ void update_IOT_info(struct adapter *padapter) pmlmeinfo->turboMode_cts2self = 0; pmlmeinfo->turboMode_rtsen = 1; /* disable high power */ - Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false); + Switch_DM_Func(padapter, ((u32)(~DYNAMIC_BB_DYNAMIC_TXPWR)), false); break; case HT_IOT_PEER_REALTEK: /* rtw_write16(padapter, 0x4cc, 0xffff); */ /* rtw_write16(padapter, 0x546, 0x01c0); */ /* disable high power */ - Switch_DM_Func(padapter, (~DYNAMIC_BB_DYNAMIC_TXPWR), false); + Switch_DM_Func(padapter, ((u32)(~DYNAMIC_BB_DYNAMIC_TXPWR)), false); break; default: pmlmeinfo->turboMode_cts2self = 0; diff --git a/drivers/staging/rtl8723bs/include/osdep_service.h b/drivers/staging/rtl8723bs/include/osdep_service.h index bd72edcb4259..2f5011a8210c 100644 --- a/drivers/staging/rtl8723bs/include/osdep_service.h +++ b/drivers/staging/rtl8723bs/include/osdep_service.h @@ -14,7 +14,6 @@ #include -#define BIT2 0x00000004 extern int RTW_STATUS_CODE(int error_code); diff --git a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h index a4770f5eb75c..f832d77d7156 100644 --- a/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h +++ b/drivers/staging/rtl8723bs/include/rtw_mlme_ext.h @@ -28,7 +28,7 @@ /* ====== ODM_ABILITY_E ======== */ /* BB ODM section BIT 0-15 */ #define DYNAMIC_BB_DIG BIT(0) /* ODM_BB_DIG */ -#define DYNAMIC_BB_DYNAMIC_TXPWR BIT2 /* ODM_BB_DYNAMIC_TXPWR */ +#define DYNAMIC_BB_DYNAMIC_TXPWR BIT(2) /* ODM_BB_DYNAMIC_TXPWR */ #define DYNAMIC_BB_ANT_DIV BIT(6) /* ODM_BB_ANT_DIV */ /* RF ODM section BIT 24-31 */ -- 2.54.0