From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from verein.lst.de (verein.lst.de [213.95.11.211]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 4B532194C96 for ; Mon, 11 May 2026 06:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=213.95.11.211 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778480966; cv=none; b=FpVkwpZcil5rO8d8jl/sClHB4K357Tf1ND2zX/s7vgAzNyjgMD842W6BtQbo17HTfAVRsoH6CaSeoPM5fEa7Xq8FlX+9zTAV81iyaC0D/xWj7I2KTVJmytudNunmsVdVj2y/r8a4eBXCAyfaxxn3PdBe9nEUFeZeze8D5bMlChY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778480966; c=relaxed/simple; bh=JNuldnQ7u/OqYdEwyznMvSUv5Xri/cwuquyFzDhukNU=; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version: Content-Type:Content-Disposition:In-Reply-To; b=jgEKP5QP9Zbu1O3WpxpRsX5hUdBzyyMjQe7UXOQoUUYn5Z/bzwrdTL7oYN4MJT61AzW2bPvN2Z2CxyofzpCrEb1CEUmW8qkh0is44tKs7kuAsscKZZlYptZ6pPTyE4Ww8COyIm9JnX8kgEb8BCUJiFnxUcbWMhn6zbDOwZCXDTY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de; spf=pass smtp.mailfrom=lst.de; arc=none smtp.client-ip=213.95.11.211 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=lst.de Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=lst.de Received: by verein.lst.de (Postfix, from userid 2407) id 820CD68B05; Mon, 11 May 2026 08:20:31 +0200 (CEST) Date: Mon, 11 May 2026 08:20:31 +0200 From: Christoph Hellwig To: Wilfred Mallawa Cc: Keith Busch , Jens Axboe , Christoph Hellwig , Sagi Grimberg , linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org, alistair.francis@wdc.com, Wilfred Mallawa Subject: Re: [PATCH] nvme/tcp: handle rejected keys for secure concatnation Message-ID: <20260511062031.GA25956@lst.de> References: <20260511005454.2486599-2-wilfred.opensource@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20260511005454.2486599-2-wilfred.opensource@gmail.com> User-Agent: Mutt/1.5.17 (2007-11-01) s/concatnation/concatenation/ in the subject. The changes itself look good to me, but I'd rather leave review to someone who knows that code.