From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out-177.mta0.migadu.com (out-177.mta0.migadu.com [91.218.175.177]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 65A7E3290C9 for ; Mon, 11 May 2026 07:33:53 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=91.218.175.177 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778484835; cv=none; b=otK7UwxGUA9cJvKM/YHL4ZF9/hGJLmqVRMztMxkxwj8gNg537L7JV/Y+lxjj0Xd/63bE429RvAOKyJlNXsvi6edKSS9aiR5zo70vkaqcDfUAJH3LNoNrzQX5bFUFk9alfAdJKEbomglnKK9TI45PAUUrJYtYgIZ9Dc4MpODKMdQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778484835; c=relaxed/simple; bh=I/v976Gm5CwRZpO4wo+StIZNBpliDHsSmWk90Z0f5Ks=; h=From:To:Cc:Subject:Date:Message-ID:MIME-Version:Content-type; b=EVTMipPmRdiNZ0xW3a2zWzZG5l5OyGm94VrlaV2Mcy6K8k7Oz0NoMOSNUYvGFhVsxvpaguYsUAex1e2uwWKr69LVYUV9jblPpc1s3tHplxWXl6GMmB0nieOyq3SQyW+eK/ZO+aHkzyVbee84Czv3OWENBBrel8S+HEjIYeZO/to= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev; spf=pass smtp.mailfrom=linux.dev; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b=IZdOkapu; arc=none smtp.client-ip=91.218.175.177 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linux.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linux.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=linux.dev header.i=@linux.dev header.b="IZdOkapu" X-Report-Abuse: Please report any abuse attempt to abuse@migadu.com and include these headers. DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux.dev; s=key1; t=1778484831; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=6CufjDIbsHluKLDnrdwi6M4/DWOeucI07hgQwDXDTzA=; b=IZdOkapusyDwnQPRt6JRPBqB6nGg28KiP14ZABhXymIu8yc6wIOL/RiaErJvEdwDwLAx5F ALbuBKpgxPivhc2EDQ1J49h/du88OwvEhKfqYDoRcoZprdodgOPot+l2PQeFplOAzlybXX 1JVDz24lE0PR09eB0yE6AUnqMJ5MIjg= From: Baoquan He To: linux-mm@kvack.org Cc: akpm@linux-foundation.org, usama.arif@linux.dev, chrisl@kernel.org, baohua@kernel.org, kasong@tencent.com, nphamcs@gmail.com, shikemeng@huaweicloud.com, youngjun.park@lge.com, linux-kernel@vger.kernel.org, Baoquan He Subject: [PATCH v5 0/3] mm/swap: use swap_ops to register swap device's methods Date: Mon, 11 May 2026 15:33:31 +0800 Message-ID: <20260511073334.635682-1-baoquan.he@linux.dev> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-type: text/plain Content-Transfer-Encoding: 8bit X-Migadu-Flow: FLOW_OUT This can simplify the code logic and benefit any new type of swap device added later. And also do renaming in this patchset: ------- file renaming: --- mm/page_io.c to mm/swap_io.c function renaming: --- swap_writepage_* to swap_write_folio_* in file mm/swap_io.c Changlog: === -v5: * Change the return value of init_swap_ops() as -EINVAL as per Chris's suggestion and adjust its invocation in swapon() accordingly. * Add Chris and Usama's Ack tags. -v4: * Fix a typo opeations -> operations * Fix a code bug inside init_swap_ops(). I was taking a change at the time, thought the change is trivial, so I only compiled but didn't run kernel to test in v3. Now fix it and test passed. Thanaks to Usama for catching the above two issues. -v3: * Rename setup_swap_ops() to init_swap_ops() which reflect the function behaviour a little better * Check if sis->ops, sis->ops->read_folio and sis->ops->write_folio is NULL in init_swap_ops(), but not spread them where they are called. And once the checking failed, fail swapon immediately. This is suggested by Chris. * Call init_swap_ops() before setup_swap_extents() invocation. This doesn't harm anything and can benefit later adding sis->ops->swap_activate method. -v2: * lots of cleanup for patch 2/3: renaming, moving data structures, and using const properly * collected tags from Kairui, Nhat and Barry -v1: https://lore.kernel.org/linux-mm/20260302104016.163542-1-bhe@redhat.com/ Baoquan He (3): mm/swap: rename mm/page_io.c to mm/swap_io.c mm/swap: use swap_ops to register swap device's methods mm/swap_io.c: rename swap_writepage_* to swap_write_folio_* MAINTAINERS | 2 +- include/linux/swap.h | 2 + mm/Makefile | 2 +- mm/swap.h | 12 ++++- mm/{page_io.c => swap_io.c} | 104 ++++++++++++++++++++---------------- mm/swapfile.c | 4 ++ mm/zswap.c | 2 +- 7 files changed, 78 insertions(+), 50 deletions(-) rename mm/{page_io.c => swap_io.c} (90%) -- 2.52.0