From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-pf1-f172.google.com (mail-pf1-f172.google.com [209.85.210.172]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5AD383BAD9C for ; Mon, 11 May 2026 09:11:33 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.210.172 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490696; cv=none; b=fCZMl9WhtpFHA4+/wxJO2qWCCucCj7kMxCZWhMzUYkQGs3dJdA2dA2B7vPv5c4CZ5Ur9y+Hgw3fR3a/a7UydtokJblgQo9MKbp77YPMdFFAj3JVFFRvus/6Ur2ELcaym3l+Z5dW4XzX8jOUXEP2IUAoEJe/krB8qrbBzAxOUzho= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1778490696; c=relaxed/simple; bh=2Fbe+51I+NHaqoJEm/Ia1P/RkOrsQ8sOHQ84+D4jX5M=; h=From:To:Cc:Subject:Date:Message-ID:In-Reply-To:References: MIME-Version; b=YnIQbpJbVrcZ3VUww6kZiEYRadAvu90N+LYxy3jjKnQk2TZ/m801jbVrKo7rVABhipu5WG9PRKJWsnAvHBlLDgyy3XKWUzbn5me25Ww7tMR+eJsNRAp1MxyGTuGFslw4ZCrxSwZeroWGrGOYghV4kPeABKe8n+iyjIuwJinpphk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=fOXjKgBI; arc=none smtp.client-ip=209.85.210.172 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="fOXjKgBI" Received: by mail-pf1-f172.google.com with SMTP id d2e1a72fcca58-837dfccd950so1847259b3a.0 for ; Mon, 11 May 2026 02:11:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1778490693; x=1779095493; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:from:to:cc:subject:date :message-id:reply-to; bh=mrmu7Ax8Tjv7DXY7cz3wQn6QU0gYid8cSWvbdHALi/M=; b=fOXjKgBIrUxxlZjeFfSpBfmeSr06lnAC4d5lOm/VuJBSZ+DfFbQ28rGcumpRJya7Aq Ep+DOmMcJgQ201ciw8u4WJHAknq3991Ef2eH4bUeeYHI5bQ4CeyFxgoq61PzvpKeY11U OrZxA2SefhJw8MynFVzCKWYpCV/cDmjEsfdCvf9SWYXJ+UIfu0+wde4VMaw298nk/vj9 Zctmjl6kDX68Gt4RKKS/ybYK96T7sv5ElZ3wazkUfYCrwr5vFACA79BzlQnC//9pAUVs RuTNy/QyZ5dOPdB+yqJLMBNBYfYUEnnWtKiS+qZ6zvLNPRF3mKugYMLbqOlMQAVUGx+P 3a6Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1778490693; x=1779095493; h=content-transfer-encoding:mime-version:references:in-reply-to :message-id:date:subject:cc:to:from:x-gm-gg:x-gm-message-state:from :to:cc:subject:date:message-id:reply-to; bh=mrmu7Ax8Tjv7DXY7cz3wQn6QU0gYid8cSWvbdHALi/M=; b=ApCP7QdDSUMut/97FO6VpM2ZUt3CPJS7DeCywYLcAFVyIV7ji3ClSG37HyvDwfR+jl L4TOyvU6ehBfY1NL+/TAukR1aSSnz7WE6S92l+j8HRegxVoJ9wG768f02MUNEZ8wWy5w uoqQRiZN2wK6tYS3IoHnNzX9ax2WPTiKWiRpzsRKetjwoFuxj0N2YXudyUOGkibHDO3I eWyPyBlwEmA2O0rEGn6rnPx5gQ75bp5f2BRO3PlzL0xCsPAp0ZjSnKyxTsDD47xRFprV KbDdKqknf60Gh18YPfQtEnnybxG4NRC68PpjLCMwBAyYdZaho4Qqkqty3zYgb1SpGqAA M2UA== X-Forwarded-Encrypted: i=1; AFNElJ9IQzASihEYNH+Px9ZUjQgU888ubTd5XvtVirtegxl3MPidt4aPNm1eK8ZexrNruzY9MLPtaCgLOXlwVx0=@vger.kernel.org X-Gm-Message-State: AOJu0YynlW6lxV8KotKzQNucPK2wf3Csa4EXQhvIbkPpqLYs/eLvfFza mejFXosecPhUdSm5ugH1jt2q2EcduTutRbqoDBq/12jb/HH1rsbFhpLb X-Gm-Gg: Acq92OGiPTYAUop1E8hoCDySrsvXey6gqEw8mo4iGBK0NqwQIVOZ7uCRwS5Cn9RynNB KN+4d3BOGYETi2pMLykrqRxdqtC8fXh6PBs/rpXel7EvekbwiZa2sYrteCmtnHRd7qm/cij3zQX mA7QBWmHhTShxQ17JRxUj0UjDBpOpxkkCncf07EOIwjQ5cw1f3LKJfQFdaXdSi9S4Q/rCYDIHVw IYZJNVv2sjR22VB9VulPmNvPOPkx+uuJg8bb9q2cH0oHN3A0Mh04osfPxzs/n/FQKoLsSP2Yk9c GIa/zrx2E+UVqXUEXKQUjgSvS7ULDqEh2wpU3fuUVdvxOd9edvmfzW7K4eeaC3Q5Tdd1DSJUGI1 b2fA5eJsFXtT/on0im0OlLtnrpZ/AHaQaKWg4tjxcj2N79/p4OeFsTfnQ9WJnrMrYqIuWrq2E12 CxrWZqAW9EUvEAV4opDHUDpRo= X-Received: by 2002:a05:6a20:3ca5:b0:3a1:d516:36ec with SMTP id adf61e73a8af0-3aa5ad31592mr26172526637.56.1778490692746; Mon, 11 May 2026 02:11:32 -0700 (PDT) Received: from nuvole ([2409:8a34:5f37:1974:abc5:99cd:a924:4e86]) by smtp.gmail.com with ESMTPSA id d2e1a72fcca58-8396563f11csm24775517b3a.3.2026.05.11.02.11.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 11 May 2026 02:11:32 -0700 (PDT) From: Pengyu Luo To: Rob Herring , Krzysztof Kozlowski , Conor Dooley , Frank Li , Sascha Hauer , Pengutronix Kernel Team , Fabio Estevam , Sakari Ailus , Martin Kepplinger-Novakovic , Mauro Carvalho Chehab , Hans Verkuil , Sebastian Krzyszkowiak Cc: devicetree@vger.kernel.org, imx@lists.linux.dev, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Pengyu Luo Subject: [PATCH v3 1/5] media: hi846: fix hi846_write_reg_16 handling Date: Mon, 11 May 2026 17:09:20 +0800 Message-ID: <20260511090924.269106-2-mitltlatltl@gmail.com> X-Mailer: git-send-email 2.54.0 In-Reply-To: <20260511090924.269106-1-mitltlatltl@gmail.com> References: <20260511090924.269106-1-mitltlatltl@gmail.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Transfer-Encoding: 8bit hi846_write_reg_16() does not clear a positive *err value on success. pm_runtime_get_if_in_use() returns a positive value when the device is already in use. When hi846_set_ctrl() passes &ret holding this positive value) to hi846_write_reg_16(), the function returns with ret as is, the positive value propagates back as a return code, which callers interpret as an error. Fix this by resetting *err to 0 only when it is positive. Fixes: 04fc06f6dc15 ("media: hi846: fix usage of pm_runtime_get_if_in_use()") Signed-off-by: Pengyu Luo --- drivers/media/i2c/hi846.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/media/i2c/hi846.c b/drivers/media/i2c/hi846.c index a3f77b8434ca..7f069aca0fce 100644 --- a/drivers/media/i2c/hi846.c +++ b/drivers/media/i2c/hi846.c @@ -1271,6 +1271,8 @@ static void hi846_write_reg_16(struct hi846 *hi846, u16 reg, u16 val, int *err) if (*err < 0) return; + *err = 0; + put_unaligned_be16(reg, buf); put_unaligned_be16(val, buf + 2); ret = i2c_master_send(client, buf, sizeof(buf)); -- 2.54.0